KEMBAR78
Add stripPrefix of webpack://_N_E/ by tm1000 · Pull Request #15955 · vercel/next.js · GitHub
Skip to content

Add stripPrefix of webpack://_N_E/ #15955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2020
Merged

Add stripPrefix of webpack://_N_E/ #15955

merged 2 commits into from
Aug 11, 2020

Conversation

@tm1000
Copy link
Contributor

@tm1000 tm1000 commented Aug 6, 2020 •
edited
Loading

In with-sentry add stripPrefix of webpack://_N_E/. This removes the webpack://_N_E/ prefix from the stack trace which will help Sentry to understand what is "App Only" vs "Full"

I'll fully tested calling errors in browser and the stack traces are still aligned and linked correctly. This just gets rid of the extra data in the front which seems to be the same for everyone and I believe it comes from webpack 5 (?)

@tm1000
Add stripPrefix of webpack://_N_E/
dd759ef 
In sentry add stripPrefix of webpack://_N_E/. This removes the "webpack://_N_E/" prefix from the stack trace which will help Sentry to understand what is "App Only" vs "Full"
@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 6, 2020
@ijjk
Copy link
Member

ijjk commented Aug 6, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tm1000/next.js patch-1 Change
buildDuration 13.5s 13.1s -383ms
nodeModulesSize 65.9 MB 65.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tm1000/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.607 2.293 -0.31
/ avg req/sec 958.8 1090.37 +131.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.333 1.22 -0.11
/error-in-render avg req/sec 1874.99 2049.57 +174.58
Client Bundles (main, webpack, commons)
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..795d.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c30ac70..0d39.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-61da9c7..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tm1000/next.js patch-1 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tm1000/next.js patch-1 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tm1000/next.js patch-1 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tm1000/next.js patch-1 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Rendered Page Sizes
vercel/next.js canary tm1000/next.js patch-1 Change
index.html gzip 946 B 946 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary tm1000/next.js patch-1 Change
buildDuration 15.1s 14.5s -561ms
nodeModulesSize 65.9 MB 65.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..795d.js gzip 9.99 kB 9.99 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-c30ac70..0d39.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..dule.js gzip 5.89 kB 5.89 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-61da9c7..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tm1000/next.js patch-1 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tm1000/next.js patch-1 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-f4d2979..e57b.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tm1000/next.js patch-1 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-653c74f..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tm1000/next.js patch-1 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 553 B 553 B ✓
Serverless bundles
vercel/next.js canary tm1000/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: dd759ef

scefali
scefali approved these changes Aug 11, 2020
View reviewed changes
Copy link

@scefali scefali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijjk
Copy link
Member

ijjk commented Aug 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tm1000/next.js patch-1 Change
buildDuration 11.5s 11.4s -95ms
nodeModulesSize 57.3 MB 57.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tm1000/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.317 2.14 -0.18
/ avg req/sec 1078.88 1168.06 +89.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.396 1.298 -0.1
/error-in-render avg req/sec 1790.77 1926.39 +135.62
Client Bundles (main, webpack, commons)
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tm1000/next.js patch-1 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tm1000/next.js patch-1 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tm1000/next.js patch-1 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tm1000/next.js patch-1 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary tm1000/next.js patch-1 Change
index.html gzip 945 B 945 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary tm1000/next.js patch-1 Change
buildDuration 13.5s 13.4s -47ms
nodeModulesSize 57.3 MB 57.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tm1000/next.js patch-1 Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tm1000/next.js patch-1 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tm1000/next.js patch-1 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tm1000/next.js patch-1 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tm1000/next.js patch-1 Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary tm1000/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 24046c6

@kodiakhq kodiakhq bot merged commit 2301331 into vercel:canary Aug 11, 2020
@jasonwilliams
Copy link

@tm1000 what does the _N_E stand for and where does it come from?

@timneutkens
Copy link
Member

timneutkens commented Aug 13, 2020 •
edited
Loading

It's the library name set by Next.js in the webpack config which is required for webpack 5. I already told the Sentry folks that this is likely a bug in their webpack plugin that it's not stripping out the library name 👍

m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@tm1000
Add stripPrefix of webpack://_N_E/ (vercel#15955)
d8f49df 
In with-sentry add stripPrefix of `webpack://_N_E/`. This removes the `webpack://_N_E/` prefix from the stack trace which will help Sentry to understand what is "App Only" vs "Full"

I'll fully tested calling errors in browser and the stack traces are still aligned and linked correctly. This just gets rid of the extra data in the front which seems to be the same for everyone and I believe it comes from webpack 5 (?)
@KonnorRogers KonnorRogers mentioned this pull request Mar 29, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

+1 more reviewer

@scefali scefali scefali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tm1000 @ijjk @jasonwilliams @timneutkens @scefali