KEMBAR78
Update with-typescript-graphql by piglovesyou · Pull Request #16101 · vercel/next.js · GitHub
Skip to content

Conversation

@piglovesyou
Copy link
Contributor

@piglovesyou piglovesyou commented Aug 12, 2020

  • Use the latest graphql-let@0.15.0
    • Jest test integration
    • Demonstrate use of multiple GraphQL schema files as **/*.graphqls
    • Demonstrate GraphQL fragments by #import
  • Use @apollo/client@3
  • Cleanup dependencies

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 12, 2020
@ijjk
Copy link
Member

ijjk commented Aug 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 10s 10.4s ⚠️ +419ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall increase ✓
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 1.75 1.824 ⚠️ +0.07
/ avg req/sec 1428.96 1370.36 ⚠️ -58.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.034 1.007 -0.03
/error-in-render avg req/sec 2416.7 2482.03 +65.33
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.6 kB 56.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.6 kB 51.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 945 B 945 B
link.html gzip 954 B 954 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 11.1s 11.5s ⚠️ +435ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.6 kB 56.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.6 kB 51.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: 51912d8

@piglovesyou piglovesyou force-pushed the update-with-typescript-graphql branch from 51912d8 to f599364 Compare August 12, 2020 12:02
@piglovesyou piglovesyou changed the title Update with-typescript-graphql [wip] Update with-typescript-graphql Aug 12, 2020
@ijjk
Copy link
Member

ijjk commented Aug 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 14.3s 14s -276ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 2.519 2.63 ⚠️ +0.11
/ avg req/sec 992.44 950.58 ⚠️ -41.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.554 1.548 -0.01
/error-in-render avg req/sec 1609.11 1615.31 +6.2
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.6 kB 56.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.6 kB 51.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 945 B 945 B
link.html gzip 954 B 954 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 16.2s 16s -194ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.6 kB 56.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.6 kB 51.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: f599364

@piglovesyou
Copy link
Contributor Author

It turns out it needs more effort. Sorry for bothering, I'll finish this later.

@piglovesyou piglovesyou force-pushed the update-with-typescript-graphql branch from f599364 to 1d0dca8 Compare August 13, 2020 08:40
* Use the latest graphql-let@0.15.0
    * Demonstrate multiple files of GraphQL schema as `**/*.graphqls`
    * Demonstrate GraphQL fragments as `#import`
* Use @apollo/client@3
@piglovesyou piglovesyou force-pushed the update-with-typescript-graphql branch from 1d0dca8 to 05b7266 Compare August 13, 2020 08:46
@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 14s 14s ⚠️ +15ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall increase ✓
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 2.632 2.651 ⚠️ +0.02
/ avg req/sec 949.81 942.95 ⚠️ -6.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.688 1.557 -0.13
/error-in-render avg req/sec 1480.78 1606.06 +125.28
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..9460.js gzip 9.93 kB 9.93 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.5 kB 56.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.84 kB 5.84 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 949 B 949 B
link.html gzip 956 B 956 B
withRouter.html gzip 943 B 943 B
Overall change 2.85 kB 2.85 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 15.9s 16.3s ⚠️ +427ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..9460.js gzip 9.93 kB 9.93 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.5 kB 56.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.84 kB 5.84 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: 1d0dca8

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 12.9s 13s ⚠️ +181ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 2.503 2.428 -0.08
/ avg req/sec 998.67 1029.87 +31.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.471 1.547 ⚠️ +0.08
/error-in-render avg req/sec 1699.43 1615.97 ⚠️ -83.46
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..9460.js gzip 9.93 kB 9.93 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.5 kB 56.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.84 kB 5.84 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 949 B 949 B
link.html gzip 956 B 956 B
withRouter.html gzip 943 B 943 B
Overall change 2.85 kB 2.85 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 14.5s 14.6s ⚠️ +70ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..9460.js gzip 9.93 kB 9.93 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.5 kB 56.5 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 5.84 kB 5.84 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 273 B 273 B
_buildManife..dule.js gzip 279 B 279 B
Overall change 552 B 552 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: 05b7266

@piglovesyou piglovesyou changed the title [wip] Update with-typescript-graphql Update with-typescript-graphql Aug 13, 2020
@piglovesyou
Copy link
Contributor Author

It's ready to be reviewed, glad if you take a look.

- typescript
- typescript-operations
- typescript-react-apollo
respectGitIgnore: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not required anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking. That is because now it becomes the default value.

@@ -1,5 +1,6 @@
import React from 'react'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next.js automatically adds this import to react files, let's remove it from here and from other files where it was also added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know that, I'll remove these lines.

)
}

return <div>Loading...</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add a loading here? in this page the data will always be defined, otherwise it's broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I'll make the test work assuming the data always exists.

Comment on lines 44 to 46
<MockedProvider mocks={mocks} addTypename={false}>
<Index />
</MockedProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very into tests like this one, this can break very easily if the component uses other kinds of context, like the one used by the Next.js Router. i.e if the page uses useRouter this will break.

Unit components like this one are okay for single UI components, but overall they aren't very useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, while components/*.tsxs should be portable, naturally pages/*.tsxs tend to be bound by specific contexts. Here, as an Apollo example, it demonstrates how tests of page components would look. Perhaps, other contexts will be required soon in real-world projects as another example indicates but I think it's up to users if they keep maintaining or erase the test.

Would you like tests of context-free components, or still think it's a good idea to including Apollo Testing example?

Comment on lines 48 to 51
expect(component.toJSON()).toMatchSnapshot('loading')
// Wait for state change of data loading
await renderer.act(() => timeout(0))
expect(component.toJSON()).toMatchSnapshot('loaded')
Copy link
Member

@lfades lfades Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the page doesn't need a loading state as it's statically pre-generated, this will never happen in the app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, definitely. I'll make the apollo mock have data from the beginning.

@@ -0,0 +1,3 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to let Jest refer to the babel config, so that Jest can inject import React from 'react'.

- typescript-operations
- typescript-react-apollo
respectGitIgnore: true
cacheDir: __generated__
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some .tsx will go in this dir. The default cacheDir is node_modules/graphql-let/__generated__, but Babel doesn't work on files in node_modules so I need get them out.

* Remove "import React"
* Assume data is always non-null since it's statically resolved
* Expose "next/babel" in babelrc to be used by jest, so `import 'react'`
can be omitted
@piglovesyou piglovesyou force-pushed the update-with-typescript-graphql branch from 55a4f85 to 6c2ce72 Compare August 14, 2020 16:03
@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 13.1s 13.2s ⚠️ +71ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 2.299 2.298 0
/ avg req/sec 1087.52 1088.04 +0.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.256 1.401 ⚠️ +0.15
/error-in-render avg req/sec 1990.66 1784.47 ⚠️ -206.19
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 650 B 650 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 946 B 946 B
link.html gzip 954 B 954 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 14.7s 14.8s ⚠️ +174ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 650 B 650 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: 55a4f85

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 12.2s 12.3s ⚠️ +136ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall increase ✓
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 2.21 2.2 -0.01
/ avg req/sec 1131.36 1136.42 +5.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.22 1.191 -0.03
/error-in-render avg req/sec 2049.66 2098.54 +48.88
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 650 B 650 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 946 B 946 B
link.html gzip 954 B 954 B
withRouter.html gzip 939 B 939 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 14s 13.9s -59ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 650 B 650 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.26 MB 5.26 MB
Commit: 6c2ce72

@ijjk
Copy link
Member

ijjk commented Aug 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 12.1s 12.3s ⚠️ +245ms
nodeModulesSize 57.3 MB 57.3 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
/ failed reqs 0 0
/ total time (seconds) 2.151 2.174 ⚠️ +0.02
/ avg req/sec 1162.12 1150.05 ⚠️ -12.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.171 1.18 ⚠️ +0.01
/error-in-render avg req/sec 2134.44 2119.5 ⚠️ -14.94
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-52b3964..e4b8.js gzip 6.74 kB 6.74 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-af2596f..dule.js gzip 5.82 kB 5.82 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 650 B 650 B
Rendered Page Sizes
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
index.html gzip 947 B 947 B
link.html gzip 955 B 955 B
withRouter.html gzip 942 B 942 B
Overall change 2.84 kB 2.84 kB

Serverless Mode
General
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
buildDuration 13.8s 13.9s ⚠️ +87ms
nodeModulesSize 57.3 MB 57.3 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
main-52b3964..e4b8.js gzip 6.74 kB 6.74 kB
webpack-ccf5..276a.js gzip 751 B 751 B
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
main-af2596f..dule.js gzip 5.82 kB 5.82 kB
webpack-10c7..dule.js gzip 751 B 751 B
Overall change 51.8 kB 51.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
polyfills-75..1629.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB
hooks-585f07..95a3.js gzip 887 B 887 B
index-c7b63f..fc02.js gzip 227 B 227 B
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB
routerDirect..ebc7.js gzip 284 B 284 B
withRouter-2..db68.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_app-97e743e..dule.js gzip 626 B 626 B
_error-b4004..dule.js gzip 2.3 kB 2.3 kB
hooks-696209..dule.js gzip 387 B 387 B
index-a4dd74..dule.js gzip 226 B 226 B
link-236a801..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-1..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 650 B 650 B
Serverless bundles
vercel/next.js canary piglovesyou/next.js update-with-typescript-graphql Change
_error.js 1.03 MB 1.03 MB
404.html 4.18 kB 4.18 kB
hooks.html 3.82 kB 3.82 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.27 MB 5.27 MB
Commit: 3afbb0e

@piglovesyou
Copy link
Contributor Author

Appreciate if you take a look again. It's because of my fault, but there are users complaining launch failure.

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Timer Timer merged commit 04c9906 into vercel:canary Aug 30, 2020
@piglovesyou
Copy link
Contributor Author

Thank you for reviewing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants