KEMBAR78
Correct a couple of small grammar errors. by gr-qft · Pull Request #16221 · vercel/next.js · GitHub
Skip to content

Correct a couple of small grammar errors. #16221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2020
Merged

Correct a couple of small grammar errors. #16221

merged 1 commit into from
Aug 15, 2020

Conversation

gr-qft
Copy link
Contributor

@gr-qft gr-qft commented Aug 15, 2020

Just noticed a couple of tiny grammar errors.

@ijjk
Copy link
Member

ijjk commented Aug 15, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
buildDuration 11.6s 12.2s ⚠️ +589ms
nodeModulesSize 57.3 MB 57.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.044 2.017 -0.03
/ avg req/sec 1223.08 1239.63 +16.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.166 1.119 -0.05
/error-in-render avg req/sec 2144.42 2234.56 +90.14
Client Bundles (main, webpack, commons)
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-52b3964..e4b8.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-af2596f..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
index.html gzip 947 B 947 B ✓
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
buildDuration 13.9s 13.4s -511ms
nodeModulesSize 57.3 MB 57.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-52b3964..e4b8.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-af2596f..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles
vercel/next.js canary tuan-m-ng/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: 57ae27b

@timneutkens
Copy link
Member

Awesome, thanks!

@kodiakhq kodiakhq bot merged commit 2cb05b5 into vercel:canary Aug 15, 2020
@gr-qft
Copy link
Contributor Author

gr-qft commented Aug 15, 2020

Awesome, thanks!

👍

@gr-qft gr-qft deleted the patch-1 branch August 15, 2020 21:54
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@gr-qft
Correct a couple of small grammar errors. (vercel#16221)
7ca41e3 
Just noticed a couple of tiny grammar errors.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gr-qft @ijjk @timneutkens