KEMBAR78
[Examples] Remove horizontal scroll in CMS examples by todortotev · Pull Request #16295 · vercel/next.js · GitHub
Skip to content

[Examples] Remove horizontal scroll in CMS examples #16295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 18, 2020
Merged

[Examples] Remove horizontal scroll in CMS examples #16295

merged 4 commits into from
Aug 18, 2020

Conversation

@todortotev
Copy link
Contributor

Closes #16286

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 18, 2020
@ijjk
Copy link
Member

ijjk commented Aug 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
buildDuration 10.4s 10.4s -26ms
nodeModulesSize 57.6 MB 57.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.96 1.916 -0.04
/ avg req/sec 1275.38 1304.93 +29.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.197 1.194 0
/error-in-render avg req/sec 2088.46 2094.35 +5.89
Client Bundles (main, webpack, commons)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..aa9e.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6444cad..dba4.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-532811e..dule.js gzip 6.18 kB 6.18 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
index.html gzip 946 B 946 B ✓
link.html gzip 951 B 951 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
buildDuration 11.6s 11.7s ⚠️ +51ms
nodeModulesSize 57.6 MB 57.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..aa9e.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6444cad..dba4.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-532811e..dule.js gzip 6.18 kB 6.18 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: ca50398

Timer
Timer approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Aug 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
buildDuration 12.4s 12.4s -37ms
nodeModulesSize 57.6 MB 57.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.349 2.427 ⚠️ +0.08
/ avg req/sec 1064.35 1029.95 ⚠️ -34.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.425 1.505 ⚠️ +0.08
/error-in-render avg req/sec 1754.12 1660.98 ⚠️ -93.14
Client Bundles (main, webpack, commons)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1ea360d..8d32.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ece3b39..dule.js gzip 6.18 kB 6.18 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
index.html gzip 947 B 947 B ✓
link.html gzip 950 B 950 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.83 kB 2.83 kB ✓
Serverless Mode
General
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
buildDuration 14.7s 14.1s -574ms
nodeModulesSize 57.6 MB 57.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-1ea360d..8d32.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ece3b39..dule.js gzip 6.18 kB 6.18 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary todortotev/next.js horizontal-bar-fix Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: 88b9e47

@Timer Timer merged commit b0d2a80 into vercel:canary Aug 18, 2020
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@todortotev
[Examples] Remove horizontal scroll in CMS examples (vercel#16295)
502aa61
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

examples Issue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[eaxmple] These examples have not been fixed yet.

3 participants

@todortotev @ijjk @Timer