KEMBAR78
Add at attribute to image preload link by atcastle · Pull Request #16328 · vercel/next.js · GitHub
Skip to content

Add at attribute to image preload link #16328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2020
Merged

Add at attribute to image preload link #16328

merged 2 commits into from
Aug 18, 2020

Conversation

atcastle
Copy link
Contributor

Fixes a small error in the image preload post-processor. Adds a needed 'as' attribute to the link.

@ijjk
Copy link
Member

ijjk commented Aug 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 11.8s 12.4s ⚠️ +611ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +35 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.259 2.192 -0.07
/ avg req/sec 1106.79 1140.55 +33.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.215 1.213 0
/error-in-render avg req/sec 2058.36 2061.66 +3.3
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d4a9454..9415.js gzip 7.18 kB 7.18 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e6b1c3e..dule.js gzip 6.2 kB 6.2 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
index.html gzip 947 B 947 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 13.3s 13.8s ⚠️ +507ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +35 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d4a9454..9415.js gzip 7.18 kB 7.18 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e6b1c3e..dule.js gzip 6.2 kB 6.2 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_error.js 1.03 MB 1.03 MB ⚠️ +11 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +11 B
link.js 1.07 MB 1.07 MB ⚠️ +11 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +11 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +11 B
Overall change 5.27 MB 5.27 MB ⚠️ +55 B
Commit: 001793d

@ijjk
Copy link
Member

ijjk commented Aug 18, 2020

Failing test suites

Commit: 001793d

test/integration/image-optimization/test/index.test.js

  • Image optimization for SSR apps > On a static page > should preload exactly two eligible images
  • Image optimization for SSR apps > On an SSR page > should preload exactly two eligible images
  • Image optimization for serverless apps > On a static page > should preload exactly two eligible images
  • Image optimization for serverless apps > On an SSR page > should preload exactly two eligible images
Expand output

● Image optimization for SSR apps › On a static page › should preload exactly two eligible images

expect(received).toContain(expected) // indexOf

Expected substring: "<link rel=\"preload\" href=\"main-image-1.jpg\"/>"
Received string:    "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><link rel=\"preload\" href=\"main-image-1.jpg\" as=\"image\"/><link rel=\"preload\" href=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/index-c2c31cb9448dc0b18fa7.js\" as=\"script\"/></head><body><div id=\"__next\"><div><link rel=\"preload\" href=\"already-preloaded.jpg\"/><img src=\"already-preloaded.jpg\"/><img src=\"tiny-image.jpg\" width=\"20\" height=\"20\"/><img src=\"hidden-image-1.jpg\" hidden=\"\"/><div hidden=\"\"><img src=\"hidden-image-2.jpg\"/></div><img src=\"main-image-1.jpg\"/><div><img src=\"main-image-2.jpg\"/></div><img src=\"main-image-3.jpg\"/><img src=\"main-image-4.jpg\"/><img src=\"main-image-5.jpg\"/></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/\",\"query\":{},\"buildId\":\"M3A3faHQIaHuvHi_0jMQ_\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-e60bf636a1339bc95b80.js\"></script><script src=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/index-c2c31cb9448dc0b18fa7.js\" async=\"\"></script><script src=\"/_next/static/M3A3faHQIaHuvHi_0jMQ_/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/M3A3faHQIaHuvHi_0jMQ_/_ssgManifest.js\" async=\"\"></script></body></html>"

  54 |   it('should preload exactly two eligible images', async () => {
  55 |     const html = await renderViaHTTP(appPort, path)
> 56 |     expect(html).toContain('<link rel="preload" href="main-image-1.jpg"/>')
     |                  ^
  57 |     expect(html).not.toContain('<link rel="preload" href="main-image-2.jpg"/>')
  58 |   })
  59 | }

  at Object.<anonymous> (integration/image-optimization/test/index.test.js:56:18)

● Image optimization for SSR apps › On an SSR page › should preload exactly two eligible images

expect(received).toContain(expected) // indexOf

Expected substring: "<link rel=\"preload\" href=\"main-image-1.jpg\"/>"
Received string:    "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><link rel=\"preload\" href=\"main-image-1.jpg\" as=\"image\"/><link rel=\"preload\" href=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/stars-90f7a93c13c75cf71a0a.js\" as=\"script\"/></head><body><div id=\"__next\"><div class=\"container\"><main><div><link rel=\"preload\" href=\"already-preloaded.jpg\"/><img src=\"already-preloaded.jpg\"/><img src=\"tiny-image.jpg\" width=\"20\" height=\"20\"/><img src=\"hidden-image-1.jpg\" hidden=\"\"/><div hidden=\"\"><img src=\"hidden-image-2.jpg\"/></div><img src=\"main-image-1.jpg\"/><img src=\"main-image-2.jpg\"/><img src=\"main-image-3.jpg\"/><img src=\"main-image-4.jpg\"/><img src=\"main-image-5.jpg\"/></div><div>Next stars: <!-- -->118.8637572547564</div></main></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"stars\":118.8637572547564}},\"page\":\"/stars\",\"query\":{},\"buildId\":\"M3A3faHQIaHuvHi_0jMQ_\",\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-e60bf636a1339bc95b80.js\"></script><script src=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/stars-90f7a93c13c75cf71a0a.js\" async=\"\"></script><script src=\"/_next/static/M3A3faHQIaHuvHi_0jMQ_/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/M3A3faHQIaHuvHi_0jMQ_/_ssgManifest.js\" async=\"\"></script></body></html>"

  54 |   it('should preload exactly two eligible images', async () => {
  55 |     const html = await renderViaHTTP(appPort, path)
> 56 |     expect(html).toContain('<link rel="preload" href="main-image-1.jpg"/>')
     |                  ^
  57 |     expect(html).not.toContain('<link rel="preload" href="main-image-2.jpg"/>')
  58 |   })
  59 | }

  at Object.<anonymous> (integration/image-optimization/test/index.test.js:56:18)

● Image optimization for serverless apps › On a static page › should preload exactly two eligible images

expect(received).toContain(expected) // indexOf

Expected substring: "<link rel=\"preload\" href=\"main-image-1.jpg\"/>"
Received string:    "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><link rel=\"preload\" href=\"main-image-1.jpg\" as=\"image\"/><link rel=\"preload\" href=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/index-c2c31cb9448dc0b18fa7.js\" as=\"script\"/></head><body><div id=\"__next\"><div><link rel=\"preload\" href=\"already-preloaded.jpg\"/><img src=\"already-preloaded.jpg\"/><img src=\"tiny-image.jpg\" width=\"20\" height=\"20\"/><img src=\"hidden-image-1.jpg\" hidden=\"\"/><div hidden=\"\"><img src=\"hidden-image-2.jpg\"/></div><img src=\"main-image-1.jpg\"/><div><img src=\"main-image-2.jpg\"/></div><img src=\"main-image-3.jpg\"/><img src=\"main-image-4.jpg\"/><img src=\"main-image-5.jpg\"/></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/\",\"query\":{},\"buildId\":\"wRlnt5rue3ddC0V0ZvgFl\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-e60bf636a1339bc95b80.js\"></script><script src=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/index-c2c31cb9448dc0b18fa7.js\" async=\"\"></script><script src=\"/_next/static/wRlnt5rue3ddC0V0ZvgFl/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/wRlnt5rue3ddC0V0ZvgFl/_ssgManifest.js\" async=\"\"></script></body></html>"

  54 |   it('should preload exactly two eligible images', async () => {
  55 |     const html = await renderViaHTTP(appPort, path)
> 56 |     expect(html).toContain('<link rel="preload" href="main-image-1.jpg"/>')
     |                  ^
  57 |     expect(html).not.toContain('<link rel="preload" href="main-image-2.jpg"/>')
  58 |   })
  59 | }

  at Object.<anonymous> (integration/image-optimization/test/index.test.js:56:18)

● Image optimization for serverless apps › On an SSR page › should preload exactly two eligible images

expect(received).toContain(expected) // indexOf

Expected substring: "<link rel=\"preload\" href=\"main-image-1.jpg\"/>"
Received string:    "<!DOCTYPE html><html><head><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><link rel=\"preload\" href=\"main-image-1.jpg\" as=\"image\"/><link rel=\"preload\" href=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/stars-90f7a93c13c75cf71a0a.js\" as=\"script\"/></head><body><div id=\"__next\"><div class=\"container\"><main><div><link rel=\"preload\" href=\"already-preloaded.jpg\"/><img src=\"already-preloaded.jpg\"/><img src=\"tiny-image.jpg\" width=\"20\" height=\"20\"/><img src=\"hidden-image-1.jpg\" hidden=\"\"/><div hidden=\"\"><img src=\"hidden-image-2.jpg\"/></div><img src=\"main-image-1.jpg\"/><img src=\"main-image-2.jpg\"/><img src=\"main-image-3.jpg\"/><img src=\"main-image-4.jpg\"/><img src=\"main-image-5.jpg\"/></div><div>Next stars: <!-- -->313.11347999428386</div></main></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"stars\":313.11347999428386}},\"page\":\"/stars\",\"query\":{},\"buildId\":\"wRlnt5rue3ddC0V0ZvgFl\",\"runtimeConfig\":{},\"nextExport\":false,\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-e60bf636a1339bc95b80.js\"></script><script src=\"/_next/static/chunks/main-862bda6839def7d5cddd.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-e067438c4cf4ef2ef178.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.d462f293190b01a8404a.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.0c7935f47c1e8ab4e0e3.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.b6a1f9b54f63f233016b.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-4bff2fda9499ea38a103.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/stars-90f7a93c13c75cf71a0a.js\" async=\"\"></script><script src=\"/_next/static/wRlnt5rue3ddC0V0ZvgFl/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/wRlnt5rue3ddC0V0ZvgFl/_ssgManifest.js\" async=\"\"></script></body></html>"

  54 |   it('should preload exactly two eligible images', async () => {
  55 |     const html = await renderViaHTTP(appPort, path)
> 56 |     expect(html).toContain('<link rel="preload" href="main-image-1.jpg"/>')
     |                  ^
  57 |     expect(html).not.toContain('<link rel="preload" href="main-image-2.jpg"/>')
  58 |   })
  59 | }

  at Object.<anonymous> (integration/image-optimization/test/index.test.js:56:18)

@ijjk
Copy link
Member

ijjk commented Aug 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 10.4s 10.4s -2ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +35 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.861 1.877 ⚠️ +0.02
/ avg req/sec 1343.17 1331.92 ⚠️ -11.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.04 1.048 ⚠️ +0.01
/error-in-render avg req/sec 2403.09 2385.97 ⚠️ -17.12
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d4a9454..9415.js gzip 7.18 kB 7.18 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e6b1c3e..dule.js gzip 6.2 kB 6.2 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
index.html gzip 947 B 947 B ✓
link.html gzip 952 B 952 B ✓
withRouter.html gzip 938 B 938 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 11.7s 11.7s -21ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +35 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d4a9454..9415.js gzip 7.18 kB 7.18 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e6b1c3e..dule.js gzip 6.2 kB 6.2 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_error.js 1.03 MB 1.03 MB ⚠️ +11 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +11 B
link.js 1.07 MB 1.07 MB ⚠️ +11 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +11 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +11 B
Overall change 5.27 MB 5.27 MB ⚠️ +55 B
Commit: b3cc250

@kodiakhq kodiakhq bot merged commit 7198cbe into vercel:canary Aug 18, 2020
@prateekbh prateekbh deleted the fix-image-preload-tag branch August 18, 2020 21:23
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@atcastle
Add at attribute to image preload link (vercel#16328)
30fbc0d 
Fixes a small error in the image preload post-processor. Adds a needed 'as' attribute to the link.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

+1 more reviewer

@prateekbh prateekbh prateekbh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atcastle @ijjk @prateekbh @timneutkens