KEMBAR78
Correct shallow routing behavior through history by ijjk · Pull Request #16477 · vercel/next.js · GitHub
Skip to content

Correct shallow routing behavior through history #16477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 22, 2020
Merged

Correct shallow routing behavior through history #16477

merged 5 commits into from
Aug 22, 2020

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Aug 22, 2020

When navigating from a non-shallow page to a page that was navigated to shallowly in history it causes incorrect page data to be shown since an incorrect shallow navigation is done. We can only maintain shallow routing when the current page was navigated to shallowly and the page being navigated to in history was also navigated to shallowly. Additional tests to ensure this behavior is working has also been added.

Closes: #7395
Closes: #14928
Fixes: #16028

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member Author

ijjk commented Aug 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
buildDuration 12.9s 13.3s ⚠️ +424ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +477 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.489 2.514 ⚠️ +0.02
/ avg req/sec 1004.45 994.23 ⚠️ -10.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.481 1.461 -0.02
/error-in-render avg req/sec 1687.94 1711.03 +23.09
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..07ae.js gzip 10.3 kB 10.3 kB ⚠️ +28 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ⚠️ +28 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..dule.js gzip 6.12 kB 6.15 kB ⚠️ +27 B
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ⚠️ +27 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
index.html gzip 946 B 949 B ⚠️ +3 B
link.html gzip 953 B 955 B ⚠️ +2 B
withRouter.html gzip 938 B 940 B ⚠️ +2 B
Overall change 2.84 kB 2.84 kB ⚠️ +7 B

Diffs

Diff for 677f882d2ed8..924f5943c.js 
@@ -895,6 +895,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           this.isSsr = void 0;
           this.isFallback = void 0;
           this._inFlightRoute = void 0;
+          this._shallow = void 0;
 
           this.onPopState = function(e) {
             var state = e.state;
@@ -949,7 +950,14 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               return;
             }
 
-            _this.change("replaceState", url, as, options);
+            _this.change(
+              "replaceState",
+              url,
+              as,
+              Object.assign({}, options, {
+                shallow: options.shallow && _this._shallow
+              })
+            );
           }; // represents the current component key
 
           this.route = (0, _normalizeTrailingSlash.removePathTrailingSlash)(
@@ -1392,6 +1400,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               }
 
               if (method !== "pushState" || (0, _utils.getURL)() !== as) {
+                this._shallow = options.shallow;
                 window.history[method](
                   {
                     url: url,
Diff for 677f882d2ed8..33.module.js 
@@ -749,6 +749,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           this.isSsr = void 0;
           this.isFallback = void 0;
           this._inFlightRoute = void 0;
+          this._shallow = void 0;
 
           this.onPopState = e => {
             var state = e.state;
@@ -796,7 +797,14 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               return;
             }
 
-            this.change("replaceState", url, as, options);
+            this.change(
+              "replaceState",
+              url,
+              as,
+              Object.assign({}, options, {
+                shallow: options.shallow && this._shallow
+              })
+            );
           }; // represents the current component key
 
           this.route = (0, _normalizeTrailingSlash.removePathTrailingSlash)(
@@ -1089,6 +1097,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           }
 
           if (method !== "pushState" || (0, _utils.getURL)() !== as) {
+            this._shallow = options.shallow;
             window.history[method](
               {
                 url,
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d25e2803cd924f5943c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d25e2803cd924f5943c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d25e2803cd924f5943c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
buildDuration 14.8s 14.7s -151ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +477 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..07ae.js gzip 10.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..7f47.js gzip N/A 10.3 kB N/A
Overall change 57.2 kB 57.2 kB ⚠️ +28 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..dule.js gzip 6.12 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 6.15 kB N/A
Overall change 52.1 kB 52.1 kB ⚠️ +27 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ⚠️ +147 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +147 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +147 B
Overall change 5.28 MB 5.28 MB ⚠️ +441 B
Commit: 99068dd

lfades
lfades approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijjk
Copy link
Member Author

ijjk commented Aug 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
buildDuration 10.8s 11.4s ⚠️ +594ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +477 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.959 2.08 ⚠️ +0.12
/ avg req/sec 1275.84 1201.88 ⚠️ -73.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.137 1.047 -0.09
/error-in-render avg req/sec 2198.01 2387.46 +189.45
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..07ae.js gzip 10.3 kB 10.3 kB ⚠️ +28 B
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.2 kB 57.2 kB ⚠️ +28 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..dule.js gzip 6.12 kB 6.15 kB ⚠️ +27 B
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.1 kB 52.1 kB ⚠️ +27 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
index.html gzip 946 B 949 B ⚠️ +3 B
link.html gzip 953 B 955 B ⚠️ +2 B
withRouter.html gzip 938 B 940 B ⚠️ +2 B
Overall change 2.84 kB 2.84 kB ⚠️ +7 B

Diffs

Diff for 677f882d2ed8..924f5943c.js 
@@ -895,6 +895,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           this.isSsr = void 0;
           this.isFallback = void 0;
           this._inFlightRoute = void 0;
+          this._shallow = void 0;
 
           this.onPopState = function(e) {
             var state = e.state;
@@ -949,7 +950,14 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               return;
             }
 
-            _this.change("replaceState", url, as, options);
+            _this.change(
+              "replaceState",
+              url,
+              as,
+              Object.assign({}, options, {
+                shallow: options.shallow && _this._shallow
+              })
+            );
           }; // represents the current component key
 
           this.route = (0, _normalizeTrailingSlash.removePathTrailingSlash)(
@@ -1392,6 +1400,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               }
 
               if (method !== "pushState" || (0, _utils.getURL)() !== as) {
+                this._shallow = options.shallow;
                 window.history[method](
                   {
                     url: url,
Diff for 677f882d2ed8..33.module.js 
@@ -749,6 +749,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           this.isSsr = void 0;
           this.isFallback = void 0;
           this._inFlightRoute = void 0;
+          this._shallow = void 0;
 
           this.onPopState = e => {
             var state = e.state;
@@ -796,7 +797,14 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               return;
             }
 
-            this.change("replaceState", url, as, options);
+            this.change(
+              "replaceState",
+              url,
+              as,
+              Object.assign({}, options, {
+                shallow: options.shallow && this._shallow
+              })
+            );
           }; // represents the current component key
 
           this.route = (0, _normalizeTrailingSlash.removePathTrailingSlash)(
@@ -1089,6 +1097,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           }
 
           if (method !== "pushState" || (0, _utils.getURL)() !== as) {
+            this._shallow = options.shallow;
             window.history[method](
               {
                 url,
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d25e2803cd924f5943c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d25e2803cd924f5943c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d25e2803cd924f5943c.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59cdb6da0c36e297704b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b468a46ee8da7b068233.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ff433bba6b32893b2029.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
buildDuration 12.5s 12.4s -91ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +477 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..07ae.js gzip 10.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-978aff6..e7ab.js gzip 7.2 kB 7.2 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..7f47.js gzip N/A 10.3 kB N/A
Overall change 57.2 kB 57.2 kB ⚠️ +28 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
677f882d2ed8..dule.js gzip 6.12 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-46b15db..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 6.15 kB N/A
Overall change 52.1 kB 52.1 kB ⚠️ +27 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/history-shallow-routing Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ⚠️ +147 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +147 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +147 B
Overall change 5.28 MB 5.28 MB ⚠️ +441 B
Commit: 02091c8

@kodiakhq kodiakhq bot merged commit 32ee65e into vercel:canary Aug 22, 2020
@ijjk ijjk deleted the fix/history-shallow-routing branch August 23, 2020 01:37
This was referenced Aug 24, 2020
Closed
Closed
@ijjk ijjk mentioned this pull request Sep 8, 2020
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lfades lfades lfades approved these changes

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

2 participants

@ijjk @lfades