KEMBAR78
fix gtag syntax in measuring docs by hallaji · Pull Request #16933 · vercel/next.js · GitHub
Skip to content

fix gtag syntax in measuring docs #16933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2020
Merged

fix gtag syntax in measuring docs #16933

merged 2 commits into from
Sep 12, 2020

Conversation

@hallaji
Copy link
Contributor

@hallaji hallaji commented Sep 8, 2020

I just realised gtag.js has a different syntax compared to analytics.js as below:

gtag('event', <action>, {
  'event_category': <category>,
  'event_label': <label>,
  'value': <value>
});

@hallaji
fix gtag syntax
6b28e86 
`gtag.js` has a different syntax compared to `analytics.js`.
@hallaji hallaji mentioned this pull request Sep 8, 2020
Merged
@ijjk
Copy link
Member

ijjk commented Sep 8, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary hallaji/next.js patch-1 Change
buildDuration 13.2s 13.2s ⚠️ +3ms
nodeModulesSize 56.7 MB 56.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hallaji/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.27 2.31 ⚠️ +0.04
/ avg req/sec 1101.3 1082.14 ⚠️ -19.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.242 1.303 ⚠️ +0.06
/error-in-render avg req/sec 2012.94 1918.27 ⚠️ -94.67
Client Bundles (main, webpack, commons)
vercel/next.js canary hallaji/next.js patch-1 Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-4d826ad..023b.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary hallaji/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-4dbc74f..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hallaji/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hallaji/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary hallaji/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary hallaji/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary hallaji/next.js patch-1 Change
index.html gzip 970 B 970 B ✓
link.html gzip 977 B 977 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary hallaji/next.js patch-1 Change
buildDuration 14.4s 14.8s ⚠️ +381ms
nodeModulesSize 56.7 MB 56.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary hallaji/next.js patch-1 Change
677f882d2ed8..a2cc.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-4d826ad..023b.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary hallaji/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.62 kB 6.62 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-4dbc74f..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hallaji/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hallaji/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary hallaji/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary hallaji/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary hallaji/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.3 MB 5.3 MB ✓
Commit: 6b28e86

leerob
leerob approved these changes Sep 11, 2020
View reviewed changes
docs/advanced-features/measuring-performance.md
> window.gtag('send', 'event', {
> eventCategory:
> window.gtag('event', name, {
> event_category:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see that reflected here. Good catch!

@Timer Timer merged commit d4a8d4f into vercel:canary Sep 12, 2020
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@hallaji
fix gtag syntax in measuring docs (vercel#16933)
da6d617
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

+1 more reviewer

@leerob leerob leerob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hallaji @ijjk @Timer @leerob