KEMBAR78
[Breaking] Remove deprecated built-in AMP by devjiwonchoi · Pull Request #84312 · vercel/next.js · GitHub
Skip to content

[Breaking] Remove deprecated built-in AMP #84312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 30, 2025
Merged

[Breaking] Remove deprecated built-in AMP #84312

merged 5 commits into from
Sep 30, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Sep 28, 2025 •
edited
Loading

This PR removes the deprecated built-in AMP support. Will follow up with cleaning up the examples, docs, and codemods.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Sep 28, 2025
@devjiwonchoi Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi changed the title Remove tests and fixtures from test/ dir [Breaking] Remove deprecated built-in AMP Sep 28, 2025
@ijjk
Copy link
Member

ijjk commented Sep 28, 2025 •
edited
Loading

Failing test suites

Commit: f3324b1 | About building and testing Next.js

pnpm test test/integration/next-image-new/default/test/static.test.ts (turbopack)

  • Static Image Component Tests > development mode > Should allow an image with a static src to omit height and width (DD)
Expand output

● Static Image Component Tests › development mode › Should allow an image with a static src to omit height and width

page.waitForSelector: Timeout 5000ms exceeded.
Call log:
  - waiting for locator('#basic-static') to be visible

  511 |
  512 |     return this.startChain(async () => {
> 513 |       const el = await page.waitForSelector(selector, {
      |                             ^
  514 |         timeout,
  515 |         state,
  516 |       })

  at waitForSelector (lib/browsers/playwright.ts:513:29)
  at Playwright._chain (lib/browsers/playwright.ts:643:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:624:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:512:17)
  at Playwright.waitForElementByCss [as elementByCss] (lib/browsers/playwright.ts:397:17)
  at Playwright.elementByCss [as elementById] (lib/browsers/playwright.ts:417:17)
  at Object.elementById (integration/next-image-new/default/test/static.test.ts:26:26)

@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch from e33d0a1 to 7a1137f Compare September 28, 2025 14:36
@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch 6 times, most recently from 7c1ff1f to 36e94bc Compare September 28, 2025 20:27
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Sep 28, 2025
@devjiwonchoi
Remove tests and fixtures from test/ dir
a3c1004
@devjiwonchoi
Remove "deletable" files and modify related files
085a06c 
Related files are that imports the deleted files or has relation to those files
@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch 2 times, most recently from a605f65 to e3332ab Compare September 28, 2025 20:35
vercel[bot]
vercel bot reviewed Sep 28, 2025
View reviewed changes
@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch from e3332ab to ac74785 Compare September 28, 2025 20:58
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 28, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #84312 will not alter performance

Comparing jiwon/09-28-_breaking_remove_deprecated_built-in_amp (f3324b1) with canary (8e11bf4)

Summary

✅ 17 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch 3 times, most recently from c1f159a to 4439a5d Compare September 28, 2025 21:38
vercel[bot]
vercel bot reviewed Sep 28, 2025
View reviewed changes
@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch 3 times, most recently from ac10a04 to d9499e3 Compare September 28, 2025 23:00
@devjiwonchoi
Remove AMP sources
e1b56aa
@devjiwonchoi
Remove AMP dependencies
ac8df71 
- Remove deps
- Remove amp files from packge.json "files"
- Remove from taskfile.js
- Run ncc-compiled
@devjiwonchoi devjiwonchoi force-pushed the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch from d9499e3 to f3324b1 Compare September 28, 2025 23:12
@devjiwonchoi devjiwonchoi mentioned this pull request Sep 29, 2025
Closed
@devjiwonchoi
Copy link
Member Author

devjiwonchoi commented Sep 29, 2025 •
edited
Loading

The deployment test failure of test/e2e/async-modules/index.test.ts is irrelevant to this PR.
Confirmed in #84349, and will follow up fixing it.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review September 29, 2025 17:35
@vercel
Copy link
Contributor

vercel bot commented Sep 29, 2025 •
edited
Loading

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

This was referenced Sep 29, 2025
Merged
Merged
Merged
devjiwonchoi added a commit that referenced this pull request Sep 30, 2025
@devjiwonchoi
docs: Remove AMP docs (#84357)
2318b5e 
Stacked on #84312

Removes the AMP docs, which is no longer supported.
devjiwonchoi added a commit that referenced this pull request Sep 30, 2025
@devjiwonchoi
examples: Remove AMP example (#84355)
a843a49 
Stacked on #84312

Removes the AMP example, which is no longer supported.
@devjiwonchoi devjiwonchoi merged commit a432e06 into canary Sep 30, 2025
306 of 314 checks passed
@devjiwonchoi devjiwonchoi deleted the jiwon/09-28-_breaking_remove_deprecated_built-in_amp branch September 30, 2025 16:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@ztanner ztanner ztanner approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked tests Turbopack Related to Turbopack with Next.js. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devjiwonchoi @ijjk @ztanner