KEMBAR78
Revert "Revert "Revert "Add a --webpack flag and default --turbopack to true (#84216)""" by ijjk · Pull Request #84389 · vercel/next.js · GitHub
Skip to content

Revert "Revert "Revert "Add a --webpack flag and default --turbopack to true (#84216)""" #84389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Revert "Revert "Revert "Add a --webpack flag and default --turbopack to true (#84216)""" #84389

merged 1 commit into from
Sep 30, 2025

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 30, 2025

These are still failing so reverting again to keep canary in clean state https://github.com/vercel/next.js/actions/runs/18143375558/job/51641994595

Reverts #84351

@linear
Copy link

linear bot commented Sep 30, 2025

Issue reopened: PACK-5598 Revert "Revert "Add a --webpack flag and default --turbopack to true (#84216)""

@ijjk
Copy link
Member Author

ijjk commented Sep 30, 2025 •
edited
Loading

Failing test suites

Commit: 55e3059 | About building and testing Next.js

pnpm test test/integration/next-image-new/default/test/static.test.ts (turbopack)

  • Static Image Component Tests > development mode > Should allow an image with a static src to omit height and width (DD)
Expand output

● Static Image Component Tests › development mode › Should allow an image with a static src to omit height and width

page.waitForSelector: Timeout 5000ms exceeded.
Call log:
  - waiting for locator('#basic-static') to be visible

  511 |
  512 |     return this.startChain(async () => {
> 513 |       const el = await page.waitForSelector(selector, {
      |                             ^
  514 |         timeout,
  515 |         state,
  516 |       })

  at waitForSelector (lib/browsers/playwright.ts:513:29)
  at Playwright._chain (lib/browsers/playwright.ts:643:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:624:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:512:17)
  at Playwright.waitForElementByCss [as elementByCss] (lib/browsers/playwright.ts:397:17)
  at Playwright.elementByCss [as elementById] (lib/browsers/playwright.ts:417:17)
  at Object.elementById (integration/next-image-new/default/test/static.test.ts:26:26)

pnpm test-start-turbo test/e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts (turbopack)

  • PPR - partial hydration > No static shell, no streaming metadata > should hydrate the shell without waiting for slow suspense boundaries (DD)
  • PPR - partial hydration > Static shell, no streaming metadata > should hydrate the shell without waiting for slow suspense boundaries (DD)
Expand output

● PPR - partial hydration › Static shell, no streaming metadata › should hydrate the shell without waiting for slow suspense boundaries

page.waitForSelector: Timeout 10ms exceeded.
Call log:
  - waiting for locator('#dynamic-fallback') to be visible

  511 |
  512 |     return this.startChain(async () => {
> 513 |       const el = await page.waitForSelector(selector, {
      |                             ^
  514 |         timeout,
  515 |         state,
  516 |       })

  at waitForSelector (lib/browsers/playwright.ts:513:29)
  at Playwright._chain (lib/browsers/playwright.ts:643:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:624:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:512:17)
  at Playwright.waitForElementByCss (lib/browsers/playwright.ts:405:17)
  at elementByCssInstant (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:60:27)
  at retry (lib/next-test-utils.ts:828:14)
  at Object.<anonymous> (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:48:7)
  at Proxy._chain (lib/browsers/playwright.ts:643:23)
  at Proxy._chain (lib/browsers/playwright.ts:619:17)
  at Proxy.continueChain (lib/browsers/playwright.ts:425:17)
  at text (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:60:68)
  at retry (lib/next-test-utils.ts:828:14)
  at Object.<anonymous> (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:48:7)

● PPR - partial hydration › No static shell, no streaming metadata › should hydrate the shell without waiting for slow suspense boundaries

page.waitForSelector: Timeout 10ms exceeded.
Call log:
  - waiting for locator('#dynamic-fallback') to be visible

  511 |
  512 |     return this.startChain(async () => {
> 513 |       const el = await page.waitForSelector(selector, {
      |                             ^
  514 |         timeout,
  515 |         state,
  516 |       })

  at waitForSelector (lib/browsers/playwright.ts:513:29)
  at Playwright._chain (lib/browsers/playwright.ts:643:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:624:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:512:17)
  at Playwright.waitForElementByCss (lib/browsers/playwright.ts:405:17)
  at elementByCssInstant (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:60:27)
  at retry (lib/next-test-utils.ts:828:14)
  at Object.<anonymous> (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:48:7)
  at Proxy._chain (lib/browsers/playwright.ts:643:23)
  at Proxy._chain (lib/browsers/playwright.ts:619:17)
  at Proxy.continueChain (lib/browsers/playwright.ts:425:17)
  at text (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:60:68)
  at retry (lib/next-test-utils.ts:828:14)
  at Object.<anonymous> (e2e/app-dir/ppr-partial-hydration/ppr-partial-hydration.test.ts:48:7)

pnpm test-start test/e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts

  • segment cache (search params) > handles rewrites to the same page but with no search params (DD)
Expand output

● segment cache (search params) › handles rewrites to the same page but with no search params

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   // FIXME: search params seem to be dropped from the resume render when deployed
  241 |   if (!isNextDeploy) {
> 242 |     it('handles rewrites to the same page but with no search params', async () => {
      |     ^
  243 |       let act: ReturnType<typeof createRouterAct>
  244 |       const browser = await next.browser('/search-params-with-greeting', {
  245 |         beforePageLoad(page) {

  at it (e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts:242:5)
  at Object.describe (e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts:5:1)

vercel[bot]
vercel bot reviewed Sep 30, 2025
View reviewed changes
packages/next/src/bin/next.ts
Comment on lines +136 to +137
.option('--turbo', 'Starts development mode using Turbopack.')
.option('--turbopack', 'Starts development mode using Turbopack.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.option('--turbo', 'Starts development mode using Turbopack.')
.option('--turbopack', 'Starts development mode using Turbopack.')
.option('--turbo', 'Builds using Turbopack.')
.option('--turbopack', 'Builds using Turbopack.')

The --turbo and --turbopack flags in the next build command have incorrect help text that says "Starts development mode using Turbopack" instead of describing their build functionality.

View Details

Analysis

Incorrect help text for --turbo/--turbopack flags in next build command

What fails: In packages/next/src/bin/next.ts lines 136-137, the --turbo and --turbopack options for the build command display help text "Starts development mode using Turbopack." instead of describing their build functionality.

How to reproduce:

next build --help

Result: The help text shows "Starts development mode using Turbopack." for both --turbo and --turbopack flags under the build command, which is misleading since these flags enable Turbopack for building, not development mode.

Expected: The help text should describe building functionality (e.g., "Builds using Turbopack.") to match the actual behavior, as evidenced by:

  • The build command implementation in packages/next/src/cli/next-build.ts (line 84) uses these flags to enable Turbopack for builds
  • Real-world usage in bench/module-cost/package.json showing "build-turbopack": "next build --turbo"
  • The dev command correctly uses this same text (lines 174-175) since it actually starts development mode

@ijjk ijjk merged commit 3dcb889 into canary Sep 30, 2025
157 of 164 checks passed
@ijjk ijjk deleted the revert-84351-revert-84348-revert/pr-84216 branch September 30, 2025 22:36
@lukesandberg lukesandberg mentioned this pull request Sep 30, 2025
Merged
lukesandberg added a commit that referenced this pull request Oct 2, 2025
@lukesandberg
Revert "Revert "Revert "Revert "Add a --webpack flag and default --tu…
9ba29b4 
…rbopack to true (#84216)"""" (#84394)

Reverts #84389

Attempt number 3, #84374 fixed propagation of bundler environment variables to vercel cli operations, to ensure the test configuration is respected. 

[Deployment Tests Run 1](https://github.com/vercel/next.js/actions/runs/18146684793/job/51649631635).  A fair number of failures.

[Deployment Tests Run 2](https://github.com/vercel/next.js/actions/runs/18154875270). After #84395.  These still have a set of failures, but i confirmed that the deployment builds are running `webpack`.  

The tests that are failing are related to 'prefetches' (test/e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts and test/e2e/app-dir/segment-cache/prefetch-layout-sharing/prefetch-layout-sharing.test.ts) and generally the error is a timeout.  Recent deployment runs for canary releases are also failing, but on different tests.


Trying again after #[84419](#84419).  [Deployment Tests Run 3](https://github.com/vercel/next.js/actions/runs/18173375427).  Failures appeared flaky, rerunning failures...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@lukesandberg lukesandberg lukesandberg approved these changes

@ztanner ztanner Awaiting requested review from ztanner

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijjk @lukesandberg