-
Notifications
You must be signed in to change notification settings - Fork 29.7k
fix: throw error during build when invalid export for Proxy #84886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw error during build when invalid export for Proxy #84886
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a796ac4 to
18a17aa
Compare
Failing test suitesCommit: 4b4d8ad | About building and testing Next.js
Expand output● next/dynamic with assetPrefix › production mode › should load a Pages Router page correctly ● next/dynamic with assetPrefix › production mode › should load a App Router page correctly
Expand output● app dir client cache with parallel routes › prefetch={true} › should prefetch the full page
Expand output● fallback-shells › without IO › should start and not postpone the response
Expand output● layout sharing in non-static prefetches › navigations should omit layouts that were already prefetched with a full prefetch
Expand output● app-dir action handling › fetch actions › should handle redirects to routes that provide an invalid RSC response
Expand output● app dir - navigation › middleware redirect › should change browser location when router.refresh() gets a redirect response |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| buildDuration | 39.4s | 36.6s | N/A |
| buildDurationCached | 34.1s | 28.7s | N/A |
| nodeModulesSize | 451 MB | 451 MB | |
| nextStartRea..uration (ms) | 814ms | 838ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| 1916.HASH.js gzip | 169 B | 169 B | ✓ |
| 4498-HASH.js gzip | 56.6 kB | 56.4 kB | N/A |
| 9225-HASH.js gzip | 5.32 kB | 5.32 kB | N/A |
| c57d0559-HASH.js gzip | 62.1 kB | 62.1 kB | N/A |
| framework-HASH.js gzip | 59.8 kB | 59.8 kB | ✓ |
| main-app-HASH.js gzip | 257 B | 257 B | ✓ |
| main-HASH.js gzip | 39.5 kB | 39.5 kB | N/A |
| webpack-HASH.js gzip | 1.69 kB | 1.69 kB | N/A |
| Overall change | 60.2 kB | 60.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 182 B | 182 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| dynamic-HASH.js gzip | 1.8 kB | 1.8 kB | N/A |
| edge-ssr-HASH.js gzip | 256 B | 255 B | N/A |
| head-HASH.js gzip | 350 B | 352 B | N/A |
| hooks-HASH.js gzip | 384 B | 381 B | N/A |
| image-HASH.js gzip | 4.79 kB | 4.79 kB | N/A |
| index-HASH.js gzip | 259 B | 260 B | N/A |
| link-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
| routerDirect..HASH.js gzip | 318 B | 317 B | N/A |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 315 B | 315 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 1.52 kB | 1.52 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 716 B | 719 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| index.html gzip | 523 B | 522 B | N/A |
| link.html gzip | 537 B | 537 B | ✓ |
| withRouter.html gzip | 519 B | 518 B | N/A |
| Overall change | 537 B | 537 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 128 kB | 128 kB | |
| page.js gzip | 259 kB | 260 kB | |
| Overall change | 387 kB | 388 kB |
Middleware size
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 638 B | 644 B | N/A |
| middleware-r..fest.js gzip | 156 B | 157 B | N/A |
| middleware.js gzip | 33.4 kB | 33.2 kB | N/A |
| edge-runtime..pack.js gzip | 846 B | 846 B | ✓ |
| Overall change | 846 B | 846 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 291 kB | 291 kB | ✓ |
| app-page-exp..prod.js gzip | 162 kB | 162 kB | ✓ |
| app-page-tur...dev.js gzip | 291 kB | 291 kB | ✓ |
| app-page-tur..prod.js gzip | 162 kB | 162 kB | ✓ |
| app-page-tur...dev.js gzip | 287 kB | 287 kB | N/A |
| app-page-tur..prod.js gzip | 159 kB | 159 kB | ✓ |
| app-page.run...dev.js gzip | 287 kB | 287 kB | N/A |
| app-page.run..prod.js gzip | 159 kB | 159 kB | ✓ |
| app-route-ex...dev.js gzip | 69.9 kB | 69.9 kB | ✓ |
| app-route-ex..prod.js gzip | 48.8 kB | 48.8 kB | ✓ |
| app-route-tu...dev.js gzip | 69.9 kB | 69.9 kB | ✓ |
| app-route-tu..prod.js gzip | 48.8 kB | 48.8 kB | ✓ |
| app-route-tu...dev.js gzip | 69.5 kB | 69.5 kB | ✓ |
| app-route-tu..prod.js gzip | 48.6 kB | 48.6 kB | ✓ |
| app-route.ru...dev.js gzip | 69.5 kB | 69.5 kB | ✓ |
| app-route.ru..prod.js gzip | 48.5 kB | 48.5 kB | ✓ |
| dist_client_...dev.js gzip | 326 B | 326 B | ✓ |
| dist_client_...dev.js gzip | 328 B | 328 B | ✓ |
| dist_client_...dev.js gzip | 320 B | 320 B | ✓ |
| dist_client_...dev.js gzip | 318 B | 318 B | ✓ |
| pages-api-tu...dev.js gzip | 42 kB | 42 kB | N/A |
| pages-api-tu..prod.js gzip | 32.1 kB | 32.1 kB | ✓ |
| pages-api.ru...dev.js gzip | 42 kB | 42 kB | ✓ |
| pages-api.ru..prod.js gzip | 32 kB | 32 kB | ✓ |
| pages-turbo....dev.js gzip | 51.8 kB | 51.8 kB | N/A |
| pages-turbo...prod.js gzip | 39.3 kB | 39.3 kB | ✓ |
| pages.runtim...dev.js gzip | 51.8 kB | 51.8 kB | ✓ |
| pages.runtim..prod.js gzip | 39.2 kB | 39.2 kB | ✓ |
| server.runti..prod.js gzip | 78.3 kB | 78.3 kB | ✓ |
| Overall change | 2.01 MB | 2.01 MB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js jiwon/10-15-fix_throw_error_during_build_when_invalid_export_for_proxy | Change | |
|---|---|---|---|
| 0.pack gzip | 3.14 MB | 3.14 MB | |
| index.pack gzip | 93.7 kB | 93.4 kB | N/A |
| Overall change | 3.14 MB | 3.14 MB |
Diff details
Diff for page.js
Diff too large to display
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for css-HASH.js
@@ -1,7 +1,31 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[9813],
{
- /***/ 3593: /***/ (
+ /***/ 5832: /***/ (module) => {
+ // extracted by mini-css-extract-plugin
+ module.exports = { helloWorld: "css_helloWorld__aUdUq" };
+
+ /***/
+ },
+
+ /***/ 6471: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/css",
+ function () {
+ return __webpack_require__(7839);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 7839: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -15,7 +39,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var _css_module_css__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(7634);
+ __webpack_require__(5832);
/* harmony import */ var _css_module_css__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
_css_module_css__WEBPACK_IMPORTED_MODULE_1__
@@ -34,37 +58,13 @@
/***/
},
-
- /***/ 4569: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/css",
- function () {
- return __webpack_require__(3593);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 7634: /***/ (module) => {
- // extracted by mini-css-extract-plugin
- module.exports = { helloWorld: "css_helloWorld__aUdUq" };
-
- /***/
- },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(4569)
+ __webpack_exec__(6471)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for dynamic-HASH.js
@@ -1,24 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[2291],
{
- /***/ 1033: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/dynamic",
- function () {
- return __webpack_require__(2283);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 2283: /***/ (
+ /***/ 133: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -33,7 +16,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_dynamic__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(4939);
+ __webpack_require__(7514);
/* harmony import */ var next_dynamic__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_dynamic__WEBPACK_IMPORTED_MODULE_1__
@@ -42,12 +25,12 @@
const DynamicHello = next_dynamic__WEBPACK_IMPORTED_MODULE_1___default()(
() =>
__webpack_require__
- .e(/* import() */ 1916)
- .then(__webpack_require__.bind(__webpack_require__, 1916))
+ .e(/* import() */ 3862)
+ .then(__webpack_require__.bind(__webpack_require__, 3862))
.then((mod) => mod.Hello),
{
loadableGenerated: {
- webpack: () => [/*require.resolve*/ 1916],
+ webpack: () => [/*require.resolve*/ 3862],
},
}
);
@@ -74,17 +57,24 @@
/***/
},
- /***/ 4939: /***/ (
- module,
+ /***/ 431: /***/ (
+ __unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(5121);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/dynamic",
+ function () {
+ return __webpack_require__(133);
+ },
+ ]);
+ if (false) {
+ }
/***/
},
- /***/ 5121: /***/ (module, exports, __webpack_require__) => {
+ /***/ 1709: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -117,7 +107,7 @@
__webpack_require__(2223)
);
const _loadablesharedruntime = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(7622)
+ __webpack_require__(2522)
);
const isServerSide = "object" === "undefined";
// Normalize loader to return the module as form { default: Component } for `React.lazy`.
@@ -217,7 +207,7 @@
/***/
},
- /***/ 5160: /***/ (
+ /***/ 2463: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -244,7 +234,7 @@
/***/
},
- /***/ 7622: /***/ (
+ /***/ 2522: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -286,7 +276,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE
const _react = /*#__PURE__*/ _interop_require_default._(
__webpack_require__(2223)
);
- const _loadablecontextsharedruntime = __webpack_require__(5160);
+ const _loadablecontextsharedruntime = __webpack_require__(2463);
function resolve(obj) {
return obj && obj.default ? obj.default : obj;
}
@@ -518,13 +508,23 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE
/***/
},
+
+ /***/ 7514: /***/ (
+ module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ module.exports = __webpack_require__(1709);
+
+ /***/
+ },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(1033)
+ __webpack_exec__(431)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for hooks-HASH.js
@@ -1,24 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[9804],
{
- /***/ 1679: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/hooks",
- function () {
- return __webpack_require__(9198);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 9198: /***/ (
+ /***/ 2592: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -76,13 +59,30 @@
/***/
},
+
+ /***/ 3925: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ return __webpack_require__(2592);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(1679)
+ __webpack_exec__(3925)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for image-HASH.js
Diff too large to display
Diff for index-HASH.js
@@ -1,7 +1,24 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[3332],
{
- /***/ 3454: /***/ (
+ /***/ 8431: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ return __webpack_require__(8972);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 8972: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -19,30 +36,13 @@
/***/
},
-
- /***/ 9241: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/",
- function () {
- return __webpack_require__(3454);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(9241)
+ __webpack_exec__(8431)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for link-HASH.js
@@ -1,26 +1,24 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[4672],
{
- /***/ 1970: /***/ (__unused_webpack_module, exports) => {
- "use strict";
-
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "errorOnce", {
- enumerable: true,
- get: function () {
- return errorOnce;
+ /***/ 2025: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ return __webpack_require__(3072);
},
- });
- let errorOnce = (_) => {};
+ ]);
if (false) {
- } //# sourceMappingURL=error-once.js.map
+ }
/***/
},
- /***/ 3262: /***/ (module, exports, __webpack_require__) => {
+ /***/ 3066: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -47,17 +45,17 @@
const _react = /*#__PURE__*/ _interop_require_wildcard._(
__webpack_require__(2223)
);
- const _resolvehref = __webpack_require__(7868);
- const _islocalurl = __webpack_require__(9350);
- const _formaturl = __webpack_require__(6319);
- const _utils = __webpack_require__(9889);
- const _addlocale = __webpack_require__(9466);
- const _routercontextsharedruntime = __webpack_require__(5691);
- const _useintersection = __webpack_require__(3981);
- const _getdomainlocale = __webpack_require__(4206);
- const _addbasepath = __webpack_require__(9339);
- const _usemergedref = __webpack_require__(6848);
- const _erroronce = __webpack_require__(1970);
+ const _resolvehref = __webpack_require__(2776);
+ const _islocalurl = __webpack_require__(5770);
+ const _formaturl = __webpack_require__(8531);
+ const _utils = __webpack_require__(3565);
+ const _addlocale = __webpack_require__(8878);
+ const _routercontextsharedruntime = __webpack_require__(5111);
+ const _useintersection = __webpack_require__(6873);
+ const _getdomainlocale = __webpack_require__(4554);
+ const _addbasepath = __webpack_require__(9567);
+ const _usemergedref = __webpack_require__(4308);
+ const _erroronce = __webpack_require__(8910);
const prefetched = new Set();
function prefetch(router, href, as, options) {
if (false) {
@@ -436,7 +434,167 @@
/***/
},
- /***/ 3981: /***/ (module, exports, __webpack_require__) => {
+ /***/ 3072: /***/ (
+ __unused_webpack_module,
+ __webpack_exports__,
+ __webpack_require__
+ ) => {
+ "use strict";
+ __webpack_require__.r(__webpack_exports__);
+ /* harmony export */ __webpack_require__.d(__webpack_exports__, {
+ /* harmony export */ __N_SSP: () => /* binding */ __N_SSP,
+ /* harmony export */ default: () => __WEBPACK_DEFAULT_EXPORT__,
+ /* harmony export */
+ });
+ /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
+ __webpack_require__(1503);
+ /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
+ __webpack_require__(6929);
+ /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
+ /*#__PURE__*/ __webpack_require__.n(
+ next_link__WEBPACK_IMPORTED_MODULE_1__
+ );
+
+ function aLink(props) {
+ return /*#__PURE__*/ (0,
+ react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsxs)("div", {
+ children: [
+ /*#__PURE__*/ (0,
+ react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)("h3", {
+ children: "A Link page!",
+ }),
+ /*#__PURE__*/ (0,
+ react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)(
+ next_link__WEBPACK_IMPORTED_MODULE_1___default(),
+ {
+ href: "/",
+ children: "Go to /",
+ }
+ ),
+ ],
+ });
+ }
+ var __N_SSP = true;
+ /* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = aLink;
+
+ /***/
+ },
+
+ /***/ 4308: /***/ (module, exports, __webpack_require__) => {
+ "use strict";
+
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "useMergedRef", {
+ enumerable: true,
+ get: function () {
+ return useMergedRef;
+ },
+ });
+ const _react = __webpack_require__(2223);
+ function useMergedRef(refA, refB) {
+ const cleanupA = (0, _react.useRef)(null);
+ const cleanupB = (0, _react.useRef)(null);
+ // NOTE: In theory, we could skip the wrapping if only one of the refs is non-null.
+ // (this happens often if the user doesn't pass a ref to Link/Form/Image)
+ // But this can cause us to leak a cleanup-ref into user code (previously via `<Link legacyBehavior>`),
+ // and the user might pass that ref into ref-merging library that doesn't support cleanup refs
+ // (because it hasn't been updated for React 19)
+ // which can then cause things to blow up, because a cleanup-returning ref gets called with `null`.
+ // So in practice, it's safer to be defensive and always wrap the ref, even on React 19.
+ return (0, _react.useCallback)(
+ (current) => {
+ if (current === null) {
+ const cleanupFnA = cleanupA.current;
+ if (cleanupFnA) {
+ cleanupA.current = null;
+ cleanupFnA();
+ }
+ const cleanupFnB = cleanupB.current;
+ if (cleanupFnB) {
+ cleanupB.current = null;
+ cleanupFnB();
+ }
+ } else {
+ if (refA) {
+ cleanupA.current = applyRef(refA, current);
+ }
+ if (refB) {
+ cleanupB.current = applyRef(refB, current);
+ }
+ }
+ },
+ [refA, refB]
+ );
+ }
+ function applyRef(refA, current) {
+ if (typeof refA === "function") {
+ const cleanup = refA(current);
+ if (typeof cleanup === "function") {
+ return cleanup;
+ } else {
+ return () => refA(null);
+ }
+ } else {
+ refA.current = current;
+ return () => {
+ refA.current = null;
+ };
+ }
+ }
+ if (
+ (typeof exports.default === "function" ||
+ (typeof exports.default === "object" && exports.default !== null)) &&
+ typeof exports.default.__esModule === "undefined"
+ ) {
+ Object.defineProperty(exports.default, "__esModule", {
+ value: true,
+ });
+ Object.assign(exports.default, exports);
+ module.exports = exports.default;
+ } //# sourceMappingURL=use-merged-ref.js.map
+
+ /***/
+ },
+
+ /***/ 4554: /***/ (module, exports, __webpack_require__) => {
+ "use strict";
+
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "getDomainLocale", {
+ enumerable: true,
+ get: function () {
+ return getDomainLocale;
+ },
+ });
+ const _normalizetrailingslash = __webpack_require__(7740);
+ const basePath =
+ /* unused pure expression or super */ null && (false || "");
+ function getDomainLocale(path, locale, locales, domainLocales) {
+ if (false) {
+ } else {
+ return false;
+ }
+ }
+ if (
+ (typeof exports.default === "function" ||
+ (typeof exports.default === "object" && exports.default !== null)) &&
+ typeof exports.default.__esModule === "undefined"
+ ) {
+ Object.defineProperty(exports.default, "__esModule", {
+ value: true,
+ });
+ Object.assign(exports.default, exports);
+ module.exports = exports.default;
+ } //# sourceMappingURL=get-domain-locale.js.map
+
+ /***/
+ },
+
+ /***/ 6873: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -449,7 +607,7 @@
},
});
const _react = __webpack_require__(2223);
- const _requestidlecallback = __webpack_require__(1472);
+ const _requestidlecallback = __webpack_require__(6892);
const hasIntersectionObserver =
typeof IntersectionObserver === "function";
const observers = new Map();
@@ -561,189 +719,31 @@
/***/
},
- /***/ 4206: /***/ (module, exports, __webpack_require__) => {
- "use strict";
-
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "getDomainLocale", {
- enumerable: true,
- get: function () {
- return getDomainLocale;
- },
- });
- const _normalizetrailingslash = __webpack_require__(6704);
- const basePath =
- /* unused pure expression or super */ null && (false || "");
- function getDomainLocale(path, locale, locales, domainLocales) {
- if (false) {
- } else {
- return false;
- }
- }
- if (
- (typeof exports.default === "function" ||
- (typeof exports.default === "object" && exports.default !== null)) &&
- typeof exports.default.__esModule === "undefined"
- ) {
- Object.defineProperty(exports.default, "__esModule", {
- value: true,
- });
- Object.assign(exports.default, exports);
- module.exports = exports.default;
- } //# sourceMappingURL=get-domain-locale.js.map
-
- /***/
- },
-
- /***/ 6691: /***/ (
+ /***/ 6929: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(3262);
+ module.exports = __webpack_require__(3066);
/***/
},
- /***/ 6771: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/link",
- function () {
- return __webpack_require__(8178);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 6848: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8910: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true,
});
- Object.defineProperty(exports, "useMergedRef", {
+ Object.defineProperty(exports, "errorOnce", {
enumerable: true,
get: function () {
- return useMergedRef;
+ return errorOnce;
},
});
- const _react = __webpack_require__(2223);
- function useMergedRef(refA, refB) {
- const cleanupA = (0, _react.useRef)(null);
- const cleanupB = (0, _react.useRef)(null);
- // NOTE: In theory, we could skip the wrapping if only one of the refs is non-null.
- // (this happens often if the user doesn't pass a ref to Link/Form/Image)
- // But this can cause us to leak a cleanup-ref into user code (previously via `<Link legacyBehavior>`),
- // and the user might pass that ref into ref-merging library that doesn't support cleanup refs
- // (because it hasn't been updated for React 19)
- // which can then cause things to blow up, because a cleanup-returning ref gets called with `null`.
- // So in practice, it's safer to be defensive and always wrap the ref, even on React 19.
- return (0, _react.useCallback)(
- (current) => {
- if (current === null) {
- const cleanupFnA = cleanupA.current;
- if (cleanupFnA) {
- cleanupA.current = null;
- cleanupFnA();
- }
- const cleanupFnB = cleanupB.current;
- if (cleanupFnB) {
- cleanupB.current = null;
- cleanupFnB();
- }
- } else {
- if (refA) {
- cleanupA.current = applyRef(refA, current);
- }
- if (refB) {
- cleanupB.current = applyRef(refB, current);
- }
- }
- },
- [refA, refB]
- );
- }
- function applyRef(refA, current) {
- if (typeof refA === "function") {
- const cleanup = refA(current);
- if (typeof cleanup === "function") {
- return cleanup;
- } else {
- return () => refA(null);
- }
- } else {
- refA.current = current;
- return () => {
- refA.current = null;
- };
- }
- }
- if (
- (typeof exports.default === "function" ||
- (typeof exports.default === "object" && exports.default !== null)) &&
- typeof exports.default.__esModule === "undefined"
- ) {
- Object.defineProperty(exports.default, "__esModule", {
- value: true,
- });
- Object.assign(exports.default, exports);
- module.exports = exports.default;
- } //# sourceMappingURL=use-merged-ref.js.map
-
- /***/
- },
-
- /***/ 8178: /***/ (
- __unused_webpack_module,
- __webpack_exports__,
- __webpack_require__
- ) => {
- "use strict";
- __webpack_require__.r(__webpack_exports__);
- /* harmony export */ __webpack_require__.d(__webpack_exports__, {
- /* harmony export */ __N_SSP: () => /* binding */ __N_SSP,
- /* harmony export */ default: () => __WEBPACK_DEFAULT_EXPORT__,
- /* harmony export */
- });
- /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
- __webpack_require__(1503);
- /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(6691);
- /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
- /*#__PURE__*/ __webpack_require__.n(
- next_link__WEBPACK_IMPORTED_MODULE_1__
- );
-
- function aLink(props) {
- return /*#__PURE__*/ (0,
- react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsxs)("div", {
- children: [
- /*#__PURE__*/ (0,
- react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)("h3", {
- children: "A Link page!",
- }),
- /*#__PURE__*/ (0,
- react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)(
- next_link__WEBPACK_IMPORTED_MODULE_1___default(),
- {
- href: "/",
- children: "Go to /",
- }
- ),
- ],
- });
- }
- var __N_SSP = true;
- /* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = aLink;
+ let errorOnce = (_) => {};
+ if (false) {
+ } //# sourceMappingURL=error-once.js.map
/***/
},
@@ -753,7 +753,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(6771)
+ __webpack_exec__(2025)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for routerDirect-HASH.js
@@ -1,7 +1,24 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[188],
{
- /***/ 286: /***/ (
+ /***/ 417: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ return __webpack_require__(504);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 504: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -16,7 +33,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(7798);
+ __webpack_require__(1840);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_router__WEBPACK_IMPORTED_MODULE_1__
@@ -36,29 +53,12 @@
/***/
},
- /***/ 4283: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/routerDirect",
- function () {
- return __webpack_require__(286);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 7798: /***/ (
+ /***/ 1840: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(9587);
+ module.exports = __webpack_require__(1903);
/***/
},
@@ -68,7 +68,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(4283)
+ __webpack_exec__(417)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for script-HASH.js
@@ -1,7 +1,34 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[1209],
{
- /***/ 661: /***/ (
+ /***/ 2398: /***/ (
+ module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ module.exports = __webpack_require__(2397);
+
+ /***/
+ },
+
+ /***/ 4305: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/script",
+ function () {
+ return __webpack_require__(8543);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 8543: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -16,7 +43,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_script__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(5964);
+ __webpack_require__(2398);
/* harmony import */ var next_script__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_script__WEBPACK_IMPORTED_MODULE_1__
@@ -48,40 +75,13 @@
/***/
},
-
- /***/ 5964: /***/ (
- module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- module.exports = __webpack_require__(297);
-
- /***/
- },
-
- /***/ 8803: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/script",
- function () {
- return __webpack_require__(661);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(8803)
+ __webpack_exec__(4305)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for withRouter-HASH.js
@@ -1,24 +1,17 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[3263],
{
- /***/ 3163: /***/ (
- __unused_webpack_module,
+ /***/ 1840: /***/ (
+ module,
__unused_webpack_exports,
__webpack_require__
) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/withRouter",
- function () {
- return __webpack_require__(3295);
- },
- ]);
- if (false) {
- }
+ module.exports = __webpack_require__(1903);
/***/
},
- /***/ 3295: /***/ (
+ /***/ 2037: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -33,7 +26,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(7798);
+ __webpack_require__(1840);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_router__WEBPACK_IMPORTED_MODULE_1__
@@ -52,12 +45,19 @@
/***/
},
- /***/ 7798: /***/ (
- module,
+ /***/ 4041: /***/ (
+ __unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(9587);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ return __webpack_require__(2037);
+ },
+ ]);
+ if (false) {
+ }
/***/
},
@@ -67,7 +67,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(3163)
+ __webpack_exec__(4041)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 4498-HASH.js
failed to diffDiff for 9225-HASH.js
@@ -1,32 +1,81 @@
"use strict";
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
- [9225],
+ [8439],
{
- /***/ 2: /***/ (__unused_webpack_module, exports, __webpack_require__) => {
+ /***/ 405: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
- Object.defineProperty(exports, "ImageConfigContext", {
+ Object.defineProperty(exports, "default", {
enumerable: true,
get: function () {
- return ImageConfigContext;
+ return SideEffect;
},
});
- const _interop_require_default = __webpack_require__(9010);
- const _react = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8879)
- );
- const _imageconfig = __webpack_require__(1686);
- const ImageConfigContext = _react.default.createContext(
- _imageconfig.imageConfigDefault
- );
- if (false) {
- } //# sourceMappingURL=image-config-context.shared-runtime.js.map
+ const _react = __webpack_require__(1774);
+ const isServer = "object" === "undefined";
+ const useClientOnlyLayoutEffect = isServer
+ ? () => {}
+ : _react.useLayoutEffect;
+ const useClientOnlyEffect = isServer ? () => {} : _react.useEffect;
+ function SideEffect(props) {
+ const { headManager, reduceComponentsToState } = props;
+ function emitChange() {
+ if (headManager && headManager.mountedInstances) {
+ const headElements = _react.Children.toArray(
+ Array.from(headManager.mountedInstances).filter(Boolean)
+ );
+ headManager.updateHead(reduceComponentsToState(headElements));
+ }
+ }
+ if (isServer) {
+ headManager?.mountedInstances?.add(props.children);
+ emitChange();
+ }
+ useClientOnlyLayoutEffect(() => {
+ headManager?.mountedInstances?.add(props.children);
+ return () => {
+ headManager?.mountedInstances?.delete(props.children);
+ };
+ });
+ // We need to call `updateHead` method whenever the `SideEffect` is trigger in all
+ // life-cycles: mount, update, unmount. However, if there are multiple `SideEffect`s
+ // being rendered, we only trigger the method from the last one.
+ // This is ensured by keeping the last unflushed `updateHead` in the `_pendingUpdate`
+ // singleton in the layout effect pass, and actually trigger it in the effect pass.
+ useClientOnlyLayoutEffect(() => {
+ if (headManager) {
+ headManager._pendingUpdate = emitChange;
+ }
+ return () => {
+ if (headManager) {
+ headManager._pendingUpdate = emitChange;
+ }
+ };
+ });
+ useClientOnlyEffect(() => {
+ if (headManager && headManager._pendingUpdate) {
+ headManager._pendingUpdate();
+ headManager._pendingUpdate = null;
+ }
+ return () => {
+ if (headManager && headManager._pendingUpdate) {
+ headManager._pendingUpdate();
+ headManager._pendingUpdate = null;
+ }
+ };
+ });
+ return null;
+ } //# sourceMappingURL=side-effect.js.map
/***/
},
- /***/ 1169: /***/ (
+ /***/ 1155: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -40,9 +89,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(4352);
- const _imageblursvg = __webpack_require__(2314);
- const _imageconfig = __webpack_require__(1686);
+ const _warnonce = __webpack_require__(5358);
+ const _imageblursvg = __webpack_require__(6924);
+ const _imageconfig = __webpack_require__(9712);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -473,245 +522,60 @@
/***/
},
- /***/ 1666: /***/ (module, exports, __webpack_require__) => {
- /* __next_internal_client_entry_do_not_use__ cjs */
+ /***/ 1417: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
- 0 && 0;
- function _export(target, all) {
- for (var name in all)
- Object.defineProperty(target, name, {
- enumerable: true,
- get: all[name],
- });
- }
- _export(exports, {
- default: function () {
+ Object.defineProperty(exports, "default", {
+ enumerable: true,
+ get: function () {
return _default;
},
- defaultHead: function () {
- return defaultHead;
- },
});
- const _interop_require_default = __webpack_require__(9010);
- const _interop_require_wildcard = __webpack_require__(2275);
- const _jsxruntime = __webpack_require__(1024);
- const _react = /*#__PURE__*/ _interop_require_wildcard._(
- __webpack_require__(8879)
- );
- const _sideeffect = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(2543)
- );
- const _headmanagercontextsharedruntime = __webpack_require__(5428);
- const _warnonce = __webpack_require__(4352);
- function defaultHead() {
- const head = [
- /*#__PURE__*/ (0, _jsxruntime.jsx)(
- "meta",
- {
- charSet: "utf-8",
- },
- "charset"
- ),
- /*#__PURE__*/ (0, _jsxruntime.jsx)(
- "meta",
+ const _findclosestquality = __webpack_require__(1639);
+ function defaultLoader({ config, src, width, quality }) {
+ if (
+ src.startsWith("/") &&
+ src.includes("?") &&
+ config.localPatterns?.length === 1 &&
+ config.localPatterns[0].pathname === "**" &&
+ config.localPatterns[0].search === ""
+ ) {
+ throw Object.defineProperty(
+ new Error(
+ `Image with src "${src}" is using a query string which is not configured in images.localPatterns.` +
+ `\nRead more: https://nextjs.org/docs/messages/next-image-unconfigured-localpatterns`
+ ),
+ "__NEXT_ERROR_CODE",
{
- name: "viewport",
- content: "width=device-width",
- },
- "viewport"
- ),
- ];
- return head;
- }
- function onlyReactElement(list, child) {
- // React children can be "string" or "number" in this case we ignore them for backwards compat
- if (typeof child === "string" || typeof child === "number") {
- return list;
- }
- // Adds support for React.Fragment
- if (child.type === _react.default.Fragment) {
- return list.concat(
- _react.default.Children.toArray(child.props.children).reduce(
- (fragmentList, fragmentChild) => {
- if (
- typeof fragmentChild === "string" ||
- typeof fragmentChild === "number"
- ) {
- return fragmentList;
- }
- return fragmentList.concat(fragmentChild);
- },
- []
- )
+ value: "E871",
+ enumerable: false,
+ configurable: true,
+ }
);
}
- return list.concat(child);
- }
- const METATYPES = ["name", "httpEquiv", "charSet", "itemProp"];
- /*
- returns a function for filtering head child elements
- which shouldn't be duplicated, like <title/>
- Also adds support for deduplicated `key` properties
-*/ function unique() {
- const keys = new Set();
- const tags = new Set();
- const metaTypes = new Set();
- const metaCategories = {};
- return (h) => {
- let isUnique = true;
- let hasKey = false;
- if (h.key && typeof h.key !== "number" && h.key.indexOf("$") > 0) {
- hasKey = true;
- const key = h.key.slice(h.key.indexOf("$") + 1);
- if (keys.has(key)) {
- isUnique = false;
- } else {
- keys.add(key);
- }
- }
- // eslint-disable-next-line default-case
- switch (h.type) {
- case "title":
- case "base":
- if (tags.has(h.type)) {
- isUnique = false;
- } else {
- tags.add(h.type);
- }
- break;
- case "meta":
- for (let i = 0, len = METATYPES.length; i < len; i++) {
- const metatype = METATYPES[i];
- if (!h.props.hasOwnProperty(metatype)) continue;
- if (metatype === "charSet") {
- if (metaTypes.has(metatype)) {
- isUnique = false;
- } else {
- metaTypes.add(metatype);
- }
- } else {
- const category = h.props[metatype];
- const categories = metaCategories[metatype] || new Set();
- if (
- (metatype !== "name" || !hasKey) &&
- categories.has(category)
- ) {
- isUnique = false;
- } else {
- categories.add(category);
- metaCategories[metatype] = categories;
- }
- }
- }
- break;
- }
- return isUnique;
- };
- }
- /**
- *
- * @param headChildrenElements List of children of <Head>
- */ function reduceComponents(headChildrenElements) {
- return headChildrenElements
- .reduce(onlyReactElement, [])
- .reverse()
- .concat(defaultHead().reverse())
- .filter(unique())
- .reverse()
- .map((c, i) => {
- const key = c.key || i;
- if (false) {
- }
- return /*#__PURE__*/ _react.default.cloneElement(c, {
- key,
- });
- });
- }
- /**
- * This component injects elements to `<head>` of your page.
- * To avoid duplicated `tags` in `<head>` you can use the `key` property, which will make sure every tag is only rendered once.
- */ function Head({ children }) {
- const headManager = (0, _react.useContext)(
- _headmanagercontextsharedruntime.HeadManagerContext
- );
- return /*#__PURE__*/ (0, _jsxruntime.jsx)(_sideeffect.default, {
- reduceComponentsToState: reduceComponents,
- headManager: headManager,
- children: children,
- });
- }
- const _default = Head;
- if (
- (typeof exports.default === "function" ||
- (typeof exports.default === "object" && exports.default !== null)) &&
- typeof exports.default.__esModule === "undefined"
- ) {
- Object.defineProperty(exports.default, "__esModule", {
- value: true,
- });
- Object.assign(exports.default, exports);
- module.exports = exports.default;
- } //# sourceMappingURL=head.js.map
-
- /***/
- },
-
- /***/ 1686: /***/ (__unused_webpack_module, exports) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- 0 && 0;
- function _export(target, all) {
- for (var name in all)
- Object.defineProperty(target, name, {
- enumerable: true,
- get: all[name],
- });
+ if (false) {
+ }
+ const q = (0, _findclosestquality.findClosestQuality)(quality, config);
+ return `${config.path}?url=${encodeURIComponent(
+ src
+ )}&w=${width}&q=${q}${
+ src.startsWith("/_next/static/media/") && false ? 0 : ""
+ }`;
}
- _export(exports, {
- VALID_LOADERS: function () {
- return VALID_LOADERS;
- },
- imageConfigDefault: function () {
- return imageConfigDefault;
- },
- });
- const VALID_LOADERS = [
- "default",
- "imgix",
- "cloudinary",
- "akamai",
- "custom",
- ];
- const imageConfigDefault = {
- deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
- imageSizes: [32, 48, 64, 96, 128, 256, 384],
- path: "/_next/image",
- loader: "default",
- loaderFile: "",
- /**
- * @deprecated Use `remotePatterns` instead to protect your application from malicious users.
- */ domains: [],
- disableStaticImages: false,
- minimumCacheTTL: 14400,
- formats: ["image/webp"],
- maximumRedirects: 3,
- dangerouslyAllowLocalIP: false,
- dangerouslyAllowSVG: false,
- contentSecurityPolicy: `script-src 'none'; frame-src 'none'; sandbox;`,
- contentDispositionType: "attachment",
- localPatterns: undefined,
- remotePatterns: [],
- qualities: [75],
- unoptimized: false,
- }; //# sourceMappingURL=image-config.js.map
+ // We use this to determine if the import is the default loader
+ // or a custom loader defined by the user in next.config.js
+ defaultLoader.__next_img_default = true;
+ const _default = defaultLoader; //# sourceMappingURL=image-loader.js.map
/***/
},
- /***/ 2285: /***/ (__unused_webpack_module, exports) => {
+ /***/ 1639: /***/ (__unused_webpack_module, exports) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
@@ -735,7 +599,35 @@
/***/
},
- /***/ 2314: /***/ (__unused_webpack_module, exports) => {
+ /***/ 2896: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "ImageConfigContext", {
+ enumerable: true,
+ get: function () {
+ return ImageConfigContext;
+ },
+ });
+ const _interop_require_default = __webpack_require__(2570);
+ const _react = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(1774)
+ );
+ const _imageconfig = __webpack_require__(9712);
+ const ImageConfigContext = _react.default.createContext(
+ _imageconfig.imageConfigDefault
+ );
+ if (false) {
+ } //# sourceMappingURL=image-config-context.shared-runtime.js.map
+
+ /***/
+ },
+
+ /***/ 6924: /***/ (__unused_webpack_module, exports) => {
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
*/
@@ -774,133 +666,7 @@
/***/
},
- /***/ 2543: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "default", {
- enumerable: true,
- get: function () {
- return SideEffect;
- },
- });
- const _react = __webpack_require__(8879);
- const isServer = "object" === "undefined";
- const useClientOnlyLayoutEffect = isServer
- ? () => {}
- : _react.useLayoutEffect;
- const useClientOnlyEffect = isServer ? () => {} : _react.useEffect;
- function SideEffect(props) {
- const { headManager, reduceComponentsToState } = props;
- function emitChange() {
- if (headManager && headManager.mountedInstances) {
- const headElements = _react.Children.toArray(
- Array.from(headManager.mountedInstances).filter(Boolean)
- );
- headManager.updateHead(reduceComponentsToState(headElements));
- }
- }
- if (isServer) {
- headManager?.mountedInstances?.add(props.children);
- emitChange();
- }
- useClientOnlyLayoutEffect(() => {
- headManager?.mountedInstances?.add(props.children);
- return () => {
- headManager?.mountedInstances?.delete(props.children);
- };
- });
- // We need to call `updateHead` method whenever the `SideEffect` is trigger in all
- // life-cycles: mount, update, unmount. However, if there are multiple `SideEffect`s
- // being rendered, we only trigger the method from the last one.
- // This is ensured by keeping the last unflushed `updateHead` in the `_pendingUpdate`
- // singleton in the layout effect pass, and actually trigger it in the effect pass.
- useClientOnlyLayoutEffect(() => {
- if (headManager) {
- headManager._pendingUpdate = emitChange;
- }
- return () => {
- if (headManager) {
- headManager._pendingUpdate = emitChange;
- }
- };
- });
- useClientOnlyEffect(() => {
- if (headManager && headManager._pendingUpdate) {
- headManager._pendingUpdate();
- headManager._pendingUpdate = null;
- }
- return () => {
- if (headManager && headManager._pendingUpdate) {
- headManager._pendingUpdate();
- headManager._pendingUpdate = null;
- }
- };
- });
- return null;
- } //# sourceMappingURL=side-effect.js.map
-
- /***/
- },
-
- /***/ 8035: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "default", {
- enumerable: true,
- get: function () {
- return _default;
- },
- });
- const _findclosestquality = __webpack_require__(2285);
- function defaultLoader({ config, src, width, quality }) {
- if (
- src.startsWith("/") &&
- src.includes("?") &&
- config.localPatterns?.length === 1 &&
- config.localPatterns[0].pathname === "**" &&
- config.localPatterns[0].search === ""
- ) {
- throw Object.defineProperty(
- new Error(
- `Image with src "${src}" is using a query string which is not configured in images.localPatterns.` +
- `\nRead more: https://nextjs.org/docs/messages/next-image-unconfigured-localpatterns`
- ),
- "__NEXT_ERROR_CODE",
- {
- value: "E871",
- enumerable: false,
- configurable: true,
- }
- );
- }
- if (false) {
- }
- const q = (0, _findclosestquality.findClosestQuality)(quality, config);
- return `${config.path}?url=${encodeURIComponent(
- src
- )}&w=${width}&q=${q}${
- src.startsWith("/_next/static/media/") && false ? 0 : ""
- }`;
- }
- // We use this to determine if the import is the default loader
- // or a custom loader defined by the user in next.config.js
- defaultLoader.__next_img_default = true;
- const _default = defaultLoader; //# sourceMappingURL=image-loader.js.map
-
- /***/
- },
-
- /***/ 8848: /***/ (module, exports, __webpack_require__) => {
+ /***/ 7614: /***/ (module, exports, __webpack_require__) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
@@ -910,7 +676,7 @@
return useMergedRef;
},
});
- const _react = __webpack_require__(8879);
+ const _react = __webpack_require__(1774);
function useMergedRef(refA, refB) {
const cleanupA = (0, _react.useRef)(null);
const cleanupB = (0, _react.useRef)(null);
@@ -976,32 +742,7 @@
/***/
},
- /***/ 9059: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "RouterContext", {
- enumerable: true,
- get: function () {
- return RouterContext;
- },
- });
- const _interop_require_default = __webpack_require__(9010);
- const _react = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8879)
- );
- const RouterContext = _react.default.createContext(null);
- if (false) {
- } //# sourceMappingURL=router-context.shared-runtime.js.map
-
- /***/
- },
-
- /***/ 9225: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8439: /***/ (module, exports, __webpack_require__) => {
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
value: true,
@@ -1012,27 +753,27 @@
return Image;
},
});
- const _interop_require_default = __webpack_require__(9010);
- const _interop_require_wildcard = __webpack_require__(2275);
- const _jsxruntime = __webpack_require__(1024);
+ const _interop_require_default = __webpack_require__(2570);
+ const _interop_require_wildcard = __webpack_require__(5643);
+ const _jsxruntime = __webpack_require__(2014);
const _react = /*#__PURE__*/ _interop_require_wildcard._(
- __webpack_require__(8879)
+ __webpack_require__(1774)
);
const _reactdom = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(3869)
+ __webpack_require__(7499)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(1666)
+ __webpack_require__(9452)
);
- const _getimgprops = __webpack_require__(1169);
- const _imageconfig = __webpack_require__(1686);
- const _imageconfigcontextsharedruntime = __webpack_require__(2);
- const _warnonce = __webpack_require__(4352);
- const _routercontextsharedruntime = __webpack_require__(9059);
+ const _getimgprops = __webpack_require__(1155);
+ const _imageconfig = __webpack_require__(9712);
+ const _imageconfigcontextsharedruntime = __webpack_require__(2896);
+ const _warnonce = __webpack_require__(5358);
+ const _routercontextsharedruntime = __webpack_require__(9813);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8035)
+ __webpack_require__(1417)
);
- const _usemergedref = __webpack_require__(8848);
+ const _usemergedref = __webpack_require__(7614);
// This is replaced by webpack define plugin
const configEnv = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -1358,5 +1099,268 @@
/***/
},
+
+ /***/ 9452: /***/ (module, exports, __webpack_require__) => {
+ /* __next_internal_client_entry_do_not_use__ cjs */
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ 0 && 0;
+ function _export(target, all) {
+ for (var name in all)
+ Object.defineProperty(target, name, {
+ enumerable: true,
+ get: all[name],
+ });
+ }
+ _export(exports, {
+ default: function () {
+ return _default;
+ },
+ defaultHead: function () {
+ return defaultHead;
+ },
+ });
+ const _interop_require_default = __webpack_require__(2570);
+ const _interop_require_wildcard = __webpack_require__(5643);
+ const _jsxruntime = __webpack_require__(2014);
+ const _react = /*#__PURE__*/ _interop_require_wildcard._(
+ __webpack_require__(1774)
+ );
+ const _sideeffect = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(405)
+ );
+ const _headmanagercontextsharedruntime = __webpack_require__(5326);
+ const _warnonce = __webpack_require__(5358);
+ function defaultHead() {
+ const head = [
+ /*#__PURE__*/ (0, _jsxruntime.jsx)(
+ "meta",
+ {
+ charSet: "utf-8",
+ },
+ "charset"
+ ),
+ /*#__PURE__*/ (0, _jsxruntime.jsx)(
+ "meta",
+ {
+ name: "viewport",
+ content: "width=device-width",
+ },
+ "viewport"
+ ),
+ ];
+ return head;
+ }
+ function onlyReactElement(list, child) {
+ // React children can be "string" or "number" in this case we ignore them for backwards compat
+ if (typeof child === "string" || typeof child === "number") {
+ return list;
+ }
+ // Adds support for React.Fragment
+ if (child.type === _react.default.Fragment) {
+ return list.concat(
+ _react.default.Children.toArray(child.props.children).reduce(
+ (fragmentList, fragmentChild) => {
+ if (
+ typeof fragmentChild === "string" ||
+ typeof fragmentChild === "number"
+ ) {
+ return fragmentList;
+ }
+ return fragmentList.concat(fragmentChild);
+ },
+ []
+ )
+ );
+ }
+ return list.concat(child);
+ }
+ const METATYPES = ["name", "httpEquiv", "charSet", "itemProp"];
+ /*
+ returns a function for filtering head child elements
+ which shouldn't be duplicated, like <title/>
+ Also adds support for deduplicated `key` properties
+*/ function unique() {
+ const keys = new Set();
+ const tags = new Set();
+ const metaTypes = new Set();
+ const metaCategories = {};
+ return (h) => {
+ let isUnique = true;
+ let hasKey = false;
+ if (h.key && typeof h.key !== "number" && h.key.indexOf("$") > 0) {
+ hasKey = true;
+ const key = h.key.slice(h.key.indexOf("$") + 1);
+ if (keys.has(key)) {
+ isUnique = false;
+ } else {
+ keys.add(key);
+ }
+ }
+ // eslint-disable-next-line default-case
+ switch (h.type) {
+ case "title":
+ case "base":
+ if (tags.has(h.type)) {
+ isUnique = false;
+ } else {
+ tags.add(h.type);
+ }
+ break;
+ case "meta":
+ for (let i = 0, len = METATYPES.length; i < len; i++) {
+ const metatype = METATYPES[i];
+ if (!h.props.hasOwnProperty(metatype)) continue;
+ if (metatype === "charSet") {
+ if (metaTypes.has(metatype)) {
+ isUnique = false;
+ } else {
+ metaTypes.add(metatype);
+ }
+ } else {
+ const category = h.props[metatype];
+ const categories = metaCategories[metatype] || new Set();
+ if (
+ (metatype !== "name" || !hasKey) &&
+ categories.has(category)
+ ) {
+ isUnique = false;
+ } else {
+ categories.add(category);
+ metaCategories[metatype] = categories;
+ }
+ }
+ }
+ break;
+ }
+ return isUnique;
+ };
+ }
+ /**
+ *
+ * @param headChildrenElements List of children of <Head>
+ */ function reduceComponents(headChildrenElements) {
+ return headChildrenElements
+ .reduce(onlyReactElement, [])
+ .reverse()
+ .concat(defaultHead().reverse())
+ .filter(unique())
+ .reverse()
+ .map((c, i) => {
+ const key = c.key || i;
+ if (false) {
+ }
+ return /*#__PURE__*/ _react.default.cloneElement(c, {
+ key,
+ });
+ });
+ }
+ /**
+ * This component injects elements to `<head>` of your page.
+ * To avoid duplicated `tags` in `<head>` you can use the `key` property, which will make sure every tag is only rendered once.
+ */ function Head({ children }) {
+ const headManager = (0, _react.useContext)(
+ _headmanagercontextsharedruntime.HeadManagerContext
+ );
+ return /*#__PURE__*/ (0, _jsxruntime.jsx)(_sideeffect.default, {
+ reduceComponentsToState: reduceComponents,
+ headManager: headManager,
+ children: children,
+ });
+ }
+ const _default = Head;
+ if (
+ (typeof exports.default === "function" ||
+ (typeof exports.default === "object" && exports.default !== null)) &&
+ typeof exports.default.__esModule === "undefined"
+ ) {
+ Object.defineProperty(exports.default, "__esModule", {
+ value: true,
+ });
+ Object.assign(exports.default, exports);
+ module.exports = exports.default;
+ } //# sourceMappingURL=head.js.map
+
+ /***/
+ },
+
+ /***/ 9712: /***/ (__unused_webpack_module, exports) => {
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ 0 && 0;
+ function _export(target, all) {
+ for (var name in all)
+ Object.defineProperty(target, name, {
+ enumerable: true,
+ get: all[name],
+ });
+ }
+ _export(exports, {
+ VALID_LOADERS: function () {
+ return VALID_LOADERS;
+ },
+ imageConfigDefault: function () {
+ return imageConfigDefault;
+ },
+ });
+ const VALID_LOADERS = [
+ "default",
+ "imgix",
+ "cloudinary",
+ "akamai",
+ "custom",
+ ];
+ const imageConfigDefault = {
+ deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
+ imageSizes: [32, 48, 64, 96, 128, 256, 384],
+ path: "/_next/image",
+ loader: "default",
+ loaderFile: "",
+ /**
+ * @deprecated Use `remotePatterns` instead to protect your application from malicious users.
+ */ domains: [],
+ disableStaticImages: false,
+ minimumCacheTTL: 14400,
+ formats: ["image/webp"],
+ maximumRedirects: 3,
+ dangerouslyAllowLocalIP: false,
+ dangerouslyAllowSVG: false,
+ contentSecurityPolicy: `script-src 'none'; frame-src 'none'; sandbox;`,
+ contentDispositionType: "attachment",
+ localPatterns: undefined,
+ remotePatterns: [],
+ qualities: [75],
+ unoptimized: false,
+ }; //# sourceMappingURL=image-config.js.map
+
+ /***/
+ },
+
+ /***/ 9813: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "RouterContext", {
+ enumerable: true,
+ get: function () {
+ return RouterContext;
+ },
+ });
+ const _interop_require_default = __webpack_require__(2570);
+ const _react = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(1774)
+ );
+ const RouterContext = _react.default.createContext(null);
+ if (false) {
+ } //# sourceMappingURL=router-context.shared-runtime.js.map
+
+ /***/
+ },
},
]);Diff for main-HASH.js
Diff too large to display
Diff for pages-api-tu..ntime.dev.js
Diff too large to display
Diff for pages-turbo...ntime.dev.js
Diff too large to display
c132d3e to
638c730
Compare
638c730 to
3a0a169
Compare
CodSpeed Performance ReportMerging #84886 will not alter performanceComparing Summary
Footnotes
|
c6814e6 to
4cba247
Compare
crates/next-core/src/middleware.rs
Outdated
| let has_default = esm_exports.exports.contains_key(&rcstr!("default")); | ||
| let expected_named = if is_proxy { | ||
| rcstr!("proxy") | ||
| } else { | ||
| rcstr!("middleware") | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work?
| let has_default = esm_exports.exports.contains_key(&rcstr!("default")); | |
| let expected_named = if is_proxy { | |
| rcstr!("proxy") | |
| } else { | |
| rcstr!("middleware") | |
| }; | |
| let has_default = esm_exports.exports.contains_key("default"); | |
| let expected_named = if is_proxy { | |
| "proxy" | |
| } else { | |
| "middleware" | |
| }; |
RcStrimplementsBorrow<str>: https://turbopack-rust-docs.vercel.sh/rustdoc/turbo_rcstr/struct.RcStr.html#impl-Borrow%3Cstr%3E-for-RcStrcontains_key(&self, k: &Q)requiresK: Borrow<Q>: https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.contains_key
So it should be possible for Q to be str in this case.
crates/next-core/src/middleware.rs
Outdated
| bail!( | ||
| "The {} file \"./{}\" must export a function named `{}` or a default function.", | ||
| file_type, | ||
| file_name, | ||
| function_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really shouldn't use bail! for issues in user code. We should instead emit an implementation of the Issue trait. e.g.
next.js/crates/next-core/src/next_shared/webpack_rules/babel.rs
Lines 297 to 348 in 3247607
| #[turbo_tasks::value] | |
| struct BabelPluginReactCompilerResolutionIssue { | |
| failed_resolution: RcStr, | |
| config_file_path: FileSystemPath, | |
| } | |
| #[turbo_tasks::value_impl] | |
| impl Issue for BabelPluginReactCompilerResolutionIssue { | |
| #[turbo_tasks::function] | |
| fn stage(&self) -> Vc<IssueStage> { | |
| IssueStage::Transform.into() | |
| } | |
| fn severity(&self) -> IssueSeverity { | |
| IssueSeverity::Error | |
| } | |
| #[turbo_tasks::function] | |
| fn file_path(&self) -> Vc<FileSystemPath> { | |
| self.config_file_path.clone().cell() | |
| } | |
| #[turbo_tasks::function] | |
| fn title(&self) -> Vc<StyledString> { | |
| StyledString::Line(vec![ | |
| StyledString::Text(rcstr!("Failed to resolve package ")), | |
| StyledString::Code(self.failed_resolution.clone()), | |
| StyledString::Text(rcstr!(" while attempting to resolve React Compiler")), | |
| ]) | |
| .cell() | |
| } | |
| #[turbo_tasks::function] | |
| fn description(&self) -> Vc<OptionStyledString> { | |
| Vc::cell(Some( | |
| StyledString::Line(vec![ | |
| StyledString::Text(rcstr!("React compiler is enabled in ")), | |
| StyledString::Code(self.config_file_path.path.clone()), | |
| StyledString::Text(rcstr!( | |
| ". We attempted to resolve React Compiler relative to the " | |
| )), | |
| StyledString::Code(rcstr!("next")), | |
| StyledString::Text(rcstr!(" package. Is ")), | |
| StyledString::Code(rcstr!(BABEL_PLUGIN_REACT_COMPILER)), | |
| StyledString::Text(rcstr!(" installed in your ")), | |
| StyledString::Code(rcstr!("node_modules")), | |
| StyledString::Text(rcstr!(" directory?")), | |
| ]) | |
| .resolved_cell(), | |
| )) | |
| } | |
| } |
After emitting, the logic should probably continue on as if there were no middleware file, or it should do a best-effort creation of a middleware module. You only want to bail if something is truly fatal and should block us from trying to collect other issues or from serving pages with the dev server.
f19dbfb to
752ba05
Compare
752ba05 to
962637e
Compare
| if ( | ||
| node.type === 'ExportDeclaration' && | ||
| node.declaration?.type === 'FunctionDeclaration' | ||
| ) { | ||
| const id = node.declaration.identifier?.value | ||
| if (id === 'middleware') { | ||
| hasMiddlewareExport = true | ||
| } | ||
| if (id === 'proxy') { | ||
| hasProxyExport = true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The AST node type check is incorrect. The condition node.type === 'ExportDeclaration' should be node.type === 'ExportNamedDeclaration' to properly detect named function exports.
In the AST specification, named exports are represented by the 'ExportNamedDeclaration' type, not 'ExportDeclaration'. With the current condition, this code path will never execute, causing the validation to miss valid named function exports.
This issue appears in both function declaration and variable declaration checks in this validation function.
GitHub - Vercel/next.js
// Correct version:
if (
node.type === 'ExportNamedDeclaration' &&
node.declaration?.type === 'FunctionDeclaration'
) {
// ...
}| if ( | |
| node.type === 'ExportDeclaration' && | |
| node.declaration?.type === 'FunctionDeclaration' | |
| ) { | |
| const id = node.declaration.identifier?.value | |
| if (id === 'middleware') { | |
| hasMiddlewareExport = true | |
| } | |
| if (id === 'proxy') { | |
| hasProxyExport = true | |
| } | |
| if ( | |
| node.type === 'ExportNamedDeclaration' && | |
| node.declaration?.type === 'FunctionDeclaration' | |
| ) { | |
| const id = node.declaration.identifier?.value | |
| if (id === 'middleware') { | |
| hasMiddlewareExport = true | |
| } | |
| if (id === 'proxy') { | |
| hasProxyExport = true | |
| } |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
962637e to
3f3e9d2
Compare
| // Continue execution instead of bailing - let the module be processed anyway | ||
| // The runtime template will still catch this at runtime | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code emits an error issue but continues execution, which contradicts the PR's stated goal of "throw[ing] error during build." This approach means the build will still succeed despite detecting invalid exports.
To properly fail at build time, consider returning an error or throwing an exception after emitting the issue, rather than continuing execution. Otherwise, the validation only provides a warning that could still be missed, and the runtime error will still occur in production.
| // Continue execution instead of bailing - let the module be processed anyway | |
| // The runtime template will still catch this at runtime | |
| } | |
| // Don't continue execution - fail the build when invalid exports are detected | |
| // This ensures the error is caught during build time rather than at runtime | |
| return Err(Error::other(format!("Invalid exports in {}", module_path))); | |
| } | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust part LGTM, minus the use of std::path::Path, which is going to cause issues on Windows.
crates/next-core/src/middleware.rs
Outdated
| let file_name = Path::new(&self.file_path.path) | ||
| .file_name() | ||
| .and_then(|n| n.to_str()) | ||
| .unwrap_or(&self.file_path.path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this API instead of std::fs::Path: https://turbopack-rust-docs.vercel.sh/rustdoc/turbo_tasks_fs/struct.FileSystemPath.html#method.file_name
Why:
turbo-task-fspaths always use forward slashes and are therefore not valid OS paths on Windows, sostd::fs::Path::file_namewouldn't work properly there.- We need the representation to be the same across everything on Windows or Unix, so that we can potentially share caches across OSes in the future, which is why we always use forward slash separators.
| StyledString::Text(rcstr!(" file \"")), | ||
| StyledString::Code(format!("./{}", file_name).into()), | ||
| StyledString::Text(rcstr!("\" must export a function named ")), | ||
| StyledString::Code(format!("`{}`", self.function_name).into()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Leave the formatting choice of backticks around code to the thing doing the formatting.
| StyledString::Code(format!("`{}`", self.function_name).into()), | |
| StyledString::Code(self.function_name.clone()), |
| let (file_type, function_name, page_path) = if is_proxy { | ||
| ("Proxy", "proxy", "/proxy") | ||
| } else { | ||
| ("Middleware", "middleware", "/middleware") | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this is nicer than it was written before with a bunch of is_proxy checks.
3f3e9d2 to
4d87f39
Compare
Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>
Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>
621cfce to
d3240ad
Compare

Why?
When Proxy/Middleware had invalid exports (valid: named function
proxyforproxy.js, named functionmiddlewareformiddleware.js, or default function), it errored during runtime but not during build.This error can sneak into production as it only throws during runtime.
How?
Walk AST of the Proxy/Middleware file, and if a valid export is not found, throw during build.