Fix get_max_num_running_seqs for waiting seq groups #1034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zhuohan123 |
zhuohan123
reviewed
Sep 17, 2023
| return self.sampling_params.best_of | ||
| else: | ||
| if self.sampling_params.best_of > self.num_seqs(): | ||
| if self.sampling_params.best_of >= self.num_seqs(): |
There was a problem hiding this comment.
Thanks for reporting the issue! This fix will make the if always be true. Please find the correct change in #1068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
get_max_num_running_seqswill always return 0 for waiting sequences in the case ofbest_of == self.num_seqs(), leading to incorrect scheduler behavior of scheduling more requests thanmax_num_seqs.