Fix get_max_num_running_seqs for waiting and swapped seq groups #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
reviewed
Sep 17, 2023
Comment on lines
+253
to
+254
| # that are not finished yet. | ||
| return self.num_unfinished_seqs() |
There was a problem hiding this comment.
The semantic of the function will change because this also counts swapped sequences. Is this expected?
There was a problem hiding this comment.
This is intended. get_max_num_running_seqs is being called for a swapped sequence when the swapped sequence is about to be swapped back to the running queue. This means these swapped sequences will soon become running sequences. This is the same logic as waiting sequences.
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
amy-why-3459
pushed a commit
to amy-why-3459/vllm
that referenced
this pull request
Sep 15, 2025
### What this PR does / why we need it? Adjust concurrency group for each npu workflow - for pd and benchmarks share the static-08-01, so only one job can runs on - other job one PR/schedule should have only 1 job runs ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the actual correct fix for the issues in #1034.
cc @Yard1