[FIX] Minor bug fixes #1035
Merged
[FIX] Minor bug fixes #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Sep 13, 2023
| # We use float32 for probabilities and log probabilities. | ||
| # Compute the probabilities. | ||
| probs = torch.softmax(logits, dim=-1, dtype=torch.float) | ||
| # Compute the log probabilities (before applying top-p and top-k). |
There was a problem hiding this comment.
Besides, should we remove (before applying top-p and top-k)?
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
* [FIX] Minor bug fixes * Address review comments
yiliu30
pushed a commit
to yiliu30/vllm-fork
that referenced
this pull request
Apr 23, 2025
Previously, we use `if hasattr(self, "scaling_factors")` to determine whether call `prepare_cos_sin`, however, some model's scaling factor in `rope_scaling` has a slightly different name, which is `scaling_factor` (**note: no ending 's'**), in this case, it will failed to call `prepare_cos_sin`, which is not expected. This PR will help with the following class: - `Llama3RotaryEmbedding` - `DynamicNTKScalingRotaryEmbedding` - `YaRNScalingRotaryEmbedding` Signed-off-by: zhouyu5 <yu.zhou@intel.com> Co-authored-by: Michał Kuligowski <mkuligowski@habana.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #959.
cc @wanmok