OpenAI-Server: Only fail if logit_bias has actual values #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
yiliu30
pushed a commit
to yiliu30/vllm-fork
that referenced
this pull request
Apr 15, 2025
Adjusted method of extracting synapse build id for release branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many OpenAI wrappers of popular libraries such as
langchainorhaystackwill always append an empty dictionary as alogit_biasvalue to their requests. Currently the server will return an error in these cases. I think the server should only error out iflogit_biasactually contains any values and process the request otherwise. This enables user to simply use their vLLM servers vialangchain.