KEMBAR78
Add pandas to requirements.txt by WoosukKwon · Pull Request #1047 · vllm-project/vllm · GitHub
Skip to content

Add pandas to requirements.txt #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

Add pandas to requirements.txt #1047

merged 2 commits into from
Sep 15, 2023

Conversation

@WoosukKwon
Copy link
Collaborator

Closes #754

When I tried inference with TP, I got a message like:

ValueError: Ray is not installed. Please install Ray to use distributed serving.

although I've already installed Ray.

This turned out be due to the following error in importing Ray data:

 File "/home/wskwon/anaconda3/envs/test-ray/lib/python3.9/site-packages/ray/air/__init__.py", line 2, in <module>
    from ray.air.config import (
  File "/home/wskwon/anaconda3/envs/test-ray/lib/python3.9/site-packages/ray/air/config.py", line 25, in <module>
    from ray.data.preprocessor import Preprocessor
  File "/home/wskwon/anaconda3/envs/test-ray/lib/python3.9/site-packages/ray/data/__init__.py", line 3, in <module>
    import pandas  # noqa
ModuleNotFoundError: No module named 'pandas'

zhuohan123
zhuohan123 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhuohan123 zhuohan123 merged commit a589369 into main Sep 15, 2023
@WoosukKwon WoosukKwon deleted the add-pandas branch September 15, 2023 02:09
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@WoosukKwon
Add pandas to requirements.txt (vllm-project#1047)
f4a8ff5 
* Add pandas to requirements.txt

* Minor
@AlpinDale AlpinDale mentioned this pull request Sep 22, 2024
Merged
pi314ever pushed a commit to pi314ever/vllm that referenced this pull request Apr 16, 2025
@libinta @michalkuligowski
Fix embedding model accuracy issue when merged prefill is enabled (vl…
1d52800 
…lm-project#1047)

The make_attn_bias in hpu_model_runner doesn't cover the non-causal
embedding model mask set and also vertical mask off is not set when
merged prefill is enabled.



<!--- pyml disable-next-line no-emphasis-as-heading -->

---------

Co-authored-by: Michał Kuligowski <mkuligowski@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImportError: Ray is not installed. but verified it is installed!

2 participants

@WoosukKwon @zhuohan123