KEMBAR78
Add pyarrow to dependencies & Print warning on Ray import error by WoosukKwon · Pull Request #1094 · vllm-project/vllm · GitHub
Skip to content

Conversation

@WoosukKwon
Copy link
Collaborator

Thanks @infwinston for reporting the error!

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@WoosukKwon
Copy link
Collaborator Author

Let's have this quick fix first and then remove the dependencies afterwards.

@WoosukKwon WoosukKwon merged commit 400b828 into main Sep 19, 2023
@WoosukKwon WoosukKwon deleted the warn-ray-import-error branch September 19, 2023 05:36
amy-why-3459 pushed a commit to amy-why-3459/vllm that referenced this pull request Sep 15, 2025
…llm-project#1094)

### What this PR does / why we need it?
Add `with_prefill_across_dp` to AscendMetadata to fix dp

This pr fixes the bug introduced by vllm-project#1012, which add an arg
`with_prefill_across_dp` when dp_size > 1.

Signed-off-by: MengqingCao <cmq0113@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants