fix typo (?) #1184
Merged
fix typo (?) #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stage_devices => placement_group
Add correct comment
zhuohan123
approved these changes
Sep 27, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
pi314ever
pushed a commit
to pi314ever/vllm
that referenced
this pull request
May 20, 2025
…lm-project#1184) It fixes issue with compilation in Dynamo. Original version failed with: ```` torch._dynamo.exc.InternalTorchDynamoError: AttributeError: 'dict' object has no attribute 'node' ... from user code: .. File "./vllm/model_executor/layers/linear.py", line 1469, in sync_weight_attrs for k in (set(src_param.__dict__.keys()) - ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stage_devices => placement_group