Automatically set max_num_batched_tokens
#1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhuohan123 Sorry for the commits after requesting your review. Now the PR is ready for review! |
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
May 12, 2025
This PR choose the HPU device according to the local rank instead of the first available one. Choosing the first available HPU will results in: - random mapping between the `local_rank` and the `module_id` as the process of each rank starts in random order. - failure to select specified devices with `HABANA_VISIBLE_MODULES`. The random mapping may cause cross-NUMA access in inter-node pipeline-parallel and cross-group HCCL call for PCIe SKU.
pi314ever
pushed a commit
to pi314ever/vllm
that referenced
this pull request
Jun 23, 2025
- [x] [vllm-project#1135](HabanaAI#1135) - [x] [vllm-project#1149](HabanaAI#1149) - [x] [vllm-project#1198](HabanaAI#1198) - [x] demo_proxy.py --------- Signed-off-by: zhenwei <zhenweiliu@habana.ai> Co-authored-by: Youlei Yang <youlei.yang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the default value (2560) of
max_num_batched_tokensand sets it based on the model's maximum length.