KEMBAR78
qwen add rope_scaling by Sanster · Pull Request #1210 · vllm-project/vllm · GitHub
Skip to content

Conversation

@Sanster
Copy link
Contributor

@Sanster Sanster commented Sep 28, 2023

qwen model add rope_scaling

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@WoosukKwon WoosukKwon merged commit 7bedab5 into vllm-project:main Sep 28, 2023
@Sanster Sanster mentioned this pull request Oct 12, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request May 8, 2025
vllm-project#1210)

MLP speculative failing is introduced by [Chore] Remove Sampler from
Model Code
([vllm-project#17084](vllm-project#17084))

This pr removed all sampler in models and use model_runner sampler.
Need to fwd sampler in HPUModelRunner


![image](https://github.com/user-attachments/assets/2eabe780-b670-451d-a705-5456c9de1788)

---------

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Co-authored-by: Michał Kuligowski <mkuligowski@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants