Add documentation to Triton server tutorial #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
reviewed
Sep 18, 2023
There was a problem hiding this comment.
@tanmayv25 Sorry for the delayed response, and thanks for your hard work on the integration! I've only requested a minor change.
Let's further promote this! On our side, I think we can further enhance the document with a running example and a performance benchmark.
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
|
@WoosukKwon Thanks for the comments! We welcome any improvements from the community. |
WoosukKwon
approved these changes
Sep 20, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a growing interest in how to deploy vLLM within Triton. Adding this documentation would make it easier for vLLM to find Triton as a serving platform. #541 (comment)