-
Notifications
You must be signed in to change notification settings - Fork 137
use preferred wording introduced in aria-description PR #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the extra spaces in the source code :)
|
Seems to mix "in the DOM" and "visible label: references: Here is a suggested edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jnurthen I added a comment on some suggested wording, the current pull request starts out with "in the DOM" and the switches to "Visible Text", seems like we should be more consistent in how we refer to aria-labelledby content.
…elledby points to
|
Good catch, @jongund. Thanks for reading the whole paragraph. I've committed your suggested text. |
* use "DOM content" instead of "visible text" to describe what aria-labelledby points to
* use "DOM content" instead of "visible text" to describe what aria-labelledby points to
When saying what determines when to use aria-labelledby over aria-label, use:
instead of:
Preview | Diff