KEMBAR78
removed references to <range> by estelle · Pull Request #1652 · w3c/aria · GitHub
Skip to content

removed references to <range> #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2021
Merged

removed references to <range> #1652

merged 4 commits into from
Dec 6, 2021

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 24, 2021 •
edited by pr-preview bot
Loading

<range> is not currently in HTML.
min, max, and value are attributes in input, meter, and progress.
changed the related concept for aria-valuemin, aria-valuemax, and aria-valuenow to input (from range)

Preview | Diff

@estelle
removed references to <range>
1869354 
<range> is not currently in html.
scottaohara
scottaohara reviewed Nov 26, 2021
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other roles that reference their HTML input counterpart include the type.

@jnurthen jnurthen requested review from carmacleod and pkra December 2, 2021 18:18
carmacleod
carmacleod approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pkra pkra self-assigned this Dec 3, 2021
@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Dec 3, 2021
@pkra
Copy link
Member

pkra commented Dec 3, 2021

@jnurthen @michael-n-cooper not sure how the IPR resolution works. Can I just click the 'mark as non-substantive' link on the repo-manager page linked above? (Also do we ignore the gh-page issue?)

@jnurthen
Copy link
Member

jnurthen commented Dec 3, 2021

@jnurthen @michael-n-cooper not sure how the IPR resolution works. Can I just click the 'mark as non-substantive' link on the repo-manager page linked above?

Yes - if it doesn't impact normative text then you can mark as non-substantive

@jnurthen
Copy link
Member

jnurthen commented Dec 3, 2021

(Also do we ignore the gh-page issue?)

Ideally no - it should build and I don't know why this is failing right now. @michael-n-cooper ?

@pkra
Copy link
Member

pkra commented Dec 3, 2021 •
edited
Loading

Ideally no - it should build and I don't know why this is failing right now. @michael-n-cooper ?

I think this should now be fixed (via #1648)

@pkra
Copy link
Member

pkra commented Dec 3, 2021

Yes - if it doesn't impact normative text then you can mark as non-substantive

Thanks!

@w3cbot
Copy link

w3cbot commented Dec 3, 2021

pkra marked as non substantive for IPR from ash-nazg.

@pkra
Copy link
Member

pkra commented Dec 3, 2021

Ideally no - it should build and I don't know why this is failing right now. @michael-n-cooper ?

I think this should now be fixed (via #1648)

@jnurthen assuming I'm correct, do we need @estelle to rebase the branch or can we go ahead and merge this one?

@jnurthen
Copy link
Member

jnurthen commented Dec 3, 2021

Ideally no - it should build and I don't know why this is failing right now. @michael-n-cooper ?

I think this should now be fixed (via #1648)

@jnurthen assuming I'm correct, do we need @estelle to rebase the branch or can we go ahead and merge this one?

This is simple enough that I think we can just merge it

@pkra pkra merged commit 1e0383a into w3c:main Dec 6, 2021
github-actions bot added a commit that referenced this pull request Dec 6, 2021
@estelle @github-actions
removed references to <range> (#1652)
43038d3 
SHA: 1e0383a
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pkra
Copy link
Member

pkra commented Dec 6, 2021

I think this should now be fixed (via #1648)

I think that was correct -- the merged commit didn't fail.

github-actions bot added a commit to pkra/aria that referenced this pull request Dec 6, 2021
@estelle @github-actions
removed references to <range> (w3c#1652)
3f1eeed 
SHA: 1e0383a
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pkra pkra mentioned this pull request Jan 10, 2022
Closed
pkra pushed a commit that referenced this pull request Jul 14, 2022
@estelle @pkra
removed references to <range> (#1652)
65a5fbb 
Replaces references to `<range>` (not currently in html) with references to `<input type="range">`

Co-authored-by:  Estelle Weyl @estelle,  Scott O'Hara @scottaohara
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkra pkra pkra approved these changes

@carmacleod carmacleod carmacleod approved these changes

@scottaohara scottaohara scottaohara approved these changes

Assignees

@pkra pkra

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@estelle @pkra @jnurthen @w3cbot @carmacleod @scottaohara