KEMBAR78
fix/1939 swap presentation/none roles by ariellalgilmore · Pull Request #1945 · w3c/aria · GitHub
Skip to content

fix/1939 swap presentation/none roles #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 16, 2023
Merged

fix/1939 swap presentation/none roles #1945

merged 12 commits into from
Jun 16, 2023

Conversation

ariellalgilmore
Copy link
Contributor

@ariellalgilmore ariellalgilmore commented May 24, 2023 •
edited by pr-preview bot
Loading

Closes #1939

worked with @andreancardona 🎉

  • Swapped presentation role information with none role information to emphasize the users to use none role.
  • Adjusted text when presentation role is mentioned to include none/presentation role.
  • Always put none first and updated examples to use none over presentation

Preview | Diff

@jnurthen jnurthen added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label May 25, 2023
@cookiecrook cookiecrook self-requested a review May 25, 2023 17:22
cookiecrook
cookiecrook approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor editorial suggestions ready to commit to the PR branch, and one item I propose be addressed as a separate issue, so that this PR is not unnecessarily delayed.

Otherwise, LGTM. Thanks.

ariellalgilmore and others added 11 commits May 25, 2023 14:37
@ariellalgilmore @cookiecrook
Update index.html
2809609 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
3d4acca 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
9ee5862 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
bd3894d 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
6189b7a 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
82b4ad0 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
1e2a611 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
5b769d1 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
d74e4fa 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
fb01b55 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore @cookiecrook
Update index.html
9a5ce60 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@ariellalgilmore ariellalgilmore mentioned this pull request May 25, 2023
Closed
adampage
adampage approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks terrific. 🚀

@spectranaut
Copy link
Contributor

@pkra - seems like this might be ready to merge?

@pkra pkra added this to the ARIA 1.3 milestone Jun 16, 2023
@pkra pkra merged commit cd6b483 into w3c:main Jun 16, 2023
github-actions bot added a commit that referenced this pull request Jun 16, 2023
@ariellalgilmore @github-actions
fix/1939 swap presentation/none roles (#1945)
f7d0725 
SHA: cd6b483
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore ariellalgilmore deleted the fix/1939-swap-presentation-none-roles branch June 19, 2023 17:06
@spectranaut spectranaut mentioned this pull request Jul 20, 2023
Merged
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
@ariellalgilmore @cookiecrook @jnurthen
fix/1939 swap presentation/none roles (#1945)
93c6fc1 
Co-authored-by: Ariella Gilmore <ariellagilmore@Ariellas-MacBook-Pro.local>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@pkra pkra mentioned this pull request Jun 13, 2025
Closed
@pkra pkra mentioned this pull request Sep 7, 2025
Merged
pkra added a commit that referenced this pull request Sep 25, 2025
@pkra
editorial: update roleInfo.js (manually) (#2624)
cc055a7 
Updates roleInfo using the current manual process. Changes are due to #2076, #1662, #1945, #2581, #1931, #1991, #1862

Part of #2501

Also resolves #2234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cookiecrook cookiecrook cookiecrook approved these changes

@adampage adampage adampage approved these changes

Assignees

@pkra pkra

@adampage adampage

@shirsha shirsha

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo

Projects

None yet

Milestone

2023

Development

Successfully merging this pull request may close these issues.

Suggestions: swap most content from #presentation and #none role section

7 participants

@ariellalgilmore @spectranaut @cookiecrook @adampage @pkra @jnurthen @shirsha