KEMBAR78
[css-view-transitions-1] Rename snapshot-root to snapshot containing block by noamr · Pull Request #8814 · w3c/csswg-drafts · GitHub
Skip to content

[css-view-transitions-1] Rename snapshot-root to snapshot containing block #8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 18, 2023
Merged

[css-view-transitions-1] Rename snapshot-root to snapshot containing block #8814

merged 4 commits into from
May 18, 2023

Conversation

@noamr
Copy link
Collaborator

@noamr noamr commented May 7, 2023 •
edited
Loading

[css-view-transitions-1] Rename snapshot-root to snapshot containing block and determine that the snapshot CB is an absolute/fixed positioning containing block for its descendants.

Based on this resolution.
Closes #8505

@noamr noamr requested a review from khushalsagar May 7, 2023 11:59
@noamr noamr changed the title Rename snapshot-root to snapshot containing block [css-view-transitions-1] Rename snapshot-root to snapshot containing block May 8, 2023
@khushalsagar khushalsagar requested review from bfgeek and bokand May 8, 2023 23:32
khushalsagar
khushalsagar approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@khushalsagar khushalsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % the point which can use David or Ian's review.

bokand
bokand approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@bokand bokand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but @bfgeek can better judge correctness

@khushalsagar
Copy link
Member

Just the one comment about heading name, otherwise LGTM.

noamr added 4 commits May 18, 2023 08:15
@noamr
Rename snapshot-root to snapshot containing block
225c067 
Also determine that the snapshot CB is an absolute/fixed positioning
containing block for its descendants.

Closes w3c#8505
@noamr
Move stuff around
cf18886
@noamr
Add changelist entry
096c140
@noamr
Heading name
df44d21
@khushalsagar khushalsagar merged commit 86046e4 into w3c:main May 18, 2023
bramus added a commit to bramus/csswg-drafts that referenced this pull request Jan 5, 2025
@bramus
[css-view-transitions-1] Use correct Snapshot Containing Block label …
ed7f2f0 
…in diagrams

The “Snapshot Root” got renamed to “Snapshot Containing Block” in w3c#8505. While the text in the spec itself got updated in w3c#8814, the diagrams still used the old name.
@bramus bramus mentioned this pull request Jan 5, 2025
Merged
noamr pushed a commit that referenced this pull request Jan 6, 2025
@bramus
[css-view-transitions-1] Use correct Snapshot Containing Block label …
08b4c5d 
…in diagrams (#11442)

The “Snapshot Root” got renamed to “Snapshot Containing Block” in #8505. While the text in the spec itself got updated in #8814, the diagrams still used the old name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushalsagar khushalsagar khushalsagar approved these changes

@bokand bokand bokand approved these changes

@bfgeek bfgeek Awaiting requested review from bfgeek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[css-view-transitions-1] Enforce ::view-transition to be fixed position

3 participants

@noamr @khushalsagar @bokand