KEMBAR78
Add hreflang attribute to link element by mattgarrish · Pull Request #1497 · w3c/epub-specs · GitHub
Skip to content

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Feb 2, 2021

Fixes #1488


Preview | Diff

Base automatically changed from master to main February 4, 2021 05:42
@iherman
Copy link
Member

iherman commented Feb 9, 2021

The issue was discussed in a meeting on 2021-02-04

List of resolutions:

View the transcript

6. Missing hreflang attribute

See github issue #1488.

Dave Cramer: 1488
… missing hreflang attribute
see issue
… there is a PR from Matt

See github pull request #1497.

Dave Cramer: PR 1497
… this is designed for the links in the package file
… if we're linking to external metadata, we can determine the language of the file
… consistent with other vocabularies
… this would be new, and wouldn't break anything
… any comments?

Ben Schroeter: Trying to understand the usage of this?

Dave Cramer: Say you have a multi-lingual epub, multiple metadata records
… norwegian canadian dictionary that has one record in norwegian and one in canadian english
… if the UI is set in one language, it can know to present the correct metadata to the user
… the RS doesn't have to determine the vocab from the resource, it can determine before download
… a hint

Ben Schroeter: Ok

Dave Cramer: I'm not aware of a RS that does this

Brady Duga: You can link to external metadata records? /sarcasm

Dave Cramer: We can write a test for it, but no RS will test it

Ben Schroeter: And where will you find a Norwegian-Canadian dictionary...

Brady Duga: This PR does add another untestable conformance requirement

Dave Cramer: I feel we're a little bit stuck here
… it's an i18n best practice
… if we say we're going to have linked metadata, we should have this
… we put this in, we get tests, the concept gets marked as at-risk at CR
… I think we should accept the PR, then see what testing shows us

Proposed resolution: Close 1488, accept PR 1497 (Wendy Reid)

Resolution #6: Close 1488, accept PR 1497

Dave Cramer: Progress!
… on i18n issues at least
… thanks everyone

Teenya Franklin: goodnight

Dave Cramer: see you all in the comment section

Dave Cramer: RRSAgent: draft minutes

Dave Cramer: RRSAgent: bye


@mattgarrish mattgarrish merged commit 43a5515 into main Feb 9, 2021
@mattgarrish mattgarrish deleted the feature/issue-1488 branch February 9, 2021 15:19
@murata2makoto
Copy link
Contributor

I don't like hreflang. What about content negotiation?

@mattgarrish
Copy link
Member Author

Content negotiation won't work with resources embedded in the epub. Linked resources don't have to be external.

@murata2makoto
Copy link
Contributor

Internal linked resources should specify which language is used. hreflang is just a bad hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(I18n) Missing hreflang attribute

3 participants