KEMBAR78
Editorial: fixup updateWith() example by marcoscaceres · Pull Request #667 · w3c/payment-request · GitHub
Skip to content

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jan 17, 2018

Remove mention of non-existent [[updatedUI]] internal slot. Simplify language a little bit.


Preview | Diff

@marcoscaceres
Copy link
Member Author

@ianbjacobs, could you please send a request to republish the spec?

@marcoscaceres marcoscaceres merged commit 9d3b14e into gh-pages Jan 18, 2018
@marcoscaceres marcoscaceres deleted the fixup_example branch January 18, 2018 00:35
@ianbjacobs
Copy link
Collaborator

@marcoscaceres,

Sorry for the delay. I see that a number of (mostly editorial) changes have happened to the main branch since the previous CR update (on 21 Sep 2017 [1]). Should I include all of them? or just this one (#667), or all of them up to and including this one?

Ian

[1] https://www.w3.org/TR/payment-request/

@marcoscaceres
Copy link
Member Author

All changes would be great 👍

@ianbjacobs
Copy link
Collaborator

@marcoscaceres,

Here's the draft I was looking at:
https://rawgit.com/w3c/payment-request/876a9cc21836c7d2b0fe27f17837cee7da63b664/index.html?specStatus=CR

There are 2 respec warnings:
Found linkless element with text 'displayitems' but no matching .
Found linkless element with text 'additionaldisplayitems' but no matching .

Would you mind fixing those first? Thanks!

Ian

@marcoscaceres
Copy link
Member Author

Would you mind fixing those first? Thanks!

Fixed! Thanks for letting me know.

PS: Alternative is to grab the tip from https://w3c.github.io/payment-request/?specStatus=CR

@ianbjacobs
Copy link
Collaborator

Thanks; will send publication request.
Ian

@marcoscaceres
Copy link
Member Author

@ianbjacobs let's get #671 merged first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants