KEMBAR78
Define PaymentResponse.retry() method by marcoscaceres · Pull Request #715 · w3c/payment-request · GitHub
Skip to content

Define PaymentResponse.retry() method #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Define PaymentResponse.retry() method #715

wants to merge 13 commits into from

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 21, 2018 •
edited by pr-preview bot
Loading

part of #705

The following tasks have been completed:

Implementation commitment:

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox - currently P3 bug
  • Edge (public signal)

Impact on Payment Handler spec?

Unknown.

Example

This pull request gets us here... the user doesn't yet know what's actually wrong with the payment, but at least they know something is wrong.

async function doPaymentRequest() {
  const request = new PaymentRequest(methodData, details, options);
  const response = await request.show();
  try {
    await recursiveValidate(request, response);
  } catch (err) { // retry aborted.
    console.error(err);
    return;
  }
  await response.complete("success");
}

async function recursiveValidate(request, response) {
  const promisesToFixThings = [];
  const errors = await validate(request, response);
  if (!errors) {
    return;
  }
  await response.retry();
  return recursiveValidate(request, response);
}

doPaymentRequest();

Preview | Diff

@stpeter
Copy link

stpeter commented May 21, 2018

@marcoscaceres Thanks for sketching this out - I like where it's going.

@marcoscaceres marcoscaceres changed the title WIP: retry() shell Define paymentResponse.retry() method May 22, 2018
@marcoscaceres marcoscaceres requested a review from domenic May 22, 2018 05:08
@marcoscaceres
Copy link
Member Author

@domenic, this puts in place the .retry() model, but without the validation errors (#712), or all the eventing infrastructure that is needed.

To keep the pull requests reasonable in size, I'm sending these parts incrementally.

@marcoscaceres
Copy link
Member Author

Blocked on #712.

@marcoscaceres
Copy link
Member Author

Started writing tests so found some bugs (yay! "the system works").

@marcoscaceres marcoscaceres changed the title Define paymentResponse.retry() method Define PaymentResponse.retry() method May 22, 2018
marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request May 22, 2018
@marcoscaceres
Add tests for PaymentResponse.retry()
6182c4c 
* Tests for w3c/payment-request#715
@marcoscaceres marcoscaceres mentioned this pull request May 22, 2018
Merged
@marcoscaceres
Copy link
Member Author

Tests: web-platform-tests/wpt#11101

@marcoscaceres
Copy link
Member Author

Added link to related Gecko bug.

@marcoscaceres marcoscaceres mentioned this pull request May 23, 2018
Closed
7 tasks
@marcoscaceres
Copy link
Member Author

Trying a different way... will send again.

marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request Jun 18, 2018
@marcoscaceres
Add tests for PaymentResponse.retry()
3266536 
* Tests for w3c/payment-request#715
marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request Jun 26, 2018
@marcoscaceres
Add tests for PaymentResponse.retry()
17d03ad 
* Tests for w3c/payment-request#715
marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request Jul 3, 2018
@marcoscaceres
Add tests for PaymentResponse.retry()
dfe57c5 
* Tests for w3c/payment-request#715
marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request Jul 16, 2018
@marcoscaceres
Add tests for PaymentResponse.retry()
73bd26b 
* Tests for w3c/payment-request#715
marcoscaceres added a commit to web-platform-tests/wpt that referenced this pull request Aug 13, 2018
@marcoscaceres
Add tests for PaymentResponse.retry() (#11101)
2f996e7 
* Add tests for PaymentResponse.retry()

* Tests for w3c/payment-request#715

* wip

* remove unnecessary comment

* test retry() rejects if doc not fully active

* Provide better instructions

* fix copy/pasta

* test 'abort the update'

* Calling retry() multiple times is always a new object.

* Generalize test for retry and complete
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 15, 2018
@marcoscaceres @moz-wptsync-bot
Bug 1463390 [wpt PR 11101] - Add tests for PaymentResponse.retry(), a…
ca31d39 
…=testonly

Automatic update from web-platform-testsAdd tests for PaymentResponse.retry() (#11101)

* Add tests for PaymentResponse.retry()

* Tests for w3c/payment-request#715

* wip

* remove unnecessary comment

* test retry() rejects if doc not fully active

* Provide better instructions

* fix copy/pasta

* test 'abort the update'

* Calling retry() multiple times is always a new object.

* Generalize test for retry and complete

--

wpt-commits: 2f996e750b6bf5c6c64b693aca154198241ae9e5
wpt-pr: 11101
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Aug 15, 2018
@marcoscaceres @moz-wptsync-bot
Bug 1463390 [wpt PR 11101] - Add tests for PaymentResponse.retry(), a…
8aa9ead 
…=testonly

Automatic update from web-platform-testsAdd tests for PaymentResponse.retry() (#11101)

* Add tests for PaymentResponse.retry()

* Tests for w3c/payment-request#715

* wip

* remove unnecessary comment

* test retry() rejects if doc not fully active

* Provide better instructions

* fix copy/pasta

* test 'abort the update'

* Calling retry() multiple times is always a new object.

* Generalize test for retry and complete

--

wpt-commits: 2f996e750b6bf5c6c64b693aca154198241ae9e5
wpt-pr: 11101
@marcoscaceres
Copy link
Member Author

.retry() API support landed in Firefox Nightly 🎉 (though the payments UI doesn't yet support it... but still 🎊 )

gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1463390 [wpt PR 11101] - Add tests for PaymentResponse.retry(), a…
6bfd877 
…=testonly

Automatic update from web-platform-testsAdd tests for PaymentResponse.retry() (#11101)

* Add tests for PaymentResponse.retry()

* Tests for w3c/payment-request#715

* wip

* remove unnecessary comment

* test retry() rejects if doc not fully active

* Provide better instructions

* fix copy/pasta

* test 'abort the update'

* Calling retry() multiple times is always a new object.

* Generalize test for retry and complete

--

wpt-commits: 2f996e750b6bf5c6c64b693aca154198241ae9e5
wpt-pr: 11101

UltraBlame original commit: 2b2c564b2e13accaa97fff7dd8264904c641bc77
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1463390 [wpt PR 11101] - Add tests for PaymentResponse.retry(), a…
f4ec1fd 
…=testonly

Automatic update from web-platform-testsAdd tests for PaymentResponse.retry() (#11101)

* Add tests for PaymentResponse.retry()

* Tests for w3c/payment-request#715

* wip

* remove unnecessary comment

* test retry() rejects if doc not fully active

* Provide better instructions

* fix copy/pasta

* test 'abort the update'

* Calling retry() multiple times is always a new object.

* Generalize test for retry and complete

--

wpt-commits: 2f996e750b6bf5c6c64b693aca154198241ae9e5
wpt-pr: 11101

UltraBlame original commit: 2b2c564b2e13accaa97fff7dd8264904c641bc77
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1463390 [wpt PR 11101] - Add tests for PaymentResponse.retry(), a…
7f63212 
…=testonly

Automatic update from web-platform-testsAdd tests for PaymentResponse.retry() (#11101)

* Add tests for PaymentResponse.retry()

* Tests for w3c/payment-request#715

* wip

* remove unnecessary comment

* test retry() rejects if doc not fully active

* Provide better instructions

* fix copy/pasta

* test 'abort the update'

* Calling retry() multiple times is always a new object.

* Generalize test for retry and complete

--

wpt-commits: 2f996e750b6bf5c6c64b693aca154198241ae9e5
wpt-pr: 11101

UltraBlame original commit: 2b2c564b2e13accaa97fff7dd8264904c641bc77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic Awaiting requested review from domenic

Assignees

No one assigned

Labels

Blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcoscaceres @stpeter