KEMBAR78
Rename AddressErrorFields -> AddressErrors by marcoscaceres · Pull Request #755 · w3c/payment-request · GitHub
Skip to content

Rename AddressErrorFields -> AddressErrors #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2018
Merged

Rename AddressErrorFields -> AddressErrors #755

merged 1 commit into from
Jul 16, 2018

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 16, 2018 •
edited by pr-preview bot
Loading

The following tasks have been completed:

Implementation commitment:

  • Safari - already implemented as AddressErrors.
  • Chrome (link to issue)
  • Firefox - already implemented.
  • Edge (public signal)

Impact on Payment Handler spec?

Preview | Diff

@marcoscaceres marcoscaceres requested a review from domenic July 16, 2018 15:12
@marcoscaceres
Copy link
Member Author

@domenic, just a rename here. We already implemented this in Gecko as AddressErrors a while back, so want to get this in before any other implementer starts on this (and also saves me a few weeks of back and forth on code review, etc. on the Gecko side).

@marcoscaceres marcoscaceres mentioned this pull request Jul 16, 2018
Merged
domenic
domenic approved these changes Jul 16, 2018
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is editorial, and not detectable, so really Gecko could call this whatever it wants...

@marcoscaceres
Copy link
Member Author

This is editorial, and not detectable, so really Gecko could call this whatever it wants...

Yeah, true that... but it has impact when searching for things in c++ across engines, etc.

@marcoscaceres marcoscaceres merged commit 0693d30 into gh-pages Jul 16, 2018
@marcoscaceres marcoscaceres deleted the AddressErrors branch July 16, 2018 15:53
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 19, 2018
@romandev
PaymentRequest: Drop prefixes, suffixes from error field members
b54bec1 
This corresponds to the upstream spec changes on:
  - w3c/payment-request#745
  - w3c/payment-request#755

Bug: 861704
Change-Id: Ib2cac3f3964eb99aa4fea5927f6df9d8b56dee2a
Reviewed-on: https://chromium-review.googlesource.com/1142044
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#576653}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcoscaceres @domenic