KEMBAR78
Rename `PayerErrorFields` to `PayerErrors` by akansha2608 · Pull Request #789 · w3c/payment-request · GitHub
Skip to content

Conversation

akansha2608
Copy link
Contributor

@akansha2608 akansha2608 commented Sep 30, 2018

closes #782

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • Modified Web platform tests IDL is automatically updated.
  • Modified MDN Docs (link)

Implementation commitment:

Optional, Impact on Payment Handler spec?


Preview | Diff

@marcoscaceres
Copy link
Member

Thanks @akansha2608. Two little things: please be sure to retain the pull request template, as all tasks listed there need to be completed before we can merge. I've added it back above so we can work through it. Also, please use "@marcoscaceres" not @marcos-travel - as that's just an account I use while traveling.

So, to start, when you open "index.html" from your local file system, can you confirm there are no errors or warnings next to the "ReSpec" button at the top of right of the spec?

Secondly, you need to check that PayerErrorFields doesn't appear on MDN (we might be lucky and it's not yet documented). But please confirm. If it's not documented, then we need to document it.

Lastly, we need to get implementation commitment from various browsers.

@aestes, @romandev or @rsolomakhin, minor bike shedding change? You all ok with this change?

@marcoscaceres marcoscaceres changed the title Issue #782 - Renames PayerErrorFields to PayerErrors Rename PayerErrorFields to PayerErrors Oct 1, 2018
@marcoscaceres marcoscaceres self-requested a review October 1, 2018 00:28
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename looks good.

@marcoscaceres
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@marcoscaceres
Copy link
Member

Firefox tracking bug https://bugzilla.mozilla.org/show_bug.cgi?id=1495335

@romandev
Copy link
Member

romandev commented Oct 1, 2018

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2018
Related spec change:
  w3c/payment-request#789

Bug: 890660
Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2018
Related spec change:
  w3c/payment-request#789

Bug: 890660
Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2018
Related spec change:
  w3c/payment-request#789

Bug: 890660
Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2018
Related spec change:
  w3c/payment-request#789

Bug: 890660
Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
@akansha2608
Copy link
Contributor Author

Thanks @akansha2608. Two little things: please be sure to retain the pull request template, as all tasks listed there need to be completed before we can merge. I've added it back above so we can work through it. Also, please use "@marcoscaceres" not @marcos-travel - as that's just an account I use while traveling.

Hi , thanks for the review , i will make sure from next time , its done totally by mistake.

So, to start, when you open "index.html" from your local file system, can you confirm there are no errors or warnings next to the "ReSpec" button at the top of right of the spec?

Hi @marcoscaceres , I checked the index.html on my local system , there is no errors or warnings near ReSpec button . Also attached screenshot for the same :)

Secondly, you need to check that PayerErrorFields doesn't appear on MDN (we might be lucky and it's not yet documented). But please confirm. If it's not documented, then we need to document it.

Yes we are lucky its not documented https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/PayerErrorFields, do we need to create another issue for the same? 😄

screenshot_2018-10-01 payment request api

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2018
Related spec change:
  w3c/payment-request#789

Bug: 890660
Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
@marcoscaceres
Copy link
Member

do we need to create another issue for the same?

@akansha2608, no, we generally just do it as part of this issue and then check the box at the top when it's done.

I'm seeing at least one mention of PayerErrorFields here:
https://developer.mozilla.org/en-US/search?q=PayerErrorFields&topic=apps&topic=html&topic=css&topic=js&topic=api&topic=canvas&topic=svg&topic=webgl&topic=mobile&topic=webdev&topic=http&topic=webext&topic=standards

Could you kindly please update it?

@akansha2608
Copy link
Contributor Author

I'm seeing at least one mention of PayerErrorFields here:
https://developer.mozilla.org/en-US/search?q=PayerErrorFields&topic=apps&topic=html&topic=css&topic=js&topic=api&topic=canvas&topic=svg&topic=webgl&topic=mobile&topic=webdev&topic=http&topic=webext&topic=standards

Could you kindly please update it?

Hi @marcoscaceres i updated this.

Can you guide me through first about first about documentation please :) How to do that?

@marcoscaceres
Copy link
Member

Can you guide me through first about first about documentation please :) How to do that?

Will follow up on Slack.

@marcoscaceres
Copy link
Member

Merging this so it's easier to do the docs

@marcoscaceres marcoscaceres merged commit 5498f93 into w3c:gh-pages Oct 2, 2018
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 2, 2018
Related spec change:
  w3c/payment-request#789

Bug: 890660
Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae
Reviewed-on: https://chromium-review.googlesource.com/1253942
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#595795}
@aestes
Copy link
Collaborator

aestes commented Nov 2, 2018

WebKit tracking bug: https://bugs.webkit.org/show_bug.cgi?id=191213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename PayerErrorFields to be like AddressErrors and BasicCardErrors

4 participants