Warn when errorFields don't match request[[options]] #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rsolomakhin, would mind having a first look? |
rsolomakhin
approved these changes
Nov 19, 2018
marcoscaceres
force-pushed
the
warnings
branch
from
ea93ccd to
788ee79
Compare
|
Added manual test web-platform-tests/wpt#14246 |
|
Anyone else willing to support these warnings (as we discussed in #793)? @aestes, @rsolomakhin? |
|
@rsolomakhin, filed Chrome bug. Hope that's ok, based on discussion. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 5, 2018
Related spec change: w3c/payment-request#807 Test: web-platform-tests/wpt#14246 Bug: 909577 Change-Id: Idb4caa2ad08193decaf1d4b0b0435e958176929b Reviewed-on: https://chromium-review.googlesource.com/c/1359932 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#613788}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #793
The following tasks have been completed:
Implementation commitment:
Optional, Impact on Payment Handler spec?
Preview | Diff