KEMBAR78
Clarify when the user can abort the payment request algorithm by marcoscaceres · Pull Request #810 · w3c/payment-request · GitHub
Skip to content

Clarify when the user can abort the payment request algorithm #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2019
Merged

Clarify when the user can abort the payment request algorithm #810

merged 4 commits into from
Jan 10, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Nov 20, 2018 •
edited by pr-preview bot
Loading

closes #796

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • Modified Web platform tests (link)
  • Modified MDN Docs (link)

Implementation commitment:

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox
  • Edge (public signal)

Optional, Impact on Payment Handler spec?
None

Preview | Diff

@marcoscaceres marcoscaceres requested a review from aestes November 20, 2018 06:10
@marcoscaceres
Copy link
Member Author

marcoscaceres commented Nov 20, 2018 •
edited
Loading

So, we had in there that there could be a timeout or some other means of aborting. However, I think we were going down the wrong path... I've routed the "timeout" and the user hitting "esc" down the "user aborts the payment request" path instead. I also removed the "[[updating]]" check to allow for this.

@marcoscaceres marcoscaceres mentioned this pull request Nov 20, 2018
Closed
@marcoscaceres
Copy link
Member Author

@domenic, if you have time, can you please sanity check this?

@marcoscaceres marcoscaceres mentioned this pull request Nov 21, 2018
Closed
domenic
domenic approved these changes Nov 22, 2018
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplication between "user aborts the payment request" and "abort the update" made this hard to review, but in the end I think the switch to that algorithm is fine. We should consider deduplicating those two algorithms though, if we can.

@marcoscaceres
Copy link
Member Author

Filed bug about de-dupe abort the update and user aborts. #814

@marcoscaceres
Copy link
Member Author

As this makes provisions for an optional UI feature (a "cancel" button or user triggered action, like a hitting "esc"), I'm ok with merging this as is. It doesn't really add any new conformance requirements. It just clarifies behavior that matches what browsers already do.

@marcoscaceres marcoscaceres merged commit a1e773a into gh-pages Jan 10, 2019
@marcoscaceres marcoscaceres deleted the abort_any_time branch January 10, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

@aestes aestes Awaiting requested review from aestes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify when the user can abort the payment request algorithm

2 participants

@marcoscaceres @domenic