fix: dispatch must set [[waitForUpdate]] to true #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyao
approved these changes
Mar 25, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 28, 2019
This is to match w3c/payment-request#855 This patch is required for Chrome to pass this WPT: https://w3c-test.org/payment-request/PaymentRequestUpdateEvent/updateWith-call-immediate-manual.https.html Bug: 945358 Change-Id: I6a8b355f557f338d60bb5f7e7eed99fc5bd311e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542144 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Jinho Bang <jinho.bang@samsung.com> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#645073}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #854
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
Preview | Diff