-
Notifications
You must be signed in to change notification settings - Fork 137
Remove requirement to reject after document is inactive #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋😢
Just noting that we will be keeping the previous behavior in Firefox. I don’t imagine it will cause any interop issues (hopefully!). |
How does that work? Does Firefox violate the HTML spec and run the event loop even in non-active documents? |
We monitor if the document becomes non-active and reject the relevant promises.
No (maybe). We just don’t leave the promises unsettled. |
Well, unless you run the event loop in non-active documents, you can never observe the promise becoming settled, because you have to run the event loop to call any fulfillment/rejection handlers... That's why I was mentioning in #872 (comment) that introducing this requirement was a mess-up. |
Ok, I’ll have another read of the architecture discussion. I didn’t read it very closely as I thought it was a limitation in Blink. If it applies to Gecko too, I can remove the code. |
Pro-tip: just read my posts in that thread, since they come from someone not as familiar with the Blink architecture, but instead with the spec ^_^. |
Ok, I see. I think it should be fine to change Gecko too. I’ll file a bug and do some investigation next week. |
closes #872
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec? N/A
Preview | Diff