Update transient activation to match WebKit #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsolomakhin
approved these changes
Aug 12, 2021
ianbjacobs
approved these changes
Aug 12, 2021
stephenmcgruer
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
I tried to find some prior art here on whether to throw a NotAllowed or SecurityError, and came up short 😂 . What I did find:
- webusb and webbluetooth throw a SecurityError
- One other spec I found threw NotAllowedError, but most other specs just quietly return or ignore calls/etc when there is no activation.
- We used to throw SecurityError, then switched to NotAllowedError without documented reason that I could find.
So... SecurityError LGTM? Maybe something the web should standardize on ;)
I've asked for this too elsewhere, but wasn't successful... as you point out, it's somewhat specific to the API (and if the API throws/rejects or can get away with doing nothing). |
|
Could someone please also approve the tests? 🙏 web-platform-tests/wpt#30006 |
|
@stephenmcgruer, filed Chrome bug https://bugs.chromium.org/p/chromium/issues/detail?id=1239453 Happy to send a patch, but please see my email as I'm not sure how to enable the right flag to trigger that code path. |
stephenmcgruer
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 13, 2021
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 13, 2021
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Aug 14, 2021
The error thrown when user activation is missing was recently changed from NotAllowedError to SecurityError: w3c/payment-request#961 This change has no effect on shipped Chrome yet as we currently don't throw at all for missing activation - the logic is hidden behind the capability delegation flag. Tested via unittest and via visiting https://wpt.live/payment-request/show-consume-activation.https.html with --enable-features=CapabilityDelegationPaymentRequest set. Bug: 1239453 Change-Id: I14f3874397468ca5da617afa930ffbbe254f1607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3092912 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#911813}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 15, 2021
…or cases for PaymentRequest.show(), a=testonly Automatic update from web-platform-tests Fix some NotAllowedError --> SecurityError cases for PaymentRequest.show() (#30023) See w3c/payment-request#961 -- wpt-commits: ee2d179bcea6e4a697e89a99a245e4571bd65097 wpt-pr: 30023
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Aug 20, 2021
…or cases for PaymentRequest.show(), a=testonly Automatic update from web-platform-tests Fix some NotAllowedError --> SecurityError cases for PaymentRequest.show() (#30023) See w3c/payment-request#961 -- wpt-commits: ee2d179bcea6e4a697e89a99a245e4571bd65097 wpt-pr: 30023
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 1, 2024
…or cases for PaymentRequest.show(), a=testonly Automatic update from web-platform-tests Fix some NotAllowedError --> SecurityError cases for PaymentRequest.show() (#30023) See w3c/payment-request#961 -- wpt-commits: ee2d179bcea6e4a697e89a99a245e4571bd65097 wpt-pr: 30023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the spec to match what WebKit does. We can then update Chrome to match.
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
none
Preview | Diff