KEMBAR78
debug `EXAMPLE 7` by youkinjoh · Pull Request #511 · w3c/presentation-api · GitHub
Skip to content

debug EXAMPLE 7 #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

debug EXAMPLE 7 #511

merged 1 commit into from
Jan 19, 2023

Conversation

@youkinjoh
Copy link
Contributor

@youkinjoh youkinjoh commented Dec 26, 2022 •
edited by pr-preview bot
Loading

{string: '你好，世界!', lang: 'zh-CN'} is not parsable to JSON.

// controller.html
connection.send("{string: '你好，世界!', lang: 'zh-CN'}");

// presentation.html
var messageObj = JSON.parse(message.data);

And, drop body property.

document.appendChild(spanElt);

Preview | Diff

@youkinjoh youkinjoh mentioned this pull request Dec 26, 2022
Merged
@w3cbot
Copy link

w3cbot commented Dec 27, 2022

tidoust marked as non substantive for IPR from ash-nazg.

@markafoltz
Copy link
Contributor

Thank you for this contribution! Unfortunately it looks like the spec doesn't build right now because of Issue #509. I will put up a PR to address that, then we can ensure the spec builds before merging.

@markafoltz markafoltz merged commit e20eb63 into w3c:main Jan 19, 2023
github-actions bot added a commit that referenced this pull request Jan 19, 2023
@youkinjoh @github-actions
debug EXAMPLE 7 (#511)
f4b421c 
SHA: e20eb63
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markafoltz markafoltz markafoltz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youkinjoh @w3cbot @markafoltz