KEMBAR78
debug `EXAMPLE 6` by youkinjoh · Pull Request #513 · w3c/presentation-api · GitHub
Skip to content

debug EXAMPLE 6 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

debug EXAMPLE 6 #513

merged 1 commit into from
Jan 19, 2023

Conversation

@youkinjoh
Copy link
Contributor

@youkinjoh youkinjoh commented Dec 27, 2022 •
edited by pr-preview bot
Loading

this variable pointed window object in this context.

var addConnection = function(connection) {
  this.onmessage = function (message) {
    if (message.data == "say hello")
      this.send("hello");
  };
};

Preview | Diff

@youkinjoh youkinjoh mentioned this pull request Dec 27, 2022
Merged
@w3cbot
Copy link

w3cbot commented Dec 27, 2022

tidoust marked as non substantive for IPR from ash-nazg.

@markafoltz
Copy link
Contributor

Thanks!

@markafoltz markafoltz merged commit b89b18b into w3c:main Jan 19, 2023
@markafoltz
Copy link
Contributor

I attempted to update the workflow to run after applying the PR to the target branch (which has the ReSpec fixes), but didn't convince github to do that, so I'm going to merge these PRs and clean up anything after the fact.

github-actions bot added a commit that referenced this pull request Jan 19, 2023
@youkinjoh @github-actions
debug EXAMPLE 6 (#513)
fca638f 
SHA: b89b18b
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markafoltz markafoltz markafoltz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youkinjoh @w3cbot @markafoltz