KEMBAR78
Update sendEncodings validation and initialization. by jan-ivar · Pull Request #2772 · w3c/webrtc-pc · GitHub
Skip to content

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Sep 21, 2022

Fixes #2730. @docfaraday PTAL. Ignore-whitespace diff recommended.


Preview | Diff

@jan-ivar jan-ivar changed the title Scaleaudio Update sendEncodings validation and initialization. Sep 21, 2022
@jan-ivar
Copy link
Member Author

@alvestrand if you could take a look at this one that would be great!

Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, there are no functional changes, and the language seems to be come clearer.
Approved.

@alvestrand alvestrand merged commit f8565ce into w3c:main Oct 13, 2022
@jan-ivar
Copy link
Member Author

@dontcallmedom this PR isn't 100% editorial since it fixes #2730. Do you want to take care of adding the amendments?

@dontcallmedom
Copy link
Member

if you could do it as the same time of documenting #2758 that would be appreciated :)

jan-ivar added a commit to jan-ivar/webrtc-pc that referenced this pull request Oct 13, 2022
aboba added a commit that referenced this pull request Oct 20, 2022
@jan-ivar jan-ivar deleted the scaleaudio branch March 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent initialization of scaleResolutionDownBy

3 participants