KEMBAR78
PaymentRequest: Implement desktop UI for PaymentResponse.retry() by chromium-wpt-export-bot · Pull Request #12550 · web-platform-tests/wpt · GitHub
Skip to content

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 17, 2018

Related spec change:
w3c/payment-request#721

Tests:
components/payments/content/payment_request_spec_unittest.cc
components/payments/content/payment_request_state_unittest.cc

Manual tests:
wpt/payment-request/payment-response/retry-method-manual.https.html
wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html
wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html

Demo:
https://youtu.be/_mbcGkbwfw8

Bug: 861704
Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7

Reviewed-on: https://chromium-review.googlesource.com/1144587
WPT-Export-Revision: ae0928e0dedea745a3b01f842e13b0af5dbf0989

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Related spec change:
  w3c/payment-request#721

Tests:
  components/payments/content/payment_request_spec_unittest.cc
  components/payments/content/payment_request_state_unittest.cc

Manual tests:
  wpt/payment-request/payment-response/retry-method-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html

Demo:
  https://youtu.be/_mbcGkbwfw8

Bug: 861704
Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7
@marcoscaceres marcoscaceres merged commit 4797b9c into master Aug 21, 2018
@marcoscaceres marcoscaceres deleted the chromium-export-cl-1144587 branch August 21, 2018 04:59
zcorpan pushed a commit that referenced this pull request Aug 27, 2018
)

Related spec change:
  w3c/payment-request#721

Tests:
  components/payments/content/payment_request_spec_unittest.cc
  components/payments/content/payment_request_state_unittest.cc

Manual tests:
  wpt/payment-request/payment-response/retry-method-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html
  wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html

Demo:
  https://youtu.be/_mbcGkbwfw8

Bug: 861704
Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants