-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[css-lists] Test counter-reset: reversed() #28453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Map `<ol start reversed>` and `<li value>` to `counter-reset` and `counter-set` properties as presentational hints. For reversed lists, use the CSS `reversed()` function added in w3c/csswg-drafts#6096. Tests: web-platform-tests/wpt#28040 & web-platform-tests/wpt#28453. Helps with #4808. Co-authored-by: Simon Pieters <zcorpan@gmail.com>
| .reset-reversed { counter-reset: reversed(not-list-item) } | ||
| .result::before { content: counter(not-list-item) } | ||
| </style> | ||
| <p>You should see the number 7 below.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you're expecting the reversed counter to start on 13 here, meaning you're leaning towards "count the number of elements that apply an increment of any kind to the counter" for the impl.
If we're already dynamically counting things that actively increment the counter, wouldn't we want to do it "correctly" and take the actual increment into account, like I suggest above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now fixed.
|
Thanks @tabatkins , I'll comment in w3c/csswg-drafts#6233 since the spec is wrong. |
|
Should also test |
|
These tests need to be updated to match w3c/csswg-drafts#6297 |
|
Done. |
|
r+, but it looks like we've got transient network failures causing some of the checks to fail. I think you might need to do a contentless push to kick them again. |
6a4ca37 to
aff8277
Compare
See w3c/csswg-drafts#6096