KEMBAR78
[css-lists] Test counter-reset: reversed() by zcorpan · Pull Request #28453 · web-platform-tests/wpt · GitHub
Skip to content

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Apr 13, 2021

@zcorpan zcorpan requested a review from MatsPalmgren April 13, 2021 14:34
@wpt-pr-bot wpt-pr-bot requested a review from tabatkins April 13, 2021 14:34
annevk pushed a commit to whatwg/html that referenced this pull request Apr 28, 2021
Map `<ol start reversed>` and `<li value>` to `counter-reset` and `counter-set` properties as presentational hints. For reversed lists, use the CSS `reversed()` function added in w3c/csswg-drafts#6096.

Tests: web-platform-tests/wpt#28040 & web-platform-tests/wpt#28453.

Helps with #4808.

Co-authored-by: Simon Pieters <zcorpan@gmail.com>
.reset-reversed { counter-reset: reversed(not-list-item) }
.result::before { content: counter(not-list-item) }
</style>
<p>You should see the number 7 below.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're expecting the reversed counter to start on 13 here, meaning you're leaning towards "count the number of elements that apply an increment of any kind to the counter" for the impl.

If we're already dynamically counting things that actively increment the counter, wouldn't we want to do it "correctly" and take the actual increment into account, like I suggest above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now fixed.

@zcorpan
Copy link
Member Author

zcorpan commented May 19, 2021

Thanks @tabatkins , I'll comment in w3c/csswg-drafts#6233 since the spec is wrong.

@zcorpan
Copy link
Member Author

zcorpan commented May 19, 2021

Should also test counter-set without counter-increment

@zcorpan
Copy link
Member Author

zcorpan commented Jun 15, 2021

These tests need to be updated to match w3c/csswg-drafts#6297

@zcorpan
Copy link
Member Author

zcorpan commented Jun 16, 2021

Done.

@tabatkins tabatkins self-requested a review June 16, 2021 16:22
@tabatkins
Copy link
Contributor

r+, but it looks like we've got transient network failures causing some of the checks to fail. I think you might need to do a contentless push to kick them again.

@zcorpan zcorpan closed this Jun 16, 2021
@zcorpan zcorpan reopened this Jun 16, 2021
@zcorpan zcorpan force-pushed the bocoup/css-lists-reversed branch from 6a4ca37 to aff8277 Compare June 16, 2021 20:50
@zcorpan zcorpan merged commit 35300f2 into master Jun 17, 2021
@zcorpan zcorpan deleted the bocoup/css-lists-reversed branch June 17, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants