-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove allowpaymentrequest attribute #5915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allowpaymentrequest attribute #5915
Conversation
|
Signed the IPR agreement also, but might need someone here to re-run the check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcoscaceres. Looks good modulo nits.
|
Oh, and for tests, can we test non-support for the IDL attribute at least? Testing the content attribute is harder I suppose. |
|
PR for IDL attribute test: #5915 |
8964ac4 to
d245bf7
Compare
|
Filed Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1665252 |
|
No sure what I did to poor Wattsi? Couldn't see anything obvious in the markup. |
I don’t see any problem with Wattsi — CI build is all green, right? https://travis-ci.org/github/whatwg/html/builds/727560433 |
Ah sorry, I see 💥 Error: Wattsi server error 💥 now |
|
I think maybe it’s just that this branch needs to be rebased. Can you do that? Or you want me to? |
|
Hey @sideshowbarker, "Current branch deprecate-allowpaymentrequest is up to date." |
- allowpaymentrequest removed in whatwg/html#5915 - allowusermedia removed in whatwg/html#4122
- allowpaymentrequest removed in whatwg/html#5915 - allowusermedia removed in whatwg/html#4122
allow="payment".(See WHATWG Working Mode: Changes for more details.)
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Sep 16, 2020, 1:23 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.