KEMBAR78
Fix possible exception when disposing terminal by Tyriar · Pull Request #4785 · xtermjs/xterm.js · GitHub
Skip to content

Fix possible exception when disposing terminal #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix possible exception when disposing terminal #4785

merged 1 commit into from
Sep 10, 2023

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 10, 2023

Fixes #4757

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 10, 2023
@Tyriar Tyriar self-assigned this Sep 10, 2023
@Tyriar Tyriar enabled auto-merge September 10, 2023 15:20
@Tyriar Tyriar mentioned this pull request Sep 10, 2023
Closed
@Tyriar Tyriar merged commit a7eb112 into xtermjs:master Sep 10, 2023
szymonkaliski added a commit to replit/xterm that referenced this pull request Oct 16, 2023
@szymonkaliski
pulled in xtermjs#4785 from upstream
0ec0dc2
@szymonkaliski szymonkaliski mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

dispose() causes an error with canvas renderer

1 participant

@Tyriar