KEMBAR78
change repository URL of all addons by ujjwalpandey922 · Pull Request #4795 · xtermjs/xterm.js · GitHub
Skip to content

change repository URL of all addons #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2023
Merged

change repository URL of all addons #4795

merged 2 commits into from
Sep 12, 2023

Conversation

@ujjwalpandey922
Copy link
Contributor

@ujjwalpandey922 ujjwalpandey922 commented Sep 12, 2023 •
edited by Tyriar
Loading

Fixes #4705

Tyriar
Tyriar requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one change

@Tyriar Tyriar added this to the 5.4.0 milestone Sep 12, 2023
@Tyriar Tyriar self-assigned this Sep 12, 2023
@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2023

Thanks!

@Tyriar Tyriar enabled auto-merge September 12, 2023 16:01
Tyriar added a commit to PerBothner/xterm.js that referenced this pull request Sep 12, 2023
@Tyriar
Set repository to sub-directory
9ab0cd6 
See xtermjs#4795
@Tyriar Tyriar merged commit cb89175 into xtermjs:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

Set addon package.json repository to sub-folder containing the addon

2 participants

@ujjwalpandey922 @Tyriar