fix: ProtoSchemaConver's problem when converting fields reference same… #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e enum types, the generated proto is not buildable. modified: google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java modified: google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverterTest.java
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
============================================
+ Coverage 77.27% 77.29% +0.01%
- Complexity 573 577 +4
============================================
Files 55 55
Lines 3367 3391 +24
Branches 198 202 +4
============================================
+ Hits 2602 2621 +19
- Misses 661 666 +5
Partials 104 104
Continue to review full report at Codecov.
|
Wilson720
approved these changes
Jul 16, 2020
allenc3
reviewed
Jul 17, 2020
...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java
Outdated
Show resolved
Hide resolved
...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java
Show resolved
Hide resolved
...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java
Outdated
Show resolved
Hide resolved
...orage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverterTest.java
Outdated
Show resolved
Hide resolved
allenc3
approved these changes
Jul 17, 2020
stephaniewang526
approved these changes
Jul 20, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.1](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.2.0...v1.2.1) (2020-07-20) ### Bug Fixes * ProtoSchemaConver's problem when converting fields reference same… ([#428](https://www.github.com/googleapis/java-bigquerystorage/issues/428)) ([1ce2621](https://www.github.com/googleapis/java-bigquerystorage/commit/1ce2621fe633f29c57bc4f4df84b2bcc2c57bdb8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
…o v1-rev20210127-1.31.0 (googleapis#428)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… enum types, the generated proto is not buildable.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️