Download as PDF, PPTX
![mail notifications
From: "Mike Peer (Code Review)" <mike@peer.de>
To: Thomas Koch <thomas@koch.ro>
Subject: Change in picture-gallery[master]: wrote
add method and tests
Mike Peer has posted comments on this change.
Change subject: wrote add method and tests
...........................................................
Patch Set 1: Looks good to me, but someone else must
approve
(2 inline comments)
good enough.
....................................................
File src/main/java/ro/koch/picturegallery/App.java
Line 13:
Could you please avoid unnecessary whitespace?
Line 16: return a + b;
Did you think about checking for overflows?](https://image.slidesharecdn.com/gerritlinuxtag2011-110510095753-phpapp01/85/Gerrit-linuxtag2011-19-320.jpg)
![clickable Issuetracker IDs
in gerrit.config:
[commentlink "bugzilla"]
match = "(bugs+#?)(d+)"
link = http://bugs.example.com/show_bug.cgi?id=$2
[commentlink "tracker"]
match = ([Bb]ug:s+)(d+)
html = $1<a href="http://trak.example.com/$2">$2</a>](https://image.slidesharecdn.com/gerritlinuxtag2011-110510095753-phpapp01/85/Gerrit-linuxtag2011-33-320.jpg)
![mail notifications
From: "Mike Peer (Code Review)" <mike@peer.de>
To: Thomas Koch <thomas@koch.ro>
Subject: Change in picture-gallery[master]: wrote
add method and tests
Mike Peer has posted comments on this change.
Change subject: wrote add method and tests
...........................................................
Patch Set 1: Looks good to me, but someone else must
approve
(2 inline comments)
good enough.
....................................................
File src/main/java/ro/koch/picturegallery/App.java
Line 13:
Could you please avoid unnecessary whitespace?
Line 16: return a + b;
Did you think about checking for overflows?](https://image.slidesharecdn.com/gerritlinuxtag2011-110510095753-phpapp01/75/Gerrit-linuxtag2011-19-2048.jpg)
![clickable Issuetracker IDs
in gerrit.config:
[commentlink "bugzilla"]
match = "(bugs+#?)(d+)"
link = http://bugs.example.com/show_bug.cgi?id=$2
[commentlink "tracker"]
match = ([Bb]ug:s+)(d+)
html = $1<a href="http://trak.example.com/$2">$2</a>](https://image.slidesharecdn.com/gerritlinuxtag2011-110510095753-phpapp01/75/Gerrit-linuxtag2011-33-2048.jpg)
More Related Content
![[Public] gerrit concepts and workflows](https://cdn.slidesharecdn.com/ss_thumbnails/publicgerrit-conceptsandworkflows-200829034112-thumbnail.jpg?width=600ounds&width=560&fit=bounds)
![[Mas 500] Software Development Strategies](https://cdn.slidesharecdn.com/ss_thumbnails/mas-500-2-software-stategies-131113120840-phpapp01-thumbnail.jpg?width=600ounds&width=560&fit=bounds)
![UiPath Automation Suite Installation (Hands-On) [2/3]](https://cdn.slidesharecdn.com/ss_thumbnails/automationsuitecommunitysession2-251015095633-a6d862f1-thumbnail.jpg?width=600ounds&width=560&fit=bounds)
Gerrit linuxtag2011
- 1. Gerrit code review Thomas Koch www.koch.ro May 10, 2011
- 2. me Thomas Koch http://www.koch.ro finished music, physics 5 years software developer: PHP (RIP!), Java, Hadoop, Search, Crawling, ERP, Groupware currently: finishing computer science bachelor, ETA: Q1/2012 tags: quality, ATTAC, FSFE, FIfF, social responsability, Romania, Switzerland
- 3. Outline motivation workflow integration demo apendix
- 4. We are GIT- Resistance is futile GNU core utils Linux-Kernel Samba Apache Software Foundation (mirrors) Perl5 freedesktop.org Maemo, QT Debian ( 3 of packages with KDE 4 a VCS) Gnome DragonFly BSD VLC, XMMS2 Fedora Prototype, YUI, jQuery Android Ruby on Rails Wine Drupal, Mantis Erlang . . . and many morea . . . GStreamer a http://git.or.cz/gitwiki/GitProjects
- 5. Why GIT? fast merging is easy amazing toolset and features low entry barrier for new contributors
- 6. Subversion is irrelevant but you still need: repository server easy repository management access control
- 7. Subversion is irrelevant but you still need: repository server easy repository management access control and since we’re agile: code review
- 8. Subversion is irrelevant but you still need: repository server easy repository management access control and since we’re agile: code review and if you like it: CLA management
- 9. 1 we are proudand seek review 1 CC BY-NC-ND 2.0 http://lacrimarum-valle.blogspot.com/2009/11/wendys-cakes.html
- 10. enter Gerrit initially for Android by Google public since ca. oct 2008 java rewrite of googles internal code review system by Shawn Pearce himself! tightly coupled to GIT
- 11. Gerrit users Eclipse Ebay2 , Intel, Red Hat, SAP Couchbase, WebM, Typo3 Assembla (dev tools as a service)3 openAFS Kitware (e.g. CMake)4 Sandia National Laboratories Mobiles: Android, Qualcomm Innovation Center, MeeGo, Sony Ericsson 2 http://dj.riceweevil.com/2010/07/25-week/ 3 http://blog.assembla.com/assemblablog/tabid/12618/bid/40871/ Introducing-Gerrit-a-scalable-code-review-system.aspx 4 http://www.kitware.com/blog/home/post/70
- 12.
- 13. Outline motivation workflow integration demo apendix
- 14. commit and pushto gerrit continuous integration (Jenkins) peer review jenkins OK, reviewer(s) OK? merge to integration branch
- 15. 3 main viewsin Gerrit UI: changes list change overview diff (side by side / unified)
- 16.
- 17.
- 18. Gerrit Change sideby side diff
- 19. mail notifications From: "Mike Peer (Code Review)" <mike@peer.de> To: Thomas Koch <thomas@koch.ro> Subject: Change in picture-gallery[master]: wrote add method and tests Mike Peer has posted comments on this change. Change subject: wrote add method and tests ........................................................... Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) good enough. .................................................... File src/main/java/ro/koch/picturegallery/App.java Line 13: Could you please avoid unnecessary whitespace? Line 16: return a + b; Did you think about checking for overflows?
- 20. Outline motivation workflow integration demo apendix
- 21.
- 22.
- 23.
- 24. Mylyn change details- attributes
- 25. Mylyn change details- comments
- 26. Mylyn change details- reviewers
- 27. Mylyn change details- patch sets
- 28.
- 29. Jenkins trigger andpost result
- 30. Jenkins trigger andpost result
- 31. Jenkins plugin fast (gerrit ssh stream) global configuration
- 32. more integration Mylyn (eclipse) Jenkins GitWeb Email notifications Auth: OpenID, LDAP, HTTP (Browser) build your own: hooks, streaming API e.g. parse Issuetracker IDs from commit messages and post to Jira/Mantis/Bugzilla
- 33. clickable Issuetracker IDs in gerrit.config: [commentlink "bugzilla"] match = "(bugs+#?)(d+)" link = http://bugs.example.com/show_bug.cgi?id=$2 [commentlink "tracker"] match = ([Bb]ug:s+)(d+) html = $1<a href="http://trak.example.com/$2">$2</a>
- 34. Outline motivation workflow integration demo apendix
- 35. Questions? http://www.koch.ro http://identi.ca/thkoch
- 36. Outline motivation workflow integration demo apendix
- 37. multiple versions ofa change Change-Id: I8596454156c4688abd1006cad8297d5aa7eb9331 (There’s a hook for that.)
- 38. search (WebUI orcmdline) ssh -p 29418 t61 gerrit query --format=JSON project:picture-gallery status:open owner:thomas@koch.ro Search for: age, owner, reviewer, project, branch, message, file, status, votes issue-tracker IDs: tr:ID / bug:ID topic starred (like bookmarked)
- 39. CLA and contactstore
- 40. more goodies topic star changes hooks (after the fact) replication
- 41. commit policies /Change Submit Action Fast Forward Only Merge If Necessary Always Merge Cherry Pick Shawn Pearce: Under cherry-pick the dependency data in Gerrit means nothing. If a change is submitted and it cherry-picks clean onto the branch tip, it gets patched onto the branch and marked merged, even if one or more dependent changes is not ready for submission.
- 42. cmdline tools overSSH admin: user: create-account ls-projects create-group query create-project review gsql stream-events suexec ...