switch to custom compose compiler due to CMP-7505 #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove gradle repos, ExperimentalMaterial removal
shishkin-pavel
commented
Aug 7, 2025
igordmn
reviewed
Aug 7, 2025
|
|
||
| // Create configuration that we'll use to load Compose compiler plugin | ||
| val configuration = project.configurations.create(COMPILER_PLUGIN_CONFIGURATION) | ||
| // Add Compose compiler plugin to kotlinPlugin configuration, making sure it works |
There was a problem hiding this comment.
Release Notes
N/A
As we fix a bug, it should contain "Fixes - Multiplatform" "Fix IrLinkageError: Function can not be called: No function found for symbol"
| // Create configuration that we'll use to load Compose compiler plugin | ||
| val configuration = project.configurations.create(COMPILER_PLUGIN_CONFIGURATION) | ||
| // Add Compose compiler plugin to kotlinPlugin configuration, making sure it works | ||
| // for Playground builds as well |
There was a problem hiding this comment.
An open thread until comments from #2290 are resolved
igordmn
reviewed
Aug 7, 2025
| handler.maven { | ||
| url("https://storage.googleapis.com/r8-releases/raw") | ||
| content { | ||
| includeModule("com.android.tools", "r8") |
There was a problem hiding this comment.
A QA should be added only for reviewing cherry-pick PRs
MatkovIvan
approved these changes
Aug 7, 2025
igordmn
approved these changes
Aug 7, 2025
shishkin-pavel
added a commit
that referenced
this pull request
Aug 7, 2025
patched compiler plugin generates additional stubs (1 or 2) for every `@Composable` function that has at least one default parameter for value class <A> internal/private constructor(baseVal: ...) (internal/private constructor is important) for every such default argument we are creating stubs where those args are marked nullable, thats where new public api comes from: one old function could be topped with one or two similarly-looking stubs in some later kotlin/compose version we would leave only one "right" signature (with deprecation cycle), but currently that approach is the only one that preserves compatibility Fixes [CMP-7505](https://youtrack.jetbrains.com/issue/CMP-7505) manual testing + test in compose compiler tests This should be tested by QA - Fix IrLinkageError: Function can not be called: No function found for symbol ([CMP-7505](https://youtrack.jetbrains.com/issue/CMP-7505)).
shishkin-pavel
added a commit
that referenced
this pull request
Aug 7, 2025
apidump update + remove ExperimentalMaterial3ExpressiveApi
sekater
added a commit
that referenced
this pull request
Aug 7, 2025
shishkin-pavel
added a commit
that referenced
this pull request
Aug 19, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 20, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 21, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 21, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 21, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 21, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 21, 2025
This reverts commit d480514.
shishkin-pavel
added a commit
that referenced
this pull request
Aug 26, 2025
patched compiler plugin generates additional stubs (1 or 2) for every `@Composable` function that has at least one default parameter for value class <A> internal/private constructor(baseVal: ...) (internal/private constructor is important) for every such default argument we are creating stubs where those args are marked nullable, thats where new public api comes from: one old function could be topped with one or two similarly-looking stubs in some later kotlin/compose version we would leave only one "right" signature (with deprecation cycle), but currently that approach is the only one that preserves compatibility Fixes [CMP-7505](https://youtrack.jetbrains.com/issue/CMP-7505) manual testing + test in compose compiler tests This should be tested by QA - Fix IrLinkageError: Function can not be called: No function found for symbol ([CMP-7505](https://youtrack.jetbrains.com/issue/CMP-7505)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patched compiler plugin generates additional stubs (1 or 2) for every
@Composablefunction that has at least one default parameter for value class internal/private constructor(baseVal: ...) (internal/private constructor is important)for every such default argument we are creating stubs where those args are marked nullable, thats where new public api comes from: one old function could be topped with one or two similarly-looking stubs
in some later kotlin/compose version we would leave only one "right" signature (with deprecation cycle), but currently that approach is the only one that preserves compatibility
Fixes CMP-7505
Testing
manual testing + test in compose compiler tests
This should be tested by QA
Release Notes
Fixes - Multiple Platforms