KEMBAR78
adjust experimental material3 expressive api by shishkin-pavel · Pull Request #2298 · JetBrains/compose-multiplatform-core · GitHub
Skip to content

Conversation

@shishkin-pavel
Copy link

@shishkin-pavel shishkin-pavel commented Aug 7, 2025

Proposed Changes

  • remove ExperimentalMaterial3ExpressiveApi annotation from no-longer-experimental API

Release Notes

Fixes - Multiple Platforms

  • ExperimentalMaterial3ExpressiveApi annotation removed from no-longer-experimental API

Testing

Test: manual tests

import androidx.compose.ui.window.DialogProperties

@Immutable
@ExperimentalMaterial3ExpressiveApi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably api dump will fail, as it should add a new non experimental API there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual ./gradlew jbApiDump invocation produced no difference for some reason

Copy link
Collaborator

@igordmn igordmn Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it is already there:
image

@MatkovIvan, where we exclude experimental annotations? It seems we need to add one more annotation there (in another PR)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #2174
but we don't need it in nor 1.9 (removed) nor 1.10 (build buildSrc already handles it)

Copy link
Collaborator

@igordmn igordmn Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.10 (build buildSrc already handles it)

My plan wasn't included migration to the new API checks in this migration. We can do that, but step by step.

Basically the plan was to use the new buildSrc + our added code without breaking compatibility with CI, and then gradually transform the tooling where it is needed

@shishkin-pavel shishkin-pavel merged commit 047581b into jb-main Aug 7, 2025
10 of 13 checks passed
@shishkin-pavel shishkin-pavel deleted the shish/CMP-7505/adjust-ExperimentalMaterial3ExpressiveApi branch August 7, 2025 17:00
sekater added a commit that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants