-
Notifications
You must be signed in to change notification settings - Fork 102
adjust experimental material3 expressive api #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust experimental material3 expressive api #2298
Conversation
| import androidx.compose.ui.window.DialogProperties | ||
|
|
||
| @Immutable | ||
| @ExperimentalMaterial3ExpressiveApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably api dump will fail, as it should add a new non experimental API there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manual ./gradlew jbApiDump invocation produced no difference for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatkovIvan, where we exclude experimental annotations? It seems we need to add one more annotation there (in another PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #2174
but we don't need it in nor 1.9 (removed) nor 1.10 (build buildSrc already handles it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10 (build buildSrc already handles it)
My plan wasn't included migration to the new API checks in this migration. We can do that, but step by step.
Basically the plan was to use the new buildSrc + our added code without breaking compatibility with CI, and then gradually transform the tooling where it is needed

Proposed Changes
ExperimentalMaterial3ExpressiveApiannotation from no-longer-experimental APIRelease Notes
Fixes - Multiple Platforms
ExperimentalMaterial3ExpressiveApiannotation removed from no-longer-experimental APITesting
Test: manual tests