Persist chat conversation ID for workflow tool usage #326
+59
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop to main for rc-10
Merge develop to main
Merge 1.0.0: upstream/develop to upstream/main
Merge pull request NVIDIA#92 from NVIDIA/develop
Updated changelog with another bug fix (NVIDIA#93)
[RELEASE] AIQToolkit v1.1.0
Changelog updated for 1.1.0 (NVIDIA#291)
ericevans-nv
added
feature request
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
force-pushed
the
feature/persist-chat-id-from-ui
branch
from
7bcd362 to
ea894d3
Compare
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
mdemoret-nv
requested changes
May 30, 2025
ericevans-nv
commented
Jun 4, 2025
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…ersist-chat-id-from-ui
…s-nv/agent-iq into feature/persist-chat-id-from-ui Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
ericevans-nv
force-pushed
the
feature/persist-chat-id-from-ui
branch
from
51e226e to
2462643
Compare
mdemoret-nv
requested changes
Jun 17, 2025
There was a problem hiding this comment.
How did we end up with "Thread ID" as the identifier here? The PR description says "Conversation ID" the linked UI PR uses "Conversation ID", but were using "Thread ID".
I think we need to come up with concrete terms for the IDs that could possibly be used. We have:
- session/conversation/thread ID: Chain of multiple inputs/outputs all in a row
- invocation/trace/thread ID: ID representing one individual input/output pair (spans distributed execution)
- thread/trace ID: ID representing one individual input/output pair (does not span distributed execution)
- function ID: One input/output for a single function
- span ID: Pair of start/stop events
We need to choose the naming convention we will use and then make that consistent throughout.
…ersist-chat-id-from-ui
…messages. Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…ersist-chat-id-from-ui
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…s-nv/agent-iq into feature/persist-chat-id-from-ui
…s-nv/agent-iq into feature/persist-chat-id-from-ui Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
…s-nv/agent-iq into feature/persist-chat-id-from-ui
Signed-off-by: Eric Evans <194135482+ericevans-nv@users.noreply.github.com>
mdemoret-nv
approved these changes
Jun 18, 2025
|
/merge |
AnuradhaKaruppiah
pushed a commit
to AnuradhaKaruppiah/oss-agentiq
that referenced
this pull request
Aug 4, 2025
This pull request involves persisting the chat conversation ID as metadata, enabling it’s use in workflow tools. The conversation ID needed to be forwarded as a header to enable this capability for http request. The PR for that change can be tracked here -> NVIDIA/NeMo-Agent-Toolkit-UI#15. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eric Evans II (https://github.com/ericevans-nv) - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#326
scheckerNV
pushed a commit
to scheckerNV/aiq-factory-reset
that referenced
this pull request
Aug 22, 2025
This pull request involves persisting the chat conversation ID as metadata, enabling it’s use in workflow tools. The conversation ID needed to be forwarded as a header to enable this capability for http request. The PR for that change can be tracked here -> NVIDIA/NeMo-Agent-Toolkit-UI#15. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AIQToolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eric Evans II (https://github.com/ericevans-nv) - David Gardner (https://github.com/dagardner-nv) - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: NVIDIA#326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request involves persisting the chat conversation ID as metadata, enabling it’s use in workflow tools. The conversation ID needed to be forwarded as a header to enable this capability for http request. The PR for that change can be tracked here -> NVIDIA/NeMo-Agent-Toolkit-UI#15.
By Submitting this PR I confirm: