-
Notifications
You must be signed in to change notification settings - Fork 396
Merge develop to main for v1.1.0a1 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuradha Karuppiah <anuradhak@nvidia.com>
Fixed quotes Signed-off-by: gzitzlsb-nv <gzitzlsberge@nvidia.com>
…range when given subtraction (#31) * Fix #27 (#28) Signed-off-by: atalhens <sneh.lata@nutanix.com> * Fix #29 Signed-off-by: atalhens <sneh.lata@nutanix.com> * Revert "Fix #29" This reverts commit 80e02dc. Signed-off-by: atalhens <sneh.lata@nutanix.com> * Fix #29 Update config Signed-off-by: atalhens <sneh.lata@nutanix.com> * Fix #29 Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com>
* Fix #32 Add a check to ensure empty input is not passed Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add str constant for output message Signed-off-by: atalhens <sneh.lata@nutanix.com> * Add unit test Signed-off-by: atalhens <sneh.lata@nutanix.com> --------- Signed-off-by: atalhens <sneh.lata@nutanix.com>
Signed-off-by: Andrey Voroshilov <avoroshilov@nvidia.com>
* First pass at adding issue templates, and rapids bots Signed-off-by: David Gardner <dagardner@nvidia.com> * Fix team name Signed-off-by: David Gardner <dagardner@nvidia.com> * Fix team name Signed-off-by: David Gardner <dagardner@nvidia.com> * First pass at a minimal CI for a PR Signed-off-by: David Gardner <dagardner@nvidia.com> * add ops-bots.yaml Signed-off-by: Christopher Harris <xixonia@gmail.com> * rename ops-bot.yaml -> ops-bots.yaml Signed-off-by: Christopher Harris <xixonia@gmail.com> * rename ops-bots.yaml -> ops-bot.yaml Signed-off-by: Christopher Harris <xixonia@gmail.com> --------- Signed-off-by: David Gardner <dagardner@nvidia.com> Signed-off-by: Christopher Harris <xixonia@gmail.com> Co-authored-by: Christopher Harris <xixonia@gmail.com>
This PR aims to improve the clarity of progress reporting when evaluators run in parallel by introducing a simple tqdm position registry and integrating it across multiple evaluator modules. Added TqdmPositionRegistry to manage progress bar positions. Updated trajectory and RAG evaluators to use the registry for clearer progress display. Wrapped workflow execution with progress bar updates for overall evaluation tasks. ``` Evaluating Ragas nv_context_relevance: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 6/6 [00:11<00:00, 1.85s/it] Evaluating Ragas nv_response_groundedness: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 6/6 [00:12<00:00, 2.10s/it] Evaluating Ragas nv_accuracy: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 6/6 [00:13<00:00, 2.19s/it] Evaluating Trajectory: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 6/6 [00:12<00:00, 2.05s/it] ``` Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #38
* Create basic CI pipeline * Add "subpackage" to vale vocabulary * Skip broken tests (#50) * Update `tests/aiq/eval/trajectory_evaluator/test_trajectory_evaluate.py` to perform a rounded equivalency test. Closes #44 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #46
This PR cleans up the GitLab CI pipeline by removing the outdated trigger stage and references, as well as cleaning up the variable used for the artifactory upload. Dropped the "trigger" stage from the stages list. Removed the associated trigger job script and rules from the pipeline. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #54
Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #55
@mdemoret-nv `res` sometimes contains the `categories` field `=None` Causing a pydantic validation exception sometimes Authors: - Bruno Alvisio (https://github.com/balvisio) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #22
* Store CI artifacts: test results, wheels, and documentation * Switch to using the uv containers, these are smaller and contain more of what we need and less of what we don't. * Fix CI runs on `develop` and `main` branches. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #56
* Add version number to the documentation title * Add `-W` flag to `sphinx-build` treating warnings as errors. * Remove performance hack, instead just set `-j 4` (instead of auto). * Remove unused `sphinx-build` flags * `linkcheck` is now it's own make target Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #24
As mentioned in [#39](#39), `platformdirs` should be included as a dependency of `AgentIQ` core component. This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue). Closes #39 (the `pypi` package needs to be updated) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #62
… does not exist (#63) This issue occurs when the parent directory of `AIQ_CONFIG_DIR` does not exist. Should use `os.makedirs` with `exist_ok=True` to create parent directories when necessary. Closes #40 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #63
Closes #43 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #61
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eric Evans II (https://github.com/ericevans-nv) - David Gardner (https://github.com/dagardner-nv) - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #64
Allow arg list to be extendable while checking for the mandatory args Closes #50 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #68
Improves readability of the Nested Stack Analysis Gantt chart by using relative timestamps instead of epoch timestamps. Normalized the timeline by subtracting the minimum start time from each bar's position and setting the x-axis limit accordingly. This ensures a clearer and more consistent visualization of nested call durations. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Yuchen Zhang (https://github.com/yczhang-nv) - David Gardner (https://github.com/dagardner-nv) URL: #70
* Adds a `ci/scripts/run_ci_local.sh` script allowing for executing CI scripts locally mirroring the GHA CI pipeline as closely as possible. * uv and pre-commit packages are cached in `.tmp/local_ci_tmp/cache` * uv's venv is located in `.tmp/local_ci_tmp/local_ci_workspace/.venv` * By default the script will perform a `git clone` and checkout the latest commit. This requires the latest commit to be pushed. * Alternately setting the environment variable `USE_HOST_GIT=1` the host's repo will be mounted inside the CI container, avoiding the need to commit/push changes. (Note: Doing so requires all git-lfs files to be checked out first). * Fix escape sequences in `ci/scripts/gitutils.py` Usage: * Run the entire CI pipeline: ```bash ./ci/scripts/run_ci_local.sh all ``` * Run just the checks stage: ```bash ./ci/scripts/run_ci_local.sh checks ``` * Debug a CI issue with the `bash` pseudo-stage. This will perform a git clone & checkout, and then drop you in a bash shell with all of the CI variables set. ```bash ./ci/scripts/run_ci_local.sh bash ``` ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #59
…rConfig` to allow `None` (#76) * Fixes an issue where the `str` type caused validation errors with the default `None` values. Closes #58 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #76
… (S3 bucket) (#71) Workflow, profiling and evaluation results can be customized and uploaded using S3 credentials. Sample Usage for customizing and uploading: ``` eval: general: output: dir: ./.tmp/aiq/examples/simple_output/ # Whether to cleanup the output directory before running the workflow cleanup: true custom_scripts: convert_workflow_to_csv: script: examples/simple/src/aiq_simple/scripts/workflow_to_csv.py kwargs: input: ./.tmp/aiq/examples/simple_output/workflow_output.json output: ./.tmp/aiq/examples/simple_output/workflow.csv # Upload contents of output directory to remote storage using S3 credentials remote_dir: output s3: endpoint_url: http://10.185.X.X:9000 bucket: aiq-simple-bucket access_key: fake-access-key secret_key: fake-secret-key dataset: _type: json # Download dataset from remote storage using S3 credentials remote_file_path: input/langsmith.json file_path: ./.tmp/aiq/examples/simple_input/langsmith.json s3: endpoint_url: http://10.185.X.X:9000 bucket: aiq-simple-bucket access_key: fake-access-key secret_key: fake-access-key ``` Sample Output: ``` 2025-04-04 09:23:38,412 - aiq.profiler.profile_runner - INFO - Wrote combined data to: .tmp/aiq/examples/simple_output/all_requests_profiler_traces.json 2025-04-04 09:23:38,542 - aiq.profiler.profile_runner - INFO - Wrote merged standardized DataFrame to .tmp/aiq/examples/simple_output/standardized_data_all.csv 2025-04-04 09:23:38,819 - aiq.profiler.profile_runner - INFO - Wrote inference optimization results to: .tmp/aiq/examples/simple_output/inference_optimization.json███████████████████████████████████████████████████████████| 3/3 [00:07<00:00, 2.04s/it] 2025-04-04 09:23:39,825 - aiq.profiler.profile_runner - INFO - Nested stack analysis complete 2025-04-04 09:23:39,864 - aiq.profiler.profile_runner - INFO - Concurrency spike analysis complete 2025-04-04 09:23:39,865 - aiq.profiler.profile_runner - INFO - Wrote workflow profiling report to: .tmp/aiq/examples/simple_output/workflow_profiling_report.txt 2025-04-04 09:23:39,866 - aiq.profiler.profile_runner - INFO - Wrote workflow profiling metrics to: .tmp/aiq/examples/simple_output/workflow_profiling_metrics.json 2025-04-04 09:23:39,870 - aiq.eval.evaluate - INFO - Workflow output written to .tmp/aiq/examples/simple_output/workflow_output.json 2025-04-04 09:23:39,871 - aiq.eval.evaluate - INFO - Evaluation results written to .tmp/aiq/examples/simple_output/rag_relevance_output.json 2025-04-04 09:23:39,871 - aiq.eval.evaluate - INFO - Evaluation results written to .tmp/aiq/examples/simple_output/rag_groundedness_output.json 2025-04-04 09:23:39,872 - aiq.eval.evaluate - INFO - Evaluation results written to .tmp/aiq/examples/simple_output/rag_accuracy_output.json 2025-04-04 09:23:39,872 - aiq.eval.evaluate - INFO - Evaluation results written to .tmp/aiq/examples/simple_output/trajectory_accuracy_output.json 2025-04-04 09:23:39,872 - aiq.eval.utils.output_uploader - INFO - Running custom script: examples/simple/src/aiq_simple/scripts/workflow_to_csv.py examples/simple/src/aiq_simple/scripts/workflow_to_csv.py --input ./.tmp/aiq/examples/simple_output/workflow_output.json --output ./.tmp/aiq/examples/simple_output/workflow.csv ✅ Converted workflow_output.json to workflow.csv 2025-04-04 09:23:39,922 - aiq.eval.utils.output_uploader - INFO - Custom script examples/simple/src/aiq_simple/scripts/workflow_to_csv.py completed successfully. Uploading files to S3: 0%| | 0/12 [00:00<?, ?it/s]2025-04-04 09:23:40,492 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/inference_optimization.json to s3://aiq-simple-bucket/output/inference_optimization.json Uploading files to S3: 8%|████████████████ | 1/12 [00:00<00:02, 3.94it/s]2025-04-04 09:23:40,518 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/workflow_profiling_metrics.json to s3://aiq-simple-bucket/output/workflow_profiling_metrics.json 2025-04-04 09:23:40,518 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/workflow.csv to s3://aiq-simple-bucket/output/workflow.csv 2025-04-04 09:23:40,520 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/workflow_profiling_report.txt to s3://aiq-simple-bucket/output/workflow_profiling_report.txt 2025-04-04 09:23:40,600 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/trajectory_accuracy_output.json to s3://aiq-simple-bucket/output/trajectory_accuracy_output.json Uploading files to S3: 42%|████████████████████████████████████████████████████████████████████████████████▍ | 5/12 [00:00<00:00, 16.44it/s]2025-04-04 09:23:40,614 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/rag_accuracy_output.json to s3://aiq-simple-bucket/output/rag_accuracy_output.json 2025-04-04 09:23:40,627 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/rag_groundedness_output.json to s3://aiq-simple-bucket/output/rag_groundedness_output.json 2025-04-04 09:23:40,867 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/rag_relevance_output.json to s3://aiq-simple-bucket/output/rag_relevance_output.json Uploading files to S3: 67%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▋ | 8/12 [00:00<00:00, 13.45it/s]2025-04-04 09:23:40,882 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/gantt_chart.png to s3://aiq-simple-bucket/output/gantt_chart.png 2025-04-04 09:23:40,885 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/standardized_data_all.csv to s3://aiq-simple-bucket/output/standardized_data_all.csv 2025-04-04 09:23:40,909 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/workflow_output.json to s3://aiq-simple-bucket/output/workflow_output.json 2025-04-04 09:23:42,068 - aiq.eval.utils.output_uploader - INFO - Uploaded .tmp/aiq/examples/simple_output/all_requests_profiler_traces.json to s3://aiq-simple-bucket/output/all_requests_profiler_traces.json Uploading files to S3: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 12/12 [00:01<00:00, 6.55it/s] ``` Closes #65, #66 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Dhruv Nandakumar (https://github.com/dnandakumar-nv) URL: #71
* Run the test CI stage on both Amd64 and Arm64. * Document installing QEMU to run CI for Arm64 on an Amd64 system. * Disable `examples/simple/tests/test_web_query_tool.py` test on Arm due to a known issue with Faiss #72 Requires #59 to be merged first ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #73
* This removes the need to repeat default config values in a YAML for the sole purpose allowing users to override the values with the `--override` flag. * Remove unnecessary `assert` in `src/aiq/data_models/common.py` as this is actually already handled by the code, allowing users to prototype config classes directly in the interpreter. * Add unittests for the `LayeredConfig` class. Closes #83 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) URL: #85
Signed-off-by: David Gardner <dagardner@nvidia.com>
Closes -> #84 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eric Evans II (https://github.com/ericevans-nv) - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #89
Changelog update ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 83 out of 90 changed files in this pull request and generated no comments.
Files not reviewed (7)
- .github/CODEOWNERS: Language not supported
- .gitmodules: Language not supported
- ci/scripts/bootstrap_local_ci.sh: Language not supported
- ci/scripts/common.sh: Language not supported
- ci/scripts/github/build_wheel.sh: Language not supported
- ci/scripts/github/checks.sh: Language not supported
- ci/scripts/github/common.sh: Language not supported
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge develop to main
Closes
By Submitting this PR I confirm: