KEMBAR78
Updating doc string for AIQSessionManager class. by ericevans-nv · Pull Request #64 · NVIDIA/NeMo-Agent-Toolkit · GitHub
Skip to content

Updating doc string for AIQSessionManager class. #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 2, 2025
Merged

Updating doc string for AIQSessionManager class. #64

merged 7 commits into from
Apr 2, 2025

Conversation

@ericevans-nv
Copy link
Contributor

Description

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@ericevans-nv ericevans-nv requested a review from a team as a code owner April 2, 2025 19:04
@copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

dagardner-nv and others added 5 commits April 2, 2025 14:07
@dagardner-nv
CI Documentation improvements (NVIDIA#24)
101988c 
* Add version number to the documentation title
* Add `-W` flag to `sphinx-build` treating warnings as errors.
* Remove performance hack, instead just set `-j 4` (instead of auto).
* Remove unused `sphinx-build` flags
* `linkcheck` is now it's own make target

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#24
Signed-off-by: Eric Evans <66225-erevans@users.noreply.gitlab-master.nvidia.com>
Updating doc string for AIQSessionManager class.
cdfc0fd 
Signed-off-by: Eric Evans <66225-erevans@users.noreply.gitlab-master.nvidia.com>
@yczhang-nv
Add missing platformdirs dependency (NVIDIA#62)
be44ab8 
As mentioned in [NVIDIA#39](NVIDIA#39), `platformdirs` should be included as a dependency of `AgentIQ` core component.

This issue does not occur when installing from source since `uv.lock` already includes `platformdirs`. However, the `pypi` package does not include `uv.lock` (and causes the missing dependency issue).

Closes NVIDIA#39 (the `pypi` package needs to be updated)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#62
Signed-off-by: Eric Evans <66225-erevans@users.noreply.gitlab-master.nvidia.com>
@yczhang-nv
Fix aiq command error when the parent directory of AIQ_CONFIG_DIR…
3a2265f 
… does not exist (NVIDIA#63)

This issue occurs when the parent directory of `AIQ_CONFIG_DIR` does not exist. Should use `os.makedirs` with `exist_ok=True` to create parent directories when necessary.

Closes NVIDIA#40

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#63
Signed-off-by: Eric Evans <66225-erevans@users.noreply.gitlab-master.nvidia.com>
@dagardner-nv
Fix broken image link in multi_frameworks documentation (NVIDIA#61)
edf9f3c 
Closes NVIDIA#43

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#61
Signed-off-by: Eric Evans <66225-erevans@users.noreply.gitlab-master.nvidia.com>
@ericevans-nv ericevans-nv force-pushed the session-manager-doc-string-fix branch from 4012f12 to edf9f3c Compare April 2, 2025 19:21
@ericevans-nv ericevans-nv self-assigned this Apr 2, 2025
@ericevans-nv ericevans-nv added doc Improvements or additions to documentation non-breaking Non-breaking change enhancement improvement Improvement to existing functionality and removed doc Improvements or additions to documentation enhancement labels Apr 2, 2025
AnuradhaKaruppiah
AnuradhaKaruppiah reviewed Apr 2, 2025
View reviewed changes
@ericevans-nv @AnuradhaKaruppiah
Update src/aiq/runtime/session.py
192a254 
Co-authored-by: Anuradha Karuppiah <anuradha.karuppiah@gmail.com>
Signed-off-by: Eric Evans II <194135482+ericevans-nv@users.noreply.github.com>
@ericevans-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8cfc4e6 into NVIDIA:develop Apr 2, 2025
3 checks passed
ericevans-nv added a commit to ericevans-nv/agent-iq that referenced this pull request Apr 14, 2025
@ericevans-nv
Updating doc string for AIQSessionManager class. (NVIDIA#64)
8be388c 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#64
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request Apr 21, 2025
@ericevans-nv @yczhang-nv
Updating doc string for AIQSessionManager class. (NVIDIA#64)
c588f6b 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#64
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
yczhang-nv pushed a commit to yczhang-nv/NeMo-Agent-Toolkit that referenced this pull request May 8, 2025
@ericevans-nv @yczhang-nv
Updating doc string for AIQSessionManager class. (NVIDIA#64)
4889ea9 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#64
Signed-off-by: Yuchen Zhang <134643420+yczhang-nv@users.noreply.github.com>
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/oss-agentiq that referenced this pull request Aug 4, 2025
@ericevans-nv
Updating doc string for AIQSessionManager class. (NVIDIA#64)
636f459 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#64
scheckerNV pushed a commit to scheckerNV/aiq-factory-reset that referenced this pull request Aug 22, 2025
@ericevans-nv
Updating doc string for AIQSessionManager class. (NVIDIA#64)
28581a7 
Closes

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/AgentIQ/blob/develop/docs/source/advanced/contributing.md).
- We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
  - Any contribution which contains commits that are not Signed-Off will not be accepted.
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eric Evans II (https://github.com/ericevans-nv)
  - David Gardner (https://github.com/dagardner-nv)
  - Yuchen Zhang (https://github.com/yczhang-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: NVIDIA#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

Assignees

@ericevans-nv ericevans-nv

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericevans-nv @AnuradhaKaruppiah @dagardner-nv @yczhang-nv