[None][infra] Pin the version for triton to 3.3.1 (#6508) #6519

chzblych · 2025-07-31T14:54:57Z

Summary by CodeRabbit

Chores
- Added a new platform-specific dependency for improved performance on certain architectures.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

coderabbitai · 2025-07-31T14:55:04Z

Walkthrough

A single change was made to the requirements.txt file, adding the dependency triton==3.3.1 conditioned to install only on x86_64 architectures. No other dependencies were modified or removed, and no code or exported entities were affected.

Changes

Cohort / File(s)	Change Summary
Dependency Addition `requirements.txt`	Added `triton==3.3.1` as a new platform-specific dependency for `x86_64`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[None][infra] Pin the version for triton to 3.3.1 #6508: Adds the same triton==3.3.1 dependency to requirements.txt, indicating a directly related change.

Suggested reviewers

ZhanruiSunCh

Poem

A bunny hopped through requirements land,
With a triton in paw, just as planned.
"Add 3.3.1!" it cheerfully wrote,
Now AI can swim, or perhaps just float.
Dependencies grow, but review is light—
The garden of code looks tidy and bright! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c49a8a and 3a77357.

📒 Files selected for processing (1)

requirements.txt (1 hunks)

✅ Files skipped from review due to trivial changes (1)

requirements.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

chzblych · 2025-07-31T14:56:12Z

/bot run

tensorrt-cicd · 2025-07-31T15:02:08Z

PR_Github #13692 [ run ] triggered by Bot

chzblych · 2025-07-31T17:10:16Z

/bot run

tensorrt-cicd · 2025-07-31T17:17:21Z

PR_Github #13692 [ run ] completed with state SUCCESS
/LLM/release-0.21/L0_MergeRequest_PR pipeline #265 completed with status: 'FAILURE'

tensorrt-cicd · 2025-07-31T17:17:49Z

PR_Github #13714 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-31T17:53:56Z

PR_Github #13714 [ run ] completed with state SUCCESS
/LLM/release-0.21/L0_MergeRequest_PR pipeline #266 completed with status: 'FAILURE'

Signed-off-by: qqiao <qqiao@nvidia.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych · 2025-08-01T02:45:31Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-08-01T02:51:44Z

PR_Github #13753 [ run ] triggered by Bot

tensorrt-cicd · 2025-08-01T07:04:07Z

PR_Github #13753 [ run ] completed with state SUCCESS
/LLM/release-0.21/L0_MergeRequest_PR pipeline #267 completed with status: 'SUCCESS'

…IA#6519) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

…IA#6519) (NVIDIA#6549) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Lanyu Liao <lancelly@users.noreply.github.com>

…IA#6519) (NVIDIA#6549) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

…VIDIA#6282 NVIDIA#6279 * [None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508) Signed-off-by: qqiao <qqiao@nvidia.com> * [None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508) (NVIDIA#6519) (NVIDIA#6549) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> * [fix]: use safeInitRowMax instead of fp32_lowest to avoid NaN (NVIDIA#7087) Signed-off-by: Yao Yao <lowsfer@users.noreply.github.com> * [None][fix] Fix a numerical stability issue for XQA with spec dec Signed-off-by: Yao Yao <lowsfer@users.noreply.github.com> * fix typo Signed-off-by: Jhao-Ting Chen <jhaotingc@nvidia.com> * fix precompiled multi_query_token kernel not having is_fp8_out hash key (NVIDIA#6279) Signed-off-by: Jhao-Ting Chen <jhaotingc@nvidia.com> * [fix] Fix missing fields in xqa kernel cache key (NVIDIA#6282) Signed-off-by: Yao Yao <lowsfer@users.noreply.github.com> --------- Signed-off-by: qqiao <qqiao@nvidia.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com> Signed-off-by: Yao Yao <lowsfer@users.noreply.github.com> Signed-off-by: Jhao-Ting Chen <jhaotingc@nvidia.com> Co-authored-by: Emma Qiao <qqiao@nvidia.com> Co-authored-by: Yanchao Lu <yanchaol@nvidia.com> Co-authored-by: Yao Yao <lowsfer@users.noreply.github.com>

chzblych requested a review from a team as a code owner July 31, 2025 14:54

[None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508)

3a77357

Signed-off-by: qqiao <qqiao@nvidia.com> Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych force-pushed the release/0.21 branch from 7c49a8a to 3a77357 Compare August 1, 2025 02:45

chzblych changed the title ~~[None][infra] Pin the version for triton to 3.3.1 (#6508)~~ @coderabbitai Aug 1, 2025

chzblych added the Release Blocker PRs that blocking the final release build or branching out the release branch label Aug 1, 2025

litaotju approved these changes Aug 1, 2025

View reviewed changes

chzblych changed the title ~~@coderabbitai~~ [None][infra] Pin the version for triton to 3.3.1 (#6508) Aug 1, 2025

chzblych merged commit 751d5f1 into NVIDIA:release/0.21 Aug 1, 2025
3 checks passed

chzblych deleted the release/0.21 branch August 1, 2025 07:05

chzblych added a commit to chzblych/TensorRT-LLM that referenced this pull request Aug 1, 2025

[None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508) (NVID…

d84ebcc

…IA#6519) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

coderabbitai bot mentioned this pull request Aug 1, 2025

[None][infra] Pin the version for triton to 3.3.1 (#6508) (#6519) #6549

Merged

chzblych added a commit that referenced this pull request Aug 1, 2025

[None][infra] Pin the version for triton to 3.3.1 (#6508) (#6519) (#6549

f39d621

) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

hlu1 pushed a commit that referenced this pull request Aug 5, 2025

[None][infra] Pin the version for triton to 3.3.1 (#6508) (#6519) (#6549

cc70b45

) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025

[None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508) (NVID…

340472f

…IA#6519) (NVIDIA#6549) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

jhaotingc pushed a commit to jhaotingc/TensorRT-LLM that referenced this pull request Aug 25, 2025

[None][infra] Pin the version for triton to 3.3.1 (NVIDIA#6508) (NVID…

aaa3a9f

…IA#6519) (NVIDIA#6549) Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

This was referenced Sep 1, 2025

[https://nvbugs/5492124][fix] revert to use triton==3.3.1 #7431

Merged

Revert "[https://nvbugs/5492124][fix] revert to use triton==3.3.1 (#7… #7574

Open

[None][infra] Pin the version for triton to 3.3.1 (#6508) #6519

[None][infra] Pin the version for triton to 3.3.1 (#6508) #6519

Conversation

chzblych commented Jul 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

chzblych commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

chzblych commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

tensorrt-cicd commented Jul 31, 2025

Uh oh!

chzblych commented Aug 1, 2025

Uh oh!

tensorrt-cicd commented Aug 1, 2025

Uh oh!

tensorrt-cicd commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chzblych commented Jul 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 31, 2025 •

edited

Loading